From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io
Cc: ard.biesheuvel@linaro.org, Alexei Fedorov <Alexei.Fedorov@arm.com>
Subject: [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors
Date: Thu, 13 Jun 2019 17:18:31 +0100 [thread overview]
Message-ID: <20190613161833.30102-1-leif.lindholm@linaro.org> (raw)
TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
between architectures. This upsets VS2017 when building for 32-bit ARM
(and likely would if building for IA32 too). Similarly, some internal
calculations used UINTN for operating on fixed-size fields, giving
further issues.
BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997
PL031RealTimeClockLib needed an adjustment to support the resulting API
change, but frankly that change just makes the code agree with the
comments surrounding it.
This series cleans up the type handling Visual Studio complains about.
This is not a proper overhaul of the library, just a fix of encountered
build errors.
Leif Lindholm (2):
ArmPlatformPkg: use UINT32 epoch second counter
EmbeddedPkg: improve TimeBaseLib type safety
ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 3 ++-
EmbeddedPkg/Include/Library/TimeBaseLib.h | 4 ++--
EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 18 +++++++++---------
3 files changed, 13 insertions(+), 12 deletions(-)
Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
--
2.11.0
next reply other threads:[~2019-06-13 16:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 16:18 Leif Lindholm [this message]
2019-06-13 16:20 ` [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors Ard Biesheuvel
2019-06-13 16:21 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-06-17 11:06 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190613161833.30102-1-leif.lindholm@linaro.org \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox