* [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
@ 2019-06-14 20:21 Leif Lindholm
2019-06-15 6:01 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-06-20 15:13 ` Laszlo Ersek
0 siblings, 2 replies; 7+ messages in thread
From: Leif Lindholm @ 2019-06-14 20:21 UTC (permalink / raw)
To: devel
Cc: Feng, Bob C, Liming Gao, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Wu, Hao A
Add comment describing new F: and X: tags for associating maintainership
sections with specific filesystem paths, including wildcards.
Add global section associating *all* code with devel@edk2.groups.io,
and add a magic '<default>' F: tag directing all modifications that
do not hit a rule to the stewards.
Also tag all files in top directory as maintained by the stewards.
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 50 insertions(+)
diff --git a/Maintainers.txt b/Maintainers.txt
index 762a68465979..cd32f9b00170 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -36,6 +36,20 @@ Descriptions of section entries:
Obsolete: Old code. Something tagged obsolete generally means
it has been replaced by a better system and you
should be using that.
+ F: Files and directories with wildcard patterns.
+ A trailing slash includes all files and subdirectory files.
+ F: drivers/net/ all files in and below drivers/net
+ F: drivers/net/* all files in drivers/net, but not below
+ F: */net/* all files in "any top level directory"/net
+ One pattern per line. Multiple F: lines per section acceptable.
+ X: Files and directories that are NOT maintained, same rules as F:
+ Files exclusions are tested after file matches.
+ Can be useful for excluding a specific subdirectory, for instance:
+ F: NetworkPkg/
+ X: NetworkPkg/Ip6Dxe/
+ matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/
+ Magic filename "<default>" denotes all files not caught by any F: rule should
+ be sent.
EDK II
------
@@ -45,8 +59,15 @@ T: git - https://github.com/tianocore/edk2.git
T: git (mirror) - https://bitbucket.org/tianocore/edk2.git
T: svn (read-only, deprecated) - https://svn.code.sf.net/p/edk2/code/trunk/edk2
+All patches CC:d here
+L: devel@edk2.groups.io
+F: *
+F: */
+
Tianocore Stewards
------------------
+F: *
+F: <default>
M: Andrew Fish <afish@apple.com>
M: Laszlo Ersek <lersek@redhat.com>
M: Leif Lindholm <leif.lindholm@linaro.org>
@@ -64,16 +85,19 @@ M: Liming Gao <liming.gao@intel.com>
EDK II Packages:
----------------
ArmPkg
+F: ArmPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPkg
M: Leif Lindholm <leif.lindholm@linaro.org>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
ArmPlatformPkg
+F: ArmPlatformPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/ArmPlatformPkg
M: Leif Lindholm <leif.lindholm@linaro.org>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
ArmVirtPkg
+F: ArmVirtPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/ArmVirtPkg
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
@@ -81,26 +105,31 @@ R: Julien Grall <julien.grall@arm.com>
(Xen modules)
BaseTools
+F: BaseTools/
W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
M: Bob Feng <bob.c.feng@intel.com>
M: Liming Gao <liming.gao@intel.com>
CryptoPkg
+F: CryptoPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/CryptoPkg
M: Jian Wang <jian.j.wang@intel.com>
R: Ting Ye <ting.ye@intel.com>
DynamicTablesPkg
+F: DynamicTablesPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/DynamicTablesPkg
M: Sami Mujawar <Sami.Mujawar@arm.com>
M: Alexei Fedorov <Alexei.Fedorov@arm.com>
EmbeddedPkg
+F: EmbeddedPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/EmbeddedPkg
M: Leif Lindholm <leif.lindholm@linaro.org>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
EmulatorPkg
+F: EmulatorPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/EmulatorPkg
M: Jordan Justen <jordan.l.justen@intel.com>
M: Andrew Fish <afish@apple.com>
@@ -108,55 +137,65 @@ M: Ray Ni <ray.ni@intel.com>
S: Maintained
FatPkg
+F: FatPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/Edk2-fat-driver
M: Ray Ni <ray.ni@intel.com>
T: svn - https://svn.code.sf.net/p/edk2-fatdriver2/code/trunk/EnhancedFat
T: git - https://github.com/tianocore/edk2-FatPkg.git
FmpDevicePkg
+F: FmpDevicePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/FmpDevicePkg
M: Liming Gao <liming.gao@intel.com>
M: Michael D Kinney <michael.d.kinney@intel.com>
IntelFrameworkModulePkg
+F: IntelFrameworkModulePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFrameworkModulePkg
M: Liming Gao <liming.gao@intel.com>
IntelFrameworkPkg
+F: IntelFrameworkPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFrameworkPkg
M: Michael D Kinney <michael.d.kinney@intel.com>
M: Liming Gao <liming.gao@intel.com>
IntelFsp2Pkg
+F: IntelFsp2Pkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2Pkg
M: Chasel Chiu <chasel.chiu@intel.com>
R: Nate DeSimone <nathaniel.l.desimone@intel.com>
R: Star Zeng <star.zeng@intel.com>
IntelFsp2WrapperPkg
+F: IntelFsp2WrapperPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2WrapperPkg
M: Chasel Chiu <chasel.chiu@intel.com>
R: Nate DeSimone <nathaniel.l.desimone@intel.com>
R: Star Zeng <star.zeng@intel.com>
IntelFspPkg
+F: IntelFspPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg
M: Chasel Chiu <chasel.chiu@intel.com>
R: Nate DeSimone <nathaniel.l.desimone@intel.com>
R: Star Zeng <star.zeng@intel.com>
IntelFspWrapperPkg
+F: IntelFspWrapperPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspWrapperPkg
M: Chasel Chiu <chasel.chiu@intel.com>
R: Nate DeSimone <nathaniel.l.desimone@intel.com>
R: Star Zeng <star.zeng@intel.com>
IntelSiliconPkg
+F: IntelSiliconPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/IntelSiliconPkg
M: Ray Ni <ray.ni@intel.com>
M: Rangasai V Chaganty <rangasai.v.chaganty@intel.com>
MdeModulePkg
+F: MdeModulePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
M: Jian J Wang <jian.j.wang@intel.com>
M: Hao A Wu <hao.a.wu@intel.com>
@@ -166,16 +205,19 @@ R: Ray Ni <ray.ni@intel.com>
R: Star Zeng <star.zeng@intel.com>
MdePkg
+F: MdePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/MdePkg
M: Michael D Kinney <michael.d.kinney@intel.com>
M: Liming Gao <liming.gao@intel.com>
NetworkPkg
+F: NetworkPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/NetworkPkg
M: Siyuan Fu <siyuan.fu@intel.com>
M: Jiaxin Wu <jiaxin.wu@intel.com>
OvmfPkg
+F: OvmfPkg/
W: http://www.tianocore.org/ovmf/
M: Jordan Justen <jordan.l.justen@intel.com>
M: Laszlo Ersek <lersek@redhat.com>
@@ -191,16 +233,19 @@ R: Stefan Berger <stefanb@linux.ibm.com>
S: Maintained
PcAtChipsetPkg
+F: PcAtChipsetPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/PcAtChipsetPkg
M: Ray Ni <ray.ni@intel.com>
SecurityPkg
+F: SecurityPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/SecurityPkg
M: Chao Zhang <chao.b.zhang@intel.com>
M: Jiewen Yao <jiewen.yao@intel.com>
M: Jian Wang <jian.j.wang@intel.com>
ShellPkg
+F: ShellPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/ShellPkg
M: Jaben Carsey <jaben.carsey@intel.com>
M: Ray Ni <ray.ni@intel.com>
@@ -214,21 +259,25 @@ M: Leif Lindholm <leif.lindholm@linaro.org> (ARM/AArch64)
M: Ard Biesheuvel <ard.biesheuvel@linaro.org> (ARM/AArch64)
SignedCapsulePkg
+F: SignedCapsulePkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/SignedCapsulePkg
M: Jiewen Yao <jiewen.yao@intel.com>
M: Chao Zhang <chao.b.zhang@intel.com>
SourceLevelDebugPkg
+F: SourceLevelDebugPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/SourceLevelDebugPkg
M: Hao A Wu <hao.a.wu@intel.com>
UefiCpuPkg
+F: UefiCpuPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/UefiCpuPkg
M: Eric Dong <eric.dong@intel.com>
M: Ray Ni <ray.ni@intel.com>
R: Laszlo Ersek <lersek@redhat.com>
UefiPayloadPkg
+F: UefiPayloadPkg/
W: https://github.com/tianocore/tianocore.github.io/wiki/UefiPayloadPkg
M: Maurice Ma <maurice.ma@intel.com>
M: Guo Dong <guo.dong@intel.com>
@@ -236,6 +285,7 @@ M: Benjamin You <benjamin.you@intel.com>
S: Maintained
StandaloneMmPkg
+F: StandaloneMmPkg/
M: Achin Gupta <achin.gupta@arm.com>
M: Jiewen Yao <jiewen.yao@intel.com>
R: Supreeth Venkatesh <supreeth.venkatesh@arm.com>
--
2.11.0
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
2019-06-14 20:21 [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Leif Lindholm
@ 2019-06-15 6:01 ` Philippe Mathieu-Daudé
2019-06-18 3:30 ` Ni, Ray
[not found] ` <15A92D638F8524EE.27464@groups.io>
2019-06-20 15:13 ` Laszlo Ersek
1 sibling, 2 replies; 7+ messages in thread
From: Philippe Mathieu-Daudé @ 2019-06-15 6:01 UTC (permalink / raw)
To: devel, leif.lindholm, Jordan Justen, Marc-André Lureau,
Stefan Berger, Anthony Perard, Julien Grall
Cc: Feng, Bob C, Liming Gao, Andrew Fish, Laszlo Ersek,
Michael D Kinney, Wu, Hao A
On 6/14/19 10:21 PM, Leif Lindholm wrote:
> Add comment describing new F: and X: tags for associating maintainership
> sections with specific filesystem paths, including wildcards.
>
> Add global section associating *all* code with devel@edk2.groups.io,
> and add a magic '<default>' F: tag directing all modifications that
> do not hit a rule to the stewards.
>
> Also tag all files in top directory as maintained by the stewards.
>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 762a68465979..cd32f9b00170 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -36,6 +36,20 @@ Descriptions of section entries:
> Obsolete: Old code. Something tagged obsolete generally means
> it has been replaced by a better system and you
> should be using that.
> + F: Files and directories with wildcard patterns.
> + A trailing slash includes all files and subdirectory files.
> + F: drivers/net/ all files in and below drivers/net
> + F: drivers/net/* all files in drivers/net, but not below
> + F: */net/* all files in "any top level directory"/net
> + One pattern per line. Multiple F: lines per section acceptable.
> + X: Files and directories that are NOT maintained, same rules as F:
> + Files exclusions are tested after file matches.
> + Can be useful for excluding a specific subdirectory, for instance:
> + F: NetworkPkg/
> + X: NetworkPkg/Ip6Dxe/
> + matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/
> + Magic filename "<default>" denotes all files not caught by any F: rule should
> + be sent.
>
[...]
>
> OvmfPkg
> +F: OvmfPkg/
> W: http://www.tianocore.org/ovmf/
> M: Jordan Justen <jordan.l.justen@intel.com>
> M: Laszlo Ersek <lersek@redhat.com>
> @@ -191,16 +233,19 @@ R: Stefan Berger <stefanb@linux.ibm.com>
> S: Maintained
Possible follow-up patch:
-- >8 --
OvmfPkg
F: OvmfPkg/
W: http://www.tianocore.org/ovmf/
M: Jordan Justen <jordan.l.justen@intel.com>
M: Laszlo Ersek <lersek@redhat.com>
M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
+S: Maintained
+
+OvmfPkg (Xen modules)
+F: OvmfPkg/*/Xen*
+M: Jordan Justen <jordan.l.justen@intel.com>
+M: Laszlo Ersek <lersek@redhat.com>
+M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Anthony Perard <anthony.perard@citrix.com>
- (Xen modules)
R: Julien Grall <julien.grall@arm.com>
- (Xen modules)
+S: Maintained
+
+OvmfPkg (TPM2 modules)
+F: MdePkg/Include/IndustryStandard/Tpm2*
+F: SecurityPkg/*/Tpm2*
+M: Jordan Justen <jordan.l.justen@intel.com>
+M: Laszlo Ersek <lersek@redhat.com>
+M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
R: Marc-André Lureau <marcandre.lureau@redhat.com>
- (TPM2 modules)
R: Stefan Berger <stefanb@linux.ibm.com>
- (TPM2 modules)
S: Maintained
---
Although TPM2 deserves its own section IMHO.
(Ditto with ArmVirtPkg Xen).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
2019-06-15 6:01 ` [edk2-devel] " Philippe Mathieu-Daudé
@ 2019-06-18 3:30 ` Ni, Ray
[not found] ` <15A92D638F8524EE.27464@groups.io>
1 sibling, 0 replies; 7+ messages in thread
From: Ni, Ray @ 2019-06-18 3:30 UTC (permalink / raw)
To: devel@edk2.groups.io, 'philmd@redhat.com',
leif.lindholm@linaro.org, Justen, Jordan L,
Marc-André Lureau, Stefan Berger, Anthony Perard,
Julien Grall
Cc: Feng, Bob C, Gao, Liming, Andrew Fish, Laszlo Ersek,
Kinney, Michael D, Wu, Hao A
> +
> +OvmfPkg (TPM2 modules)
How about just say "TPM2 modules"?
> +F: MdePkg/Include/IndustryStandard/Tpm2*
> +F: SecurityPkg/*/Tpm2*
> +M: Jordan Justen <jordan.l.justen@intel.com>
> +M: Laszlo Ersek <lersek@redhat.com>
> +M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> - (TPM2 modules)
> R: Stefan Berger <stefanb@linux.ibm.com>
> - (TPM2 modules)
> S: Maintained
> ---
>
> Although TPM2 deserves its own section IMHO.
> (Ditto with ArmVirtPkg Xen).
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
[not found] ` <15A92D638F8524EE.27464@groups.io>
@ 2019-06-18 5:32 ` Ni, Ray
2019-06-18 11:17 ` Leif Lindholm
0 siblings, 1 reply; 7+ messages in thread
From: Ni, Ray @ 2019-06-18 5:32 UTC (permalink / raw)
To: devel@edk2.groups.io, Ni, Ray, 'philmd@redhat.com',
leif.lindholm@linaro.org, Justen, Jordan L,
Marc-André Lureau, Stefan Berger, Anthony Perard,
Julien Grall
Cc: Feng, Bob C, Gao, Liming, Andrew Fish, Laszlo Ersek,
Kinney, Michael D, Wu, Hao A
Even the five people claims to be the maintainers of all TPM2 modules, I still think
the maintainers.txt is not very human readable.
I suggest a txt file as below:
MdePkg
......
F: MdePkg/Include/IndustryStandard/Tpm2*
R: Marc-André Lureau <marcandre.lureau@redhat.com>
R: Stefan Berger <stefanb@linux.ibm.com>
SecurityPkg
......
F: SecurityPkg/*/Tpm2*
R: Marc-André Lureau <marcandre.lureau@redhat.com>
R: Stefan Berger <stefanb@linux.ibm.com>
So developers who change a certain package can firstly find the
correct package section, then check F-tag to understand who
are the maintainers and reviewers.
> -----Original Message-----
> From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> Sent: Tuesday, June 18, 2019 11:31 AM
> To: devel@edk2.groups.io; 'philmd@redhat.com' <philmd@redhat.com>;
> leif.lindholm@linaro.org; Justen, Jordan L <jordan.l.justen@intel.com>;
> Marc-André Lureau <marcandre.lureau@redhat.com>; Stefan Berger
> <stefanb@linux.ibm.com>; Anthony Perard <anthony.perard@citrix.com>;
> Julien Grall <julien.grall@arm.com>
> Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> Wu, Hao A <hao.a.wu@intel.com>
> Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for
> filesystem area descriptions
>
> > +
> > +OvmfPkg (TPM2 modules)
>
> How about just say "TPM2 modules"?
>
> > +F: MdePkg/Include/IndustryStandard/Tpm2*
> > +F: SecurityPkg/*/Tpm2*
> > +M: Jordan Justen <jordan.l.justen@intel.com>
> > +M: Laszlo Ersek <lersek@redhat.com>
> > +M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > R: Marc-André Lureau <marcandre.lureau@redhat.com>
> > - (TPM2 modules)
> > R: Stefan Berger <stefanb@linux.ibm.com>
> > - (TPM2 modules)
> > S: Maintained
> > ---
> >
> > Although TPM2 deserves its own section IMHO.
> > (Ditto with ArmVirtPkg Xen).
>
>
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
2019-06-18 5:32 ` Ni, Ray
@ 2019-06-18 11:17 ` Leif Lindholm
0 siblings, 0 replies; 7+ messages in thread
From: Leif Lindholm @ 2019-06-18 11:17 UTC (permalink / raw)
To: Ni, Ray
Cc: devel@edk2.groups.io, 'philmd@redhat.com', Feng, Bob C,
Gao, Liming, Andrew Fish, Laszlo Ersek, Kinney, Michael D,
Wu, Hao A
Hi Ray,
This brings us to the core of the topic.
This format permits (like it's used for Linux and QEMU) maintainership
to be assigned based on logical function unrestricted by directory
structure.
See
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v5.2-rc5#n17082
https://git.qemu.org/?p=qemu.git;a=blob;f=MAINTAINERS;h=d32c5c231329c76b038c8479e0516b4fa5af6b1b;hb=HEAD#l1232
for a substantial example from each.
>From recent discussions on the need to break down MdeModulePkg
maintainership to manageable chunks, I had the impression we wanted to
do something similar. That was certainly part of my reason for writing
the script.
(Note that this does not prevent there being overall package
maintainers like today. Arguably, it simplifies it since the formats
permit overlap for sections.)
Best Regards,
Leif
On Tue, Jun 18, 2019 at 05:32:38AM +0000, Ni, Ray wrote:
> Even the five people claims to be the maintainers of all TPM2 modules, I still think
> the maintainers.txt is not very human readable.
>
> I suggest a txt file as below:
> MdePkg
> ......
> F: MdePkg/Include/IndustryStandard/Tpm2*
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Stefan Berger <stefanb@linux.ibm.com>
>
> SecurityPkg
> ......
> F: SecurityPkg/*/Tpm2*
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Stefan Berger <stefanb@linux.ibm.com>
>
>
> So developers who change a certain package can firstly find the
> correct package section, then check F-tag to understand who
> are the maintainers and reviewers.
>
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Tuesday, June 18, 2019 11:31 AM
> > To: devel@edk2.groups.io; 'philmd@redhat.com' <philmd@redhat.com>;
> > leif.lindholm@linaro.org; Justen, Jordan L <jordan.l.justen@intel.com>;
> > Marc-André Lureau <marcandre.lureau@redhat.com>; Stefan Berger
> > <stefanb@linux.ibm.com>; Anthony Perard <anthony.perard@citrix.com>;
> > Julien Grall <julien.grall@arm.com>
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Wu, Hao A <hao.a.wu@intel.com>
> > Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for
> > filesystem area descriptions
> >
> > > +
> > > +OvmfPkg (TPM2 modules)
> >
> > How about just say "TPM2 modules"?
> >
> > > +F: MdePkg/Include/IndustryStandard/Tpm2*
> > > +F: SecurityPkg/*/Tpm2*
> > > +M: Jordan Justen <jordan.l.justen@intel.com>
> > > +M: Laszlo Ersek <lersek@redhat.com>
> > > +M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > > R: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > - (TPM2 modules)
> > > R: Stefan Berger <stefanb@linux.ibm.com>
> > > - (TPM2 modules)
> > > S: Maintained
> > > ---
> > >
> > > Although TPM2 deserves its own section IMHO.
> > > (Ditto with ArmVirtPkg Xen).
> >
> >
> >
>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
2019-06-14 20:21 [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Leif Lindholm
2019-06-15 6:01 ` [edk2-devel] " Philippe Mathieu-Daudé
@ 2019-06-20 15:13 ` Laszlo Ersek
2019-06-20 15:22 ` Leif Lindholm
1 sibling, 1 reply; 7+ messages in thread
From: Laszlo Ersek @ 2019-06-20 15:13 UTC (permalink / raw)
To: devel, leif.lindholm
Cc: Feng, Bob C, Liming Gao, Andrew Fish, Michael D Kinney, Wu, Hao A
On 06/14/19 22:21, Leif Lindholm wrote:
> Add comment describing new F: and X: tags for associating maintainership
> sections with specific filesystem paths, including wildcards.
>
> Add global section associating *all* code with devel@edk2.groups.io,
> and add a magic '<default>' F: tag directing all modifications that
> do not hit a rule to the stewards.
>
> Also tag all files in top directory as maintained by the stewards.
>
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> 1 file changed, 50 insertions(+)
>
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 762a68465979..cd32f9b00170 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -36,6 +36,20 @@ Descriptions of section entries:
> Obsolete: Old code. Something tagged obsolete generally means
> it has been replaced by a better system and you
> should be using that.
> + F: Files and directories with wildcard patterns.
> + A trailing slash includes all files and subdirectory files.
> + F: drivers/net/ all files in and below drivers/net
> + F: drivers/net/* all files in drivers/net, but not below
> + F: */net/* all files in "any top level directory"/net
> + One pattern per line. Multiple F: lines per section acceptable.
(1) Looks good, but I suggest updating the example pathnames so they
feel more "native" to edk2 (use actual edk2 pathnames as examples?)
> + X: Files and directories that are NOT maintained, same rules as F:
> + Files exclusions are tested after file matches.
> + Can be useful for excluding a specific subdirectory, for instance:
> + F: NetworkPkg/
> + X: NetworkPkg/Ip6Dxe/
> + matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/
Yep, this feels native.
> + Magic filename "<default>" denotes all files not caught by any F: rule should
> + be sent.
(2) drop "should be sent"? (Sorry if my English parser failed me.)
With those updates:
Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
Laszlo
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions
2019-06-20 15:13 ` Laszlo Ersek
@ 2019-06-20 15:22 ` Leif Lindholm
0 siblings, 0 replies; 7+ messages in thread
From: Leif Lindholm @ 2019-06-20 15:22 UTC (permalink / raw)
To: Laszlo Ersek
Cc: devel, Feng, Bob C, Liming Gao, Andrew Fish, Michael D Kinney,
Wu, Hao A
On Thu, Jun 20, 2019 at 05:13:53PM +0200, Laszlo Ersek wrote:
> On 06/14/19 22:21, Leif Lindholm wrote:
> > Add comment describing new F: and X: tags for associating maintainership
> > sections with specific filesystem paths, including wildcards.
> >
> > Add global section associating *all* code with devel@edk2.groups.io,
> > and add a magic '<default>' F: tag directing all modifications that
> > do not hit a rule to the stewards.
> >
> > Also tag all files in top directory as maintained by the stewards.
> >
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> > Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> > 1 file changed, 50 insertions(+)
> >
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 762a68465979..cd32f9b00170 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -36,6 +36,20 @@ Descriptions of section entries:
> > Obsolete: Old code. Something tagged obsolete generally means
> > it has been replaced by a better system and you
> > should be using that.
> > + F: Files and directories with wildcard patterns.
> > + A trailing slash includes all files and subdirectory files.
> > + F: drivers/net/ all files in and below drivers/net
> > + F: drivers/net/* all files in drivers/net, but not below
> > + F: */net/* all files in "any top level directory"/net
> > + One pattern per line. Multiple F: lines per section acceptable.
>
> (1) Looks good, but I suggest updating the example pathnames so they
> feel more "native" to edk2 (use actual edk2 pathnames as examples?)
I could have sworn I changed those too...
Yeah, definitely will fix for v1.
> > + X: Files and directories that are NOT maintained, same rules as F:
> > + Files exclusions are tested after file matches.
> > + Can be useful for excluding a specific subdirectory, for instance:
> > + F: NetworkPkg/
> > + X: NetworkPkg/Ip6Dxe/
> > + matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/
>
> Yep, this feels native.
>
> > + Magic filename "<default>" denotes all files not caught by any F: rule should
> > + be sent.
>
> (2) drop "should be sent"? (Sorry if my English parser failed me.)
Actually, this was meant to be
Magic filename "<default>" denotes where all files not caught by any F: rule
should be sent. ^ ^
But I like your version better.
> With those updates:
>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
Thanks!
/
Leif
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-20 15:22 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-14 20:21 [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Leif Lindholm
2019-06-15 6:01 ` [edk2-devel] " Philippe Mathieu-Daudé
2019-06-18 3:30 ` Ni, Ray
[not found] ` <15A92D638F8524EE.27464@groups.io>
2019-06-18 5:32 ` Ni, Ray
2019-06-18 11:17 ` Leif Lindholm
2019-06-20 15:13 ` Laszlo Ersek
2019-06-20 15:22 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox