Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Thu, Jun 13, 2019 at 06:21:31PM +0200, Philippe Mathieu-Daudé wrote:
> On 6/13/19 6:18 PM, Leif Lindholm wrote:
> > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs
> > between architectures. This upsets VS2017 when building for 32-bit ARM
> > (and likely would if building for IA32 too). Similarly, some internal
> > calculations used UINTN for operating on fixed-size fields, giving
> > further issues.
> > 
> > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997
> > 
> > PL031RealTimeClockLib needed an adjustment to support the resulting API
> > change, but frankly that change just makes the code agree with the
> > comments surrounding it.
> > 
> > This series cleans up the type handling Visual Studio complains about.
> > This is not a proper overhaul of the library, just a fix of encountered
> > build errors.
> > 
> > Leif Lindholm (2):
> >   ArmPlatformPkg: use UINT32 epoch second counter
> >   EmbeddedPkg: improve TimeBaseLib type safety
> > 
> >  ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c |  3 ++-
> >  EmbeddedPkg/Include/Library/TimeBaseLib.h                            |  4 ++--
> >  EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c                        | 18 +++++++++---------
> >  3 files changed, 13 insertions(+), 12 deletions(-)
> > 
> > Cc: Alexei Fedorov <Alexei.Fedorov@arm.com>
> > 
> 
> Series:
> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>

Thanks!
Series pushed as 2378ea55151e..1d7571166fa8.

/
    Leif