From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Zp3ohoSW; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Mon, 17 Jun 2019 04:06:12 -0700 Received: by mail-wm1-f68.google.com with SMTP id c6so8634213wml.0 for ; Mon, 17 Jun 2019 04:06:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=OCNHONVmzGMWZ6ENJDDHk1ldfanMTgM15GQLyj68ybw=; b=Zp3ohoSWBO6LwXpG8PSia0Jf/NUvR/VplwBklejTZacrouURZoLYeoeTdki9KoZl4I mRfBP1D7UvxCyA3M3G32QeSyP+dAt4+8LIiijYSdUK/XleWBxluFlA1MRSJJtE9GLbvy 1M12TNMKUoOoO8c+5eFnMltB8pLKBq0YIo1u3zk1tJ1NAEP5Sc88r4NN7Mtkt/hHQM98 rtYVqnPGzjkswYyFQCX0TjG/gobG+B1yaHA7pYPwb21my8R6Yc33Rw5+LZe9Kl6O2IMh 4hV+V3UisaNqcmaHjg2SXT/MehnHiGSek6wq1dKhPB3APBcIgSJDWIblyZ6WEicvocVP XzDQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=OCNHONVmzGMWZ6ENJDDHk1ldfanMTgM15GQLyj68ybw=; b=Umb6kOUpKssIyjCRZylLsmQObf9R2rkpnag4nCoh1AYAcjqbtOvLWbDtdmfgEchoVg d11aNCVMGLqBmQAtu9C8d4pu2082cpVevtpUx01wfFSr6IkbXxbrfW64RAutOkzmyhh7 imku22i2JfqGY/zwKEmk/w9LzeR+pzynF+M/0+mrXpJpS+vcdQg7QHsHiYe/nqxh4D/E Gb7PmRnli7PIU/8wtD/02yhacp+MGW11XoiYTXPr9W7JEz7RzVbAVbw5MgiuncCu9sE/ oWDrraIe8eSrU9no6As6qW86ZKoywGdK8y6Ho7QTP0MNLs1vgzHH9d7dSb4W7xgw6Gse aUBg== X-Gm-Message-State: APjAAAVk7h/IdKakh1cwGODG6tTtskyOYetp8JLrT4lpIsiVTGEoaten k4fR//IWsxH1+QX+iQ9DoTADiw== X-Google-Smtp-Source: APXvYqz19+LMoeih8LcmSMLAhbDFZxSkPIbgZkXVvXyB0hQRqkcEKOLrqWZ4oKd9IEXk+cL0ZFwyrQ== X-Received: by 2002:a1c:7e90:: with SMTP id z138mr16369096wmc.128.1560769570370; Mon, 17 Jun 2019 04:06:10 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y6sm10182402wrp.12.2019.06.17.04.06.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 17 Jun 2019 04:06:09 -0700 (PDT) Date: Mon, 17 Jun 2019 12:06:08 +0100 From: "Leif Lindholm" To: Philippe =?iso-8859-1?Q?Mathieu-Daud=E9?= Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, Alexei Fedorov Subject: Re: [edk2-devel] [PATCH 0/2] EmbeddedPkg,ArmPlatformPkg: fix VS2017 TimeBaseLib build errors Message-ID: <20190617110607.l35a6xywd7d4hdmq@bivouac.eciton.net> References: <20190613161833.30102-1-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Jun 13, 2019 at 06:21:31PM +0200, Philippe Mathieu-Daudé wrote: > On 6/13/19 6:18 PM, Leif Lindholm wrote: > > TimeBaseLib EfiTimeToEpoch returns a UINTN, meaning its behaviour differs > > between architectures. This upsets VS2017 when building for 32-bit ARM > > (and likely would if building for IA32 too). Similarly, some internal > > calculations used UINTN for operating on fixed-size fields, giving > > further issues. > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=997 > > > > PL031RealTimeClockLib needed an adjustment to support the resulting API > > change, but frankly that change just makes the code agree with the > > comments surrounding it. > > > > This series cleans up the type handling Visual Studio complains about. > > This is not a proper overhaul of the library, just a fix of encountered > > build errors. > > > > Leif Lindholm (2): > > ArmPlatformPkg: use UINT32 epoch second counter > > EmbeddedPkg: improve TimeBaseLib type safety > > > > ArmPlatformPkg/Library/PL031RealTimeClockLib/PL031RealTimeClockLib.c | 3 ++- > > EmbeddedPkg/Include/Library/TimeBaseLib.h | 4 ++-- > > EmbeddedPkg/Library/TimeBaseLib/TimeBaseLib.c | 18 +++++++++--------- > > 3 files changed, 13 insertions(+), 12 deletions(-) > > > > Cc: Alexei Fedorov > > > > Series: > Reviewed-by: Philippe Mathieu-Daude Thanks! Series pushed as 2378ea55151e..1d7571166fa8. / Leif