Re: [edk2-devel] [edk2-platforms] [patch v2 1/2] Platform/Intel: Add UserInterfaceFeaturePkg

["Leif Lindholm" <leif.lindholm@linaro.org>]

Hi Dandan,

On Mon, Jun 17, 2019 at 02:51:45PM +0800, Dandan Bi wrote:
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1545
> 
> Add new package UserInterfaceFeaturePkg in Platform/Intel/
> folder. It will keep UI related modules in this package.
> 
> We plan add UserAuthentication modules in Platform/Intel.
> Firstly we add a new package UserInterfaceFeaturePkg where
> add the UserAuthentication modules into.
> Package name follows the discussion in:
> https://edk2.groups.io/g/devel/message/42286
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  Maintainers.txt                               |  4 ++++
>  .../UserInterfaceFeaturePkg.dec               | 19 +++++++++++++++
>  .../UserInterfaceFeaturePkg.dsc               | 23 +++++++++++++++++++
>  3 files changed, 46 insertions(+)
>  create mode 100644 Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
>  create mode 100644 Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index cb9e15e880..c55a285fa1 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -71,10 +71,14 @@ R: Liming Gao <liming.gao@intel.com>
>  
>  Platform/Intel/DebugFeaturePkg
>  M: Eric Dong <eric.dong@intel.com>
>  R: Liming Gao <liming.gao@intel.com>
>  
> +Platform/Intel/UserInterfaceFeaturePkg
> +M: Dandan Bi <dandan.bi@intel.com>
> +R: Liming Gao <liming.gao@intel.com>
> +

Could you please cc all of the top-level maintainers (me, Ard and
Mike) when modifying Maintainers.txt?
Once the GetMaintainer.py we'll be able to do all of this more cleanly.

I'm not saying you need all of our Reviewed-by:, but I'd like to not
miss when new maintainerships are being added.

/
    Leif

>  Platform/Intel/ClevoOpenBoardPkg
>  M: Michael Kubacki <michael.a.kubacki@intel.com>
>  M: Ankit Sinha <ankit.sinha@intel.com>
>  M: Nate DeSimone <nathaniel.l.desimone@intel.com>
>  
> diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
> new file mode 100644
> index 0000000000..7162637e24
> --- /dev/null
> +++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dec
> @@ -0,0 +1,19 @@
> +## @file
> +# This package provides UI related modules.
> +#
> +# The DEC files are used by the utilities that parse DSC and
> +# INF files to generate AutoGen.c and AutoGen.h files
> +# for the build infrastructure.
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  DEC_SPECIFICATION = 0x00010017
> +  PACKAGE_NAME      = UserInterfaceFeaturePkg
> +  PACKAGE_VERSION   = 0.1
> +  PACKAGE_GUID      = 5A92199C-C2ED-4A3F-9ED0-C278DEA0DA47
> +
> diff --git a/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> new file mode 100644
> index 0000000000..7098affee9
> --- /dev/null
> +++ b/Platform/Intel/UserInterfaceFeaturePkg/UserInterfaceFeaturePkg.dsc
> @@ -0,0 +1,23 @@
> +## @file
> +# This package provides UI related modules.
> +#
> +# The DEC files are used by the utilities that parse DSC and
> +# INF files to generate AutoGen.c and AutoGen.h files
> +# for the build infrastructure.
> +#
> +# Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +#
> +# SPDX-License-Identifier: BSD-2-Clause-Patent
> +#
> +##
> +
> +[Defines]
> +  PLATFORM_NAME                  = UserInterfaceFeaturePkg
> +  PLATFORM_GUID                  = 66536B4C-84A3-42FD-B0AE-603414A4CE9E
> +  PLATFORM_VERSION               = 0.1
> +  DSC_SPECIFICATION              = 0x00010005
> +  OUTPUT_DIRECTORY               = Build/UserInterfaceFeaturePkg
> +  SUPPORTED_ARCHITECTURES        = IA32|X64
> +  BUILD_TARGETS                  = DEBUG|RELEASE|NOOPT
> +  SKUID_IDENTIFIER               = DEFAULT
> +
> -- 
> 2.18.0.windows.1
> 
> 
> 
>