Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

["Leif Lindholm" <leif.lindholm@linaro.org>]

Hi Ray,

This brings us to the core of the topic.

This format permits (like it's used for Linux and QEMU) maintainership
to be assigned based on logical function unrestricted by directory
structure.

See
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v5.2-rc5#n17082
https://git.qemu.org/?p=qemu.git;a=blob;f=MAINTAINERS;h=d32c5c231329c76b038c8479e0516b4fa5af6b1b;hb=HEAD#l1232
for a substantial example from each.

>From recent discussions on the need to break down MdeModulePkg
maintainership to manageable chunks, I had the impression we wanted to
do something similar. That was certainly part of my reason for writing
the script.

(Note that this does not prevent there being overall package
maintainers like today. Arguably, it simplifies it since the formats
permit overlap for sections.)

Best Regards,

Leif

On Tue, Jun 18, 2019 at 05:32:38AM +0000, Ni, Ray wrote:
> Even the five people claims to be the maintainers of all TPM2 modules, I still think
> the maintainers.txt is not very human readable.
> 
> I suggest a txt file as below:
> MdePkg
> ......
> F: MdePkg/Include/IndustryStandard/Tpm2*
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Stefan Berger <stefanb@linux.ibm.com>
> 
> SecurityPkg
> ......
> F: SecurityPkg/*/Tpm2*
> R: Marc-André Lureau <marcandre.lureau@redhat.com>
> R: Stefan Berger <stefanb@linux.ibm.com>
> 
> 
> So developers who change a certain package can firstly find the
> correct package section, then check F-tag to understand who
> are the maintainers and reviewers.
> 
> > -----Original Message-----
> > From: devel@edk2.groups.io <devel@edk2.groups.io> On Behalf Of Ni, Ray
> > Sent: Tuesday, June 18, 2019 11:31 AM
> > To: devel@edk2.groups.io; 'philmd@redhat.com' <philmd@redhat.com>;
> > leif.lindholm@linaro.org; Justen, Jordan L <jordan.l.justen@intel.com>;
> > Marc-André Lureau <marcandre.lureau@redhat.com>; Stefan Berger
> > <stefanb@linux.ibm.com>; Anthony Perard <anthony.perard@citrix.com>;
> > Julien Grall <julien.grall@arm.com>
> > Cc: Feng, Bob C <bob.c.feng@intel.com>; Gao, Liming
> > <liming.gao@intel.com>; Andrew Fish <afish@apple.com>; Laszlo Ersek
> > <lersek@redhat.com>; Kinney, Michael D <michael.d.kinney@intel.com>;
> > Wu, Hao A <hao.a.wu@intel.com>
> > Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for
> > filesystem area descriptions
> > 
> > > +
> > > +OvmfPkg (TPM2 modules)
> > 
> > How about just say "TPM2 modules"?
> > 
> > > +F: MdePkg/Include/IndustryStandard/Tpm2*
> > > +F: SecurityPkg/*/Tpm2*
> > > +M: Jordan Justen <jordan.l.justen@intel.com>
> > > +M: Laszlo Ersek <lersek@redhat.com>
> > > +M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > >  R: Marc-André Lureau <marcandre.lureau@redhat.com>
> > > -   (TPM2 modules)
> > >  R: Stefan Berger <stefanb@linux.ibm.com>
> > > -   (TPM2 modules)
> > >  S: Maintained
> > > ---
> > >
> > > Although TPM2 deserves its own section IMHO.
> > > (Ditto with ArmVirtPkg Xen).
> > 
> > 
> > 
>