From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=P6NZtM6Y; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Tue, 18 Jun 2019 04:17:20 -0700 Received: by mail-wr1-f68.google.com with SMTP id k11so13536475wrl.1 for ; Tue, 18 Jun 2019 04:17:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=+yGVWfGaQjlhf3/VoKDYLwC4Kz8EagZ84SlbZWbOVwU=; b=P6NZtM6Yp1Fn8f4gdPxCS50R7Lx2DYih5khswLgtBcJHo4fY2d7+xB9XD4bmp/yaHp mih4BXc3exVHN+n/+GBNdB4Du9Zesw3X95DMakYKae4DJfvMOwRI2IgZJpgcoEPoqdws DASCXhMYYtYjez0BiRIKFxQeY1zTCAp+83ZJaoafDm+sPMGK7SWPD+Myj1Bcf2abhMII IAuSDEg2u/inKYdZDPiL2tFEUPj+C9XnLv0a20Evydj34GfpH5hVW6An1ED1K7rgkWyB cFmYkYfzwfVDBL6Vh4qa4alBy27X9eYYSp/8rrsMuwaaPIPOiE6msrE45bpNbxSQjUpk B2Zg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=+yGVWfGaQjlhf3/VoKDYLwC4Kz8EagZ84SlbZWbOVwU=; b=gadZzrr6ggwKiWIUcsc/b03YbdgPjfDuLLjGDcTLd0wTwdIDbM9Cp1oJ9EoA3f/TrK /LAy1kFCz10Ei8nU7gxmRUlt+d7TRI93nfnCRfLu3/cnZNIovJPT3PnjkNKjtNj/8tvg SNkQxpV0bnthGAEDp3FOIbwOUEsMagcPaQvwokPNtIsBSwKQXPRV31nI7L4mFsfUXc2J 2l8Q7e6zyb1nEVjqmngxTjfkA/GHP4t2H4vTiFSP05kCmMPE9ZUUjPMJoWntLTxuWD5+ bIm0RgmcNuNJYz3BVKpbKA+28pst4rZJUade9w7huODgNkTNvslxFpkBYOLd2x6yvl19 vY8A== X-Gm-Message-State: APjAAAV9hKJ3oCpNY/tiq6fXIANe5iS4SGNd+TUYrAG+VWwqicXc70iF Inn3u/HVk1nVOZdWvzLv5Rz/Eg== X-Google-Smtp-Source: APXvYqxhH7araZUJOijgKfKHHpKnDq2crPVmKij1e6F6CFuh4k3AuOyMLQZiOld5ePu8q6uH1MOqsQ== X-Received: by 2002:adf:f04d:: with SMTP id t13mr17106553wro.36.1560856638351; Tue, 18 Jun 2019 04:17:18 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id g5sm15650226wrp.29.2019.06.18.04.17.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 18 Jun 2019 04:17:17 -0700 (PDT) Date: Tue, 18 Jun 2019 12:17:16 +0100 From: "Leif Lindholm" To: "Ni, Ray" Cc: "devel@edk2.groups.io" , "'philmd@redhat.com'" , "Feng, Bob C" , "Gao, Liming" , Andrew Fish , Laszlo Ersek , "Kinney, Michael D" , "Wu, Hao A" Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Message-ID: <20190618111716.j3mcf3tkvstqdlp5@bivouac.eciton.net> References: <20190614202121.18952-2-leif.lindholm@linaro.org> <15A92D638F8524EE.27464@groups.io> <734D49CCEBEEF84792F5B80ED585239D5C1D58CA@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <734D49CCEBEEF84792F5B80ED585239D5C1D58CA@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit Hi Ray, This brings us to the core of the topic. This format permits (like it's used for Linux and QEMU) maintainership to be assigned based on logical function unrestricted by directory structure. See https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/MAINTAINERS?h=v5.2-rc5#n17082 https://git.qemu.org/?p=qemu.git;a=blob;f=MAINTAINERS;h=d32c5c231329c76b038c8479e0516b4fa5af6b1b;hb=HEAD#l1232 for a substantial example from each. >>From recent discussions on the need to break down MdeModulePkg maintainership to manageable chunks, I had the impression we wanted to do something similar. That was certainly part of my reason for writing the script. (Note that this does not prevent there being overall package maintainers like today. Arguably, it simplifies it since the formats permit overlap for sections.) Best Regards, Leif On Tue, Jun 18, 2019 at 05:32:38AM +0000, Ni, Ray wrote: > Even the five people claims to be the maintainers of all TPM2 modules, I still think > the maintainers.txt is not very human readable. > > I suggest a txt file as below: > MdePkg > ...... > F: MdePkg/Include/IndustryStandard/Tpm2* > R: Marc-André Lureau > R: Stefan Berger > > SecurityPkg > ...... > F: SecurityPkg/*/Tpm2* > R: Marc-André Lureau > R: Stefan Berger > > > So developers who change a certain package can firstly find the > correct package section, then check F-tag to understand who > are the maintainers and reviewers. > > > -----Original Message----- > > From: devel@edk2.groups.io On Behalf Of Ni, Ray > > Sent: Tuesday, June 18, 2019 11:31 AM > > To: devel@edk2.groups.io; 'philmd@redhat.com' ; > > leif.lindholm@linaro.org; Justen, Jordan L ; > > Marc-André Lureau ; Stefan Berger > > ; Anthony Perard ; > > Julien Grall > > Cc: Feng, Bob C ; Gao, Liming > > ; Andrew Fish ; Laszlo Ersek > > ; Kinney, Michael D ; > > Wu, Hao A > > Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for > > filesystem area descriptions > > > > > + > > > +OvmfPkg (TPM2 modules) > > > > How about just say "TPM2 modules"? > > > > > +F: MdePkg/Include/IndustryStandard/Tpm2* > > > +F: SecurityPkg/*/Tpm2* > > > +M: Jordan Justen > > > +M: Laszlo Ersek > > > +M: Ard Biesheuvel > > > R: Marc-André Lureau > > > - (TPM2 modules) > > > R: Stefan Berger > > > - (TPM2 modules) > > > S: Maintained > > > --- > > > > > > Although TPM2 deserves its own section IMHO. > > > (Ditto with ArmVirtPkg Xen). > > > > > > >