public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Stephano Cetola" <stephano.cetola@linux.intel.com>
To: devel@edk2.groups.io
Cc: jordan.l.justen@intel.com, afish@apple.com, ray.ni@intel.com,
	Stephano Cetola <stephano.cetola@linux.intel.com>
Subject: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5
Date: Wed, 19 Jun 2019 09:57:20 -0700	[thread overview]
Message-ID: <20190619165720.4452-1-stephano.cetola@linux.intel.com> (raw)

The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
the HOST_TOOLS should be set to XCODE5.

Also, fix a small typo.

This fixes bug 447:

https://bugzilla.tianocore.org/show_bug.cgi?id=447

Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
---
 EmulatorPkg/build.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
index 558b65e88b..c5bf0bd655 100755
--- a/EmulatorPkg/build.sh
+++ b/EmulatorPkg/build.sh
@@ -60,9 +60,9 @@ case `uname` in
         CLANG_VER=$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 >/dev/null) || true
         if [[ "$CLANG_VER" == *-ccc-host-triple* ]]
         then
-        # only older versions of Xcode support -ccc-host-tripe, for newer versions
+        # only older versions of Xcode support -ccc-host-triple, for newer versions
         # it is -target
-          HOST_TOOLS=XCODE32
+          HOST_TOOLS=XCODE5
           TARGET_TOOLS=XCODE5
         else
           HOST_TOOLS=XCODE32
-- 
2.17.1


             reply	other threads:[~2019-06-19 16:57 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-19 16:57 Stephano Cetola [this message]
2019-06-20 18:59 ` [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5 Jordan Justen
2019-07-13  7:58 ` Jordan Justen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190619165720.4452-1-stephano.cetola@linux.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox