[PATCH] EmulatorPkg: update HOST_TOOLS to xcode5

[PATCH] EmulatorPkg: update HOST_TOOLS to xcode5

[Stephano Cetola]

The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
the HOST_TOOLS should be set to XCODE5.

Also, fix a small typo.

This fixes bug 447:

https://bugzilla.tianocore.org/show_bug.cgi?id=447

Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
---
 EmulatorPkg/build.sh | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
index 558b65e88b..c5bf0bd655 100755
--- a/EmulatorPkg/build.sh
+++ b/EmulatorPkg/build.sh
@@ -60,9 +60,9 @@ case `uname` in
         CLANG_VER=$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 >/dev/null) || true
         if [[ "$CLANG_VER" == *-ccc-host-triple* ]]
         then
-        # only older versions of Xcode support -ccc-host-tripe, for newer versions
+        # only older versions of Xcode support -ccc-host-triple, for newer versions
         # it is -target
-          HOST_TOOLS=XCODE32
+          HOST_TOOLS=XCODE5
           TARGET_TOOLS=XCODE5
         else
           HOST_TOOLS=XCODE32
-- 
2.17.1

Re: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5

[Jordan Justen]

On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
> 
> Also, fix a small typo.
> 
> This fixes bug 447:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=447
> 
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
>  EmulatorPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
> index 558b65e88b..c5bf0bd655 100755
> --- a/EmulatorPkg/build.sh
> +++ b/EmulatorPkg/build.sh
> @@ -60,9 +60,9 @@ case `uname` in
>          CLANG_VER=$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 >/dev/null) || true
>          if [[ "$CLANG_VER" == *-ccc-host-triple* ]]
>          then
> -        # only older versions of Xcode support -ccc-host-tripe, for newer versions
> +        # only older versions of Xcode support -ccc-host-triple, for newer versions

I don't like to include multiple fixes in one patch, but this is a
pretty minor typo.

>          # it is -target
> -          HOST_TOOLS=XCODE32
> +          HOST_TOOLS=XCODE5

Based on the discussion in the bug, this seems right, so:

Reviewed-by: Jordan Justen <jordan.l.justen@intel.com>

>            TARGET_TOOLS=XCODE5
>          else
>            HOST_TOOLS=XCODE32
> -- 
> 2.17.1
> 

Re: [PATCH] EmulatorPkg: update HOST_TOOLS to xcode5

[Jordan Justen]

pushed as 55b9bbf40a1cf9788dd6a7b093851076851fc670

On 2019-06-19 09:57:20, Stephano Cetola wrote:
> The last compiler flag change was for Xcode 5.0, not Xcode 3.2. As such
> the HOST_TOOLS should be set to XCODE5.
> 
> Also, fix a small typo.
> 
> This fixes bug 447:
> 
> https://bugzilla.tianocore.org/show_bug.cgi?id=447
> 
> Signed-off-by: Stephano Cetola <stephano.cetola@linux.intel.com>
> ---
>  EmulatorPkg/build.sh | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/EmulatorPkg/build.sh b/EmulatorPkg/build.sh
> index 558b65e88b..c5bf0bd655 100755
> --- a/EmulatorPkg/build.sh
> +++ b/EmulatorPkg/build.sh
> @@ -60,9 +60,9 @@ case `uname` in
>          CLANG_VER=$(clang -ccc-host-triple x86_64-pc-win32-macho 2>&1 >/dev/null) || true
>          if [[ "$CLANG_VER" == *-ccc-host-triple* ]]
>          then
> -        # only older versions of Xcode support -ccc-host-tripe, for newer versions
> +        # only older versions of Xcode support -ccc-host-triple, for newer versions
>          # it is -target
> -          HOST_TOOLS=XCODE32
> +          HOST_TOOLS=XCODE5
>            TARGET_TOOLS=XCODE5
>          else
>            HOST_TOOLS=XCODE32
> -- 
> 2.17.1
>