Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions

["Leif Lindholm" <leif.lindholm@linaro.org>]

On Thu, Jun 20, 2019 at 05:13:53PM +0200, Laszlo Ersek wrote:
> On 06/14/19 22:21, Leif Lindholm wrote:
> > Add comment describing new F: and X: tags for associating maintainership
> > sections with specific filesystem paths, including wildcards.
> > 
> > Add global section associating *all* code with devel@edk2.groups.io,
> > and add a magic '<default>' F: tag directing all modifications that
> > do not hit a rule to the stewards.
> > 
> > Also tag all files in top directory as maintained by the stewards.
> > 
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++
> >  1 file changed, 50 insertions(+)
> > 
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 762a68465979..cd32f9b00170 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -36,6 +36,20 @@ Descriptions of section entries:
> >       Obsolete:   Old code. Something tagged obsolete generally means
> >                   it has been replaced by a better system and you
> >                   should be using that.
> > +  F: Files and directories with wildcard patterns.
> > +     A trailing slash includes all files and subdirectory files.
> > +     F:   drivers/net/    all files in and below drivers/net
> > +     F:   drivers/net/*   all files in drivers/net, but not below
> > +     F:   */net/*         all files in "any top level directory"/net
> > +     One pattern per line.  Multiple F: lines per section acceptable.
> 
> (1) Looks good, but I suggest updating the example pathnames so they
> feel more "native" to edk2 (use actual edk2 pathnames as examples?)

I could have sworn I changed those too...
Yeah, definitely will fix for v1.

> > +  X: Files and directories that are NOT maintained, same rules as F:
> > +     Files exclusions are tested after file matches.
> > +     Can be useful for excluding a specific subdirectory, for instance:
> > +     F:   NetworkPkg/
> > +     X:   NetworkPkg/Ip6Dxe/
> > +     matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/
> 
> Yep, this feels native.
> 
> > +  Magic filename "<default>" denotes all files not caught by any F: rule should
> > +  be sent.
> 
> (2) drop "should be sent"? (Sorry if my English parser failed me.)

Actually, this was meant to be

Magic filename "<default>" denotes where all files not caught by any F: rule
should be sent.                    ^   ^

But I like your version better.

> With those updates:
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!

/
    Leif