From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Q29tv2SX; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Thu, 20 Jun 2019 08:22:22 -0700 Received: by mail-wm1-f66.google.com with SMTP id u8so3588793wmm.1 for ; Thu, 20 Jun 2019 08:22:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Ap8R6nyOvLDTLd6DFH3FrQUENQqZbf1SGYCHGpXKf+s=; b=Q29tv2SXQlAExg2ictlBkp+055Www38Kjn44hk2hPH5BuFPtbS8frPkseNeo9uPMbJ dCxJWddaQoTFWv5/QEPxMUyuFMEJ0V0bR60Nd6c2P3z8JljcjGYfVtl7WHCRzWwoI7El mLhTbMbmKYxDQSMbd3UuHKTDqsKJ8EvYcMqKUycPs9TXM1GKnhxrWlYifsyZzapu2D87 A8lGR4K3fVIhkij+vmd73qFrwTRs9VdO07LoKDt304a7RKxtjKGFIjyoCjS5bR5eI4Ec h2VAA565QZts3S1uoP7T+O+oDUHdwz1OJXB3qIfyWWCfz8h3A7PdKyc6wqk39lqnR03Z E0OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Ap8R6nyOvLDTLd6DFH3FrQUENQqZbf1SGYCHGpXKf+s=; b=P4DIKw6TgfGqAcxrToblmvSZlmuIu9c7h6A7X3A8P3Y31k1Kt+dYu8adDJvnXhAqwp o3YYj9P8bIC4vFYSs7naOXxpUVpDPUMcs5W7zAsPOM0zj/UnXJri05bCcTptwrrEP+Nr rKOg5UAF1DsfMJZ9XCRcm4ICD2rQfNLSpaA2S0tSJB4+Cz4A7liPtNLFw/K1czS/5vK5 /+6Iau++sU5gTkat40f4WAwh25Zuh+CN5qgVae8tRqV0kCz+yybEgnCYqNYgh82Ad5eN AJ4QSIoDcdjtNn6LykYJuSBLjhkPn0nY6BGpAXgRiyINqwakS7qEnESJdzJt9jF4BsOJ 2jWg== X-Gm-Message-State: APjAAAXS2e2CgCzFIT43OGxrZhdh3dpVM4jHhGGbcGdqQQOhmAM70TYs SyPJybkjtOSNC0MFhpEOqPHEsQ== X-Google-Smtp-Source: APXvYqyI6Esfw4jbyQ2Rh6iM3/iNdBUikdzXvnkXNG1Rhumin5C+9kzTHBJUlEVEJ2gQGwRPd3OAxA== X-Received: by 2002:a1c:188:: with SMTP id 130mr117255wmb.37.1561044140228; Thu, 20 Jun 2019 08:22:20 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id n3sm17199614wro.59.2019.06.20.08.22.19 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2019 08:22:19 -0700 (PDT) Date: Thu, 20 Jun 2019 16:22:18 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, "Feng, Bob C" , Liming Gao , Andrew Fish , Michael D Kinney , "Wu, Hao A" Subject: Re: [edk2-devel] [RFC PATCH 1/3] Maintainers.txt: update for filesystem area descriptions Message-ID: <20190620152218.nfvdplyesev6nhuk@bivouac.eciton.net> References: <20190614202121.18952-2-leif.lindholm@linaro.org> <45e43942-d64f-4155-fa41-3bc3d481f751@redhat.com> MIME-Version: 1.0 In-Reply-To: <45e43942-d64f-4155-fa41-3bc3d481f751@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 20, 2019 at 05:13:53PM +0200, Laszlo Ersek wrote: > On 06/14/19 22:21, Leif Lindholm wrote: > > Add comment describing new F: and X: tags for associating maintainership > > sections with specific filesystem paths, including wildcards. > > > > Add global section associating *all* code with devel@edk2.groups.io, > > and add a magic '' F: tag directing all modifications that > > do not hit a rule to the stewards. > > > > Also tag all files in top directory as maintained by the stewards. > > > > Signed-off-by: Leif Lindholm > > --- > > Maintainers.txt | 50 ++++++++++++++++++++++++++++++++++++++++++++++++++ > > 1 file changed, 50 insertions(+) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index 762a68465979..cd32f9b00170 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -36,6 +36,20 @@ Descriptions of section entries: > > Obsolete: Old code. Something tagged obsolete generally means > > it has been replaced by a better system and you > > should be using that. > > + F: Files and directories with wildcard patterns. > > + A trailing slash includes all files and subdirectory files. > > + F: drivers/net/ all files in and below drivers/net > > + F: drivers/net/* all files in drivers/net, but not below > > + F: */net/* all files in "any top level directory"/net > > + One pattern per line. Multiple F: lines per section acceptable. > > (1) Looks good, but I suggest updating the example pathnames so they > feel more "native" to edk2 (use actual edk2 pathnames as examples?) I could have sworn I changed those too... Yeah, definitely will fix for v1. > > + X: Files and directories that are NOT maintained, same rules as F: > > + Files exclusions are tested after file matches. > > + Can be useful for excluding a specific subdirectory, for instance: > > + F: NetworkPkg/ > > + X: NetworkPkg/Ip6Dxe/ > > + matches all files in and below NetworkPkg excluding NetworkPkgnet/Ip6Dxe/ > > Yep, this feels native. > > > + Magic filename "" denotes all files not caught by any F: rule should > > + be sent. > > (2) drop "should be sent"? (Sorry if my English parser failed me.) Actually, this was meant to be Magic filename "" denotes where all files not caught by any F: rule should be sent. ^ ^ But I like your version better. > With those updates: > > Reviewed-by: Laszlo Ersek Thanks! / Leif