From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=LbVOvrIK; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Thu, 20 Jun 2019 09:07:31 -0700 Received: by mail-wm1-f66.google.com with SMTP id c66so3660068wmf.0 for ; Thu, 20 Jun 2019 09:07:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=JjTC2dNYw8thY8dgHEs8Na7R2kvz+iUwlWRQ70i4pU4=; b=LbVOvrIKkOAk16w0lRdy8Z2cpOyVIUlT2YhUKy4VHAbWvPs+0fC8porriPP+vVYsXG J8uFKtJR36QO1caiqJVUd8uLnl2LPh05NkxIkQDMmtd8LkoAxWscJo7URqhF6NdW/H6+ 2Kpveg4fbBRp4OfI5aP46sAvxGHYbuGq9S3YhiRpQKwrOAp9HC2MlI01NKLay+hWjRrT 5DTWLh6QA2PIqhBUVPPhBnAixKzO+vEaT3S919t8B5UQkUDYuzwBXpjDNLczzTkloa6p dIUtCnM3mS17v7bz6jjMSMBsoc8IIY/3Zc5bYFoP3i7tpusjjDw26mPo7NeC/WAXi0Io NGIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=JjTC2dNYw8thY8dgHEs8Na7R2kvz+iUwlWRQ70i4pU4=; b=D+80uEccHaSyqToGVd9VuxZtRrCoMXH8ZqBFYhdhDA289/C3AetKtgAewXyN9xt0bR AfAi85b81Em/djKQouTTwoF4jAE49p6etkdI1wtDxIZPrxX8fHK4jtKkaR0z0AypXuRf TJdiJfSGxHtGF9Ous5Je7LCeQejKQmQTDXXToZmwtfB4RMjhOBuZ4q+jA+vxlkEtRNrZ SvgEWmNygX0Z5RE359QMDPyJeKrCDD0goTYfnHn9ZD3TGuVtbl8pgtisiMg9+K5Rtsb2 DwaO4TObcT9T/vfsgtSslS/RWv1KqXSs0tDHGeHIeVzYgneagPj/3fmNy0E54QFFbrJg VruQ== X-Gm-Message-State: APjAAAVVuV2515uNJ/amHyUVdYmt5y6amaPHfLcTNY2blmBYenO+XmbG +BqqLTOK0AovngVNp53grYXj3A== X-Google-Smtp-Source: APXvYqwth9D8NvX1qXrMhT/0SQDVr/WY/HyX/A7pgD+b0WXAcc5TF8tktUD2RrBKnk6sPkeF1diSdQ== X-Received: by 2002:a1c:7217:: with SMTP id n23mr254902wmc.47.1561046849508; Thu, 20 Jun 2019 09:07:29 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id 66sm5339576wma.11.2019.06.20.09.07.28 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 20 Jun 2019 09:07:28 -0700 (PDT) Date: Thu, 20 Jun 2019 17:07:27 +0100 From: "Leif Lindholm" To: Laszlo Ersek Cc: devel@edk2.groups.io, "Feng, Bob C" , Liming Gao , Andrew Fish , Michael D Kinney , "Wu, Hao A" Subject: Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Message-ID: <20190620160727.svv3mt6m42ijevmo@bivouac.eciton.net> References: <20190614202121.18952-3-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jun 20, 2019 at 05:29:55PM +0200, Laszlo Ersek wrote: > Hi Leif, > > On 06/14/19 22:21, Leif Lindholm wrote: > > Add Ard and Leif as responsible for any path matching > > F: */Arm/ > > F: */AArch64/ > > > > Signed-off-by: Leif Lindholm > > --- > > Maintainers.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index cd32f9b00170..e415f51468d5 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -82,6 +82,14 @@ EDK II Releases: > > W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > > M: Liming Gao > > > > +EDK II Architectures: > > +--------------------- > > +ARM, AARCH64 > > +F: */AArch64/ > > +F: */Arm/ > > +M: Leif Lindholm > > +M: Ard Biesheuvel > > + > > EDK II Packages: > > ---------------- > > ArmPkg > > > > I'm a bit confused now. > > * In the blurb, you write, > > "Wildcard support is not fully filesystem compliant except in *first* or > last position in the path" > > (emphasis mine). That would invalidate the present patch (because I > gather your intent is to match any pathname that has *any* component > called Aarch64 or Arm). What I actually meant by that was that it matches for files in the top directory (but not directories), as well as at the end. Will reword. > * Upon checking the third patch in the series, the "first position" > exception doesn't seem to be implemented actually. Which should make the > present patch work, in practice. And, we could ignore the statement in > the blurb (given that the blurb is never captured in the git history). > > * However... the explanation from the first patch of the series, namely > > + F: */net/* all files in "any top level directory"/net > > conflicts with the script then! Well, that remains a copy-paste from the QEMU description. I would be tempted to keep current behaviour and simply not support that particular case for now - updating the documentation to describe actual behaviour. > So right now, we have 6 locations: > (a) the blurb Needs rewording (as per above). > (b) the "All patches CC:d here" section from Maintainers.txt * - all files in top-level directory */ - all files in all subdirectories of top-level directory So, yes, I definitely *cheat* with transforming the second one to '.*/.*', but it works :) (but more below on '*') > (c) the "Tianocore Stewards" section from Maintainers.txt The same. > (d) the "F: */net/*" example pattern from Maintainers.txt Cut & paste error in documentation. > (e) the present patch > (f) the script (patch #3) (more) You are correct however - the 'F: *' special case isn't actually working as intended. Currently that returns the expected result because it hits the '' rule. I'll rework that. Regards, Leif > Locations (a) through (d) say that "*" in the first position matches top > level entries only, while (d) and (e) state "*" in the first position > matches any -- possibly multi-component -- pathname prefix. > > It's one thing that we can make the script in patch #3 conform to what > the blurb says. But, that still leaves us with the problem that patches > #1 and #2, considered together, use "*" in the first position in > opposite senses. > > Thanks, > Laszlo