From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Ap2dToSY; spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65]) by groups.io with SMTP; Wed, 26 Jun 2019 02:32:00 -0700 Received: by mail-wr1-f65.google.com with SMTP id p11so1873044wre.7 for ; Wed, 26 Jun 2019 02:31:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=j54oJEm53iCLIlE8oHnH7HoAgMHSb4jV3ZoOIa9duQs=; b=Ap2dToSYT4KZbrhZcxlCSjOiG9oNS25DbaaSqAlJy1/9IBZ8Nrg2IKpU2YverZx6SP Tn7UUlRoWPOdXG43X5YWBiHL/MfoE9foiFVyFykCUc5oC0xpG1f04OPXJYJt8SYrjein 33fgH7ekuflxQAqMyL8wAuFWNT3MSqoBbDXpHeKa5ZKv9aJHN2/s8Ld9GmkLyXEZLQbj 3i2ENP9qGkXqmECbv8ZVJEI2vc6MKhDdKl6av3eXZqBvlI3Fz1QIZJgP1AACqSp+VHWV qmJx8CkG+37gLRESlsNjUuxpITHfd5v/BOI+yoNKcPvHaEqbhbQKv0el8HQl1unL0nHO B4+Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=j54oJEm53iCLIlE8oHnH7HoAgMHSb4jV3ZoOIa9duQs=; b=G/xyA92MyyKIH5td9NAvAoq0CYCoMfdMUK27WLXbHttDZiLfPjXQbxXFj3qQ0KQxcR f2uBPKB+BZ5I0p8ZmxiJVJtaqsrbx34DHTBqUglAiIDUCCCBMgdCsqwhE34nDsMyJnby ZOUJEgST+c4plC936XMQGRoeTkQP9nVU6eUSX9EnAX+LE/SG+xgoLYX+GmelQSTLV3dc qsUafmZA+6v8Q2dHvo+ED52C7ujnMaxquw8cqMDoUM/X3K2205/yAgTah3oOcq4IUWNC NBVeqLZtId3qg/PZnsEHIs2g7S46UeZRNJe/0g67q3JdpYZKEdGa3fNf6jKPqa0mo93p 8HnA== X-Gm-Message-State: APjAAAU3sCsZ8UoCXQT1KrMB8X31KcaWfYr7TbfqW+NNH1ZBQJMaFXgS Wf7qBtLQsCE2wBWWrTpdEUJpqA== X-Google-Smtp-Source: APXvYqy4qTFz6b+JCxEjwlXphX0XtRr8BlJ/z9YCIyynq5IZ3U9jwDWpAVMPRkHTlTaFbM+MQn2jlw== X-Received: by 2002:adf:fb84:: with SMTP id a4mr2993315wrr.41.1561541518270; Wed, 26 Jun 2019 02:31:58 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id t140sm1741241wmt.0.2019.06.26.02.31.57 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 26 Jun 2019 02:31:57 -0700 (PDT) Date: Wed, 26 Jun 2019 10:31:55 +0100 From: "Leif Lindholm" To: Marcin Wojtas Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org, jsd@semihalf.com, jaz@semihalf.com, kostap@marvell.com Subject: Re: [edk2-platforms: PATCH] Marvell/Drivers: XenonDxe: Explicitly disable HS400 Message-ID: <20190626093155.bjetr56imew7q74v@bivouac.eciton.net> References: <1561532654-6277-1-git-send-email-mw@semihalf.com> MIME-Version: 1.0 In-Reply-To: <1561532654-6277-1-git-send-email-mw@semihalf.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jun 26, 2019 at 09:04:14AM +0200, Marcin Wojtas wrote: > Ensure that in case of SlowMode or 3.3V operation, > also the HS400 capability will be disabled in the > SdMmc driver. > > Contributed-under: TianoCore Contribution Agreement 1.1 Well done on keeping this tag. But I'm thinking we need to do that relicensing sooner rather than later, and drop the tag. However, can you clarify what problem this solves? / Leif > Signed-off-by: Marcin Wojtas > --- > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h | 1 + > Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c | 5 +++-- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h > index 8bf1835..2d7c7f0 100644 > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdhci.h > @@ -82,6 +82,7 @@ SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. > #define SDHC_CAP_SDR50 BIT32 > #define SDHC_CAP_SDR104 BIT33 > #define SDHC_CAP_DDR50 BIT34 > +#define SDHC_CAP_HS400 BIT63 > #define SDHC_MAX_CURRENT_CAP 0x0048 > #define SDHC_FORCE_EVT_AUTO_CMD 0x0050 > #define SDHC_FORCE_EVT_ERR_INT 0x0052 > diff --git a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c > index 7a9266e..55ebcf8 100644 > --- a/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c > +++ b/Silicon/Marvell/Drivers/SdMmc/XenonDxe/XenonSdMmcOverride.c > @@ -357,7 +357,8 @@ XenonSdMmcCapability ( > Capability &= ~(UINT64)(SDHC_CAP_VOLTAGE_33 | SDHC_CAP_VOLTAGE_30); > } else { > Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | > - SDHC_CAP_SDR50 | SDHC_CAP_VOLTAGE_18); > + SDHC_CAP_SDR50 | SDHC_CAP_HS400 | > + SDHC_CAP_VOLTAGE_18); > } > > if (!SdMmcDesc.Xenon8BitBusEnabled) { > @@ -365,7 +366,7 @@ XenonSdMmcCapability ( > } > > if (SdMmcDesc.XenonSlowModeEnabled) { > - Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50); > + Capability &= ~(UINT64)(SDHC_CAP_SDR104 | SDHC_CAP_DDR50 | SDHC_CAP_HS400); > } > > Capability &= ~(UINT64)(SDHC_CAP_SLOT_TYPE_MASK); > -- > 2.7.4 >