public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Albecki, Mateusz" <mateusz.albecki@intel.com>
To: devel@edk2.groups.io
Cc: Mateusz Albecki <mateusz.albecki@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>
Subject: [PATCH v4 0/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol
Date: Wed, 26 Jun 2019 15:10:01 +0200	[thread overview]
Message-ID: <20190626131003.3088-1-mateusz.albecki@intel.com> (raw)

To allow platform greater control over the bus settings for SD card and eMMC card we have added a new notify phase to SdMmcOverrideProtocol called GetOperatingParam.
This phase is signaled before SD card/eMMC initialization and allows platform to tweak the values in new structure called EDKII_SD_MMC_OPERATING_PARAMETERS which allows to configure bus width, clock frequency and driver strength.
Other bus parameters can be configured by overriding host controller capabilities.

Changes in v2:
- Fixed stylistic issues and documentation issues pointed out in v1 review
- Changed bus width to be UINT8
- Reordered the SD_MMC_BUS_MODE to fix problem with driver never choosing the DDR50 speed mode
- Fixed the bug with driver not switching the controller into correct driver strength for SD card slots
- Fixed bug with the driver not considering driver strength support for SD card slots
- Fixed bug with driver choosing SdMmcMmcHsSdr if card doesn't support frequencies above 26MHz
- Fixed bug with driver choosing driver strength for legacy speed modes

Changes in v3:
- Changed BusWidth field of EDKII_SD_MMC_OPERATING_PARAMETERS to UINT16

Changes in v4
- Fixed typos and ordering in SD_MMC_BUS_MODE(this time for real)
- Fixed non boolean types usage in if statements
- Fixed code that checks if there was an error in switch response for SD card. The code has been updated to check if switch failed due to function being busy

Tests:
- OS boot from eMMC without SdMmcOverride protocol installed
- OS boot from eMMC with SdMmcOverride installed and clock frequency lowered to 100MHz in HS200
- OS boot from eMMC with driver strength changed to Type1
- OS boot from eMMC in HS400 without override protocol installed
- SD card enumeration in UEFI shell on default speed and high speed(non UHS-I) with SdMmcOverride installed and UHS-I disabled in capability
- SD card enumeration in UEFI shell on default speed and high speed(non UHS-I) with no Override protocol(legacy card used)


Cc: Hao A Wu <hao.a.wu@intel.com>


Albecki, Mateusz (1):
  MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol

Mateusz Albecki (1):
  MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase

 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/EmmcDevice.c    | 512 +++++++++++++++------
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdDevice.c      | 410 ++++++++++++++---
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.c |  52 ++-
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHcDxe.h |  18 +-
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.c   |  34 ++
 MdeModulePkg/Bus/Pci/SdMmcPciHcDxe/SdMmcPciHci.h   |  19 +
 MdeModulePkg/Include/Protocol/SdMmcOverride.h      |  60 ++-
 7 files changed, 867 insertions(+), 238 deletions(-)

-- 
2.14.1.windows.1

--------------------------------------------------------------------

Intel Technology Poland sp. z o.o.
ul. Slowackiego 173 | 80-298 Gdansk | Sad Rejonowy Gdansk Polnoc | VII Wydzial Gospodarczy Krajowego Rejestru Sadowego - KRS 101882 | NIP 957-07-52-316 | Kapital zakladowy 200.000 PLN.

Ta wiadomosc wraz z zalacznikami jest przeznaczona dla okreslonego adresata i moze zawierac informacje poufne. W razie przypadkowego otrzymania tej wiadomosci, prosimy o powiadomienie nadawcy oraz trwale jej usuniecie; jakiekolwiek
przegladanie lub rozpowszechnianie jest zabronione.
This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). If you are not the intended recipient, please contact the sender and delete all copies; any review or distribution by
others is strictly prohibited.


             reply	other threads:[~2019-06-26 13:10 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-26 13:10 Albecki, Mateusz [this message]
2019-06-26 13:10 ` [PATCH v4 1/2] MdeModulePkg/SdMmcOverride: Add GetOperatingParam notify phase Albecki, Mateusz
2019-06-27  2:49   ` [edk2-devel] " Wu, Hao A
2019-06-26 13:10 ` [PATCH v4 2/2] MdeModulePkg/SdMmcHcDxe: Implement revision 3 of SdMmcOverrideProtocol Albecki, Mateusz
2019-06-27  2:49   ` Wu, Hao A
2019-06-27  2:49 ` [PATCH v4 0/2] " Wu, Hao A
2019-06-27  6:25 ` [edk2-devel] " Marcin Wojtas
2019-06-27  6:29   ` Wu, Hao A
2019-06-27  8:10     ` Ard Biesheuvel
2019-06-27 13:38       ` sumit.garg
2019-06-28  0:57         ` Wu, Hao A
2019-06-28  6:32           ` Marcin Wojtas
2019-06-28  6:33             ` Marcin Wojtas
2019-06-28  7:23             ` Wu, Hao A
2019-06-28  7:41               ` Marcin Wojtas
2019-06-28  8:12                 ` Albecki, Mateusz
2019-06-28  8:57                   ` Marcin Wojtas
2019-07-01  1:26                     ` Wu, Hao A
2019-06-28  8:14                 ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190626131003.3088-1-mateusz.albecki@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox