public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Sami Mujawar" <sami.mujawar@arm.com>
To: <devel@edk2.groups.io>
Cc: Sami Mujawar <sami.mujawar@arm.com>, <ard.biesheuvel@linaro.org>,
	<leif.lindholm@linaro.org>, <michael.d.kinney@intel.com>,
	<Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: [PATCH edk2-platforms 1/2] Platform/ARM: Juno: Fix usage of deprecated macros
Date: Thu, 27 Jun 2019 14:12:12 +0100	[thread overview]
Message-ID: <20190627131213.10972-2-sami.mujawar@arm.com> (raw)
In-Reply-To: <20190627131213.10972-1-sami.mujawar@arm.com>

Replaced the use of unsafe/deprecated macros with alternate safe
options.

Signed-off-by: Sami Mujawar <sami.mujawar@arm.com>
---

Notes:
    v1:
    - Replace unsafe/deprecated macros with alternate safe options.   [SAMI]

 Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
index c5967f5b7112fbf794573a6040711a9f1cc14c9f..ea7591d704439cd4216f3e3d7155df2b4d2482b3 100644
--- a/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
+++ b/Platform/ARM/JunoPkg/Drivers/ArmJunoDxe/ArmJunoDxe.c
@@ -1,6 +1,6 @@
 /** @file
 *
-*  Copyright (c) 2013-2017, ARM Limited. All rights reserved.
+*  Copyright (c) 2013-2019, ARM Limited. All rights reserved.
 *
 *  SPDX-License-Identifier: BSD-2-Clause-Patent
 *
@@ -407,7 +407,6 @@ ArmJunoEntryPoint (
   EFI_PHYSICAL_ADDRESS  HypBase;
   CHAR16                *TextDevicePath;
   UINTN                 TextDevicePathSize;
-  VOID                  *Buffer;
   UINT32                JunoRevision;
   EFI_EVENT             EndOfDxeEvent;
 
@@ -495,7 +494,7 @@ ArmJunoEntryPoint (
   //
   if (JunoRevision != JUNO_REVISION_R0) {
     // Enable PCI enumeration
-    PcdSetBool (PcdPciDisableBusEnumeration, FALSE);
+    PcdSetBoolS (PcdPciDisableBusEnumeration, FALSE);
 
     //
     // Create an event belonging to the "gEfiEndOfDxeEventGroupGuid" group.
@@ -531,8 +530,11 @@ ArmJunoEntryPoint (
   TextDevicePath = (CHAR16*)FixedPcdGetPtr (PcdJunoFdtDevicePath);
   if (TextDevicePath != NULL) {
     TextDevicePathSize = StrSize (TextDevicePath);
-    Buffer = PcdSetPtr (PcdFdtDevicePaths, &TextDevicePathSize, TextDevicePath);
-    Status = (Buffer != NULL) ? EFI_SUCCESS : EFI_BUFFER_TOO_SMALL;
+    Status = PcdSetPtrS (
+               PcdFdtDevicePaths,
+               &TextDevicePathSize,
+               TextDevicePath
+               );
   } else {
     Status = EFI_NOT_FOUND;
   }
-- 
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



  reply	other threads:[~2019-06-27 13:12 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-27 13:12 [PATCH edk2-platforms 0/2] Platform/ARM: Disable deprecated APIs for Arm Platforms Sami Mujawar
2019-06-27 13:12 ` Sami Mujawar [this message]
2019-06-27 13:31   ` [edk2-devel] [PATCH edk2-platforms 1/2] Platform/ARM: Juno: Fix usage of deprecated macros Alexei Fedorov
2019-06-27 13:12 ` [PATCH edk2-platforms 2/2] Platform/ARM: Disable deprecated APIs Sami Mujawar
2019-06-27 13:31   ` [edk2-devel] " Alexei Fedorov
2019-06-27 13:32 ` [edk2-devel] [PATCH edk2-platforms 0/2] Platform/ARM: Disable deprecated APIs for Arm Platforms Alexei Fedorov
2019-07-03 15:42 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190627131213.10972-2-sami.mujawar@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox