From: "Krzysztof Koch" <krzysztof.koch@arm.com>
To: <devel@edk2.groups.io>
Cc: <jaben.carsey@intel.com>, <ray.ni@intel.com>,
<zhichao.gao@intel.com>, <Sami.Mujawar@arm.com>,
<Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags
Date: Fri, 28 Jun 2019 09:56:56 +0100 [thread overview]
Message-ID: <20190628085700.17472-2-krzysztof.koch@arm.com> (raw)
In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com>
Acpiview currently allows displaying help info by specifying both
-? and /? flags. This patch removes /? from valid command line
flags that can be passed to the acpiview tool, as this
flag is not used for such purpose in other UEFI shell commands.
Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---
Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/55cb307eac7cfc4cc46df0af8c6edf59863518dc
Notes:
v1:
- Remove '/?' from allowed acpiview input flags [Krzysztof]
ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
index 25d61158320f5d68023f7187a936d50f2bcd20e7..9bbb00cacafa34760c9d45cb6a9fe15bcd4c100e 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c
@@ -1,6 +1,6 @@
/** @file
- Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+ Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
SPDX-License-Identifier: BSD-2-Clause-Patent
**/
@@ -33,7 +33,6 @@ STATIC BOOLEAN mColourHighlighting;
An array of acpiview command line parameters.
**/
STATIC CONST SHELL_PARAM_ITEM ParamList[] = {
- {L"/?", TypeFlag},
{L"-c", TypeFlag},
{L"-d", TypeFlag},
{L"-h", TypeValue},
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
next prev parent reply other threads:[~2019-06-28 8:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 8:56 [PATCH v1 0/5] Clean up acpiview input parameters Krzysztof Koch
2019-06-28 8:56 ` Krzysztof Koch [this message]
2019-06-28 11:06 ` [edk2-devel] [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags Alexei Fedorov
2019-06-28 8:56 ` [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting Krzysztof Koch
2019-06-28 11:06 ` [edk2-devel] " Alexei Fedorov
2019-06-28 8:56 ` [PATCH v1 3/5] ShellPkg: acpiview: Allow disabling consistency checks (-q flag) Krzysztof Koch
2019-06-28 11:06 ` [edk2-devel] " Alexei Fedorov
2019-06-28 8:56 ` [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args Krzysztof Koch
2019-06-28 11:06 ` [edk2-devel] " Alexei Fedorov
2019-06-28 8:57 ` [PATCH v1 5/5] ShellPkg: acpiview: Make '-h' option not require a parameter Krzysztof Koch
2019-06-28 11:05 ` [edk2-devel] " Alexei Fedorov
2019-06-28 11:07 ` [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters Alexei Fedorov
2019-07-01 3:51 ` Gao, Zhichao
2019-07-02 8:44 ` Sami Mujawar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190628085700.17472-2-krzysztof.koch@arm.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox