From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=A6qe4I7m; spf=pass (domain: arm.com, ip: 40.107.4.43, mailfrom: krzysztof.koch@arm.com) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.43]) by groups.io with SMTP; Fri, 28 Jun 2019 01:57:29 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oaqQ1SB8IFAa1ofTI0SNegjqZoR7SWYaUhzp3AQWH9A=; b=A6qe4I7mT+HsqiP89E2Le53NPJSqo8zL9bHSDqt2iE0Jwd3ze8GBZWT2bzeZOeB6YsycG+FxSpMdsEyKa8/jr/w8W+6Nq8w8lfzcCBXnDhZuOJo0iR9Wz6lYN6gFId89eKOt+Dam8PxWj1fH0ZaB1VjP+Hbr12VUgw8fKp09lJA= Received: from VI1PR0802CA0044.eurprd08.prod.outlook.com (2603:10a6:800:a9::30) by AM6PR08MB4311.eurprd08.prod.outlook.com (2603:10a6:20b:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.18; Fri, 28 Jun 2019 08:57:25 +0000 Received: from AM5EUR03FT005.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::206) by VI1PR0802CA0044.outlook.office365.com (2603:10a6:800:a9::30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2008.16 via Frontend Transport; Fri, 28 Jun 2019 08:57:25 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT005.mail.protection.outlook.com (10.152.16.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2032.15 via Frontend Transport; Fri, 28 Jun 2019 08:57:23 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Fri, 28 Jun 2019 08:57:10 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Fri, 28 Jun 2019 08:57:09 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags Date: Fri, 28 Jun 2019 09:56:56 +0100 Message-ID: <20190628085700.17472-2-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com> References: <20190628085700.17472-1-krzysztof.koch@arm.com> Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(136003)(39860400002)(396003)(376002)(346002)(2980300002)(189003)(199004)(77096007)(186003)(53936002)(26005)(305945005)(2351001)(76176011)(4326008)(54906003)(316002)(16586007)(478600001)(8676002)(86362001)(81166006)(81156014)(8936002)(51416003)(7696005)(47776003)(11346002)(486006)(126002)(476003)(446003)(2616005)(336012)(426003)(5660300002)(1076003)(50226002)(63370400001)(63350400001)(36756003)(2906002)(6666004)(356004)(44832011)(6916009)(6306002)(50466002)(48376002)(53416004)(70206006)(70586007)(68736007)(966005)(72206003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB4311;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0e20996d-9736-4283-fe82-08d6fba6a303 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328);SRVR:AM6PR08MB4311; X-MS-TrafficTypeDiagnostic: AM6PR08MB4311: X-MS-Exchange-PUrlCount: 1 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:1013; X-Forefront-PRVS: 00826B6158 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: v7//rLxWGnNsCv5EtcmEhs7w/3a7k5IlkDWWLQONYKBZCKp8evEwr/0ahD0Fia489aII7zZ1hITu+eZEmbws6WSMTAl6/YhwCo9IpNJ3wQ5cExE67dESyB0N7MvevyEynixF9fGiiZ/jfBbAjs0W4Gtpryhp8ERaLWV4aZhJe0+KhZ3Zu/k6GnGap7D3GPLzEsp5CrWCQi1j+K3easxzF1Ejc4KM61XvIase6upZQTd4rt3cq/kfkJmWOBWTHMTwFqfffx5ELnrSfv5ecjpA9W3lTg3JSlxwXuPgH/+CvqwyCojyt4p0NFS/fHXS9FyuooEiqsE4M21faWljnRTH4TLY8oBG3dWIS5HLBBaG8D1YtM+jpgPaJdhpUra4OqYtHoDAIr9GyoA79GJh3DN3P8Lmiz6qK2o8svscigmNU1o= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2019 08:57:23.6263 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 0e20996d-9736-4283-fe82-08d6fba6a303 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4311 Content-Type: text/plain Acpiview currently allows displaying help info by specifying both -? and /? flags. This patch removes /? from valid command line flags that can be passed to the acpiview tool, as this flag is not used for such purpose in other UEFI shell commands. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/55cb307eac7cfc4cc46df0af8c6edf59863518dc Notes: v1: - Remove '/?' from allowed acpiview input flags [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index 25d61158320f5d68023f7187a936d50f2bcd20e7..9bbb00cacafa34760c9d45cb6a9fe15bcd4c100e 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -1,6 +1,6 @@ /** @file - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -33,7 +33,6 @@ STATIC BOOLEAN mColourHighlighting; An array of acpiview command line parameters. **/ STATIC CONST SHELL_PARAM_ITEM ParamList[] = { - {L"/?", TypeFlag}, {L"-c", TypeFlag}, {L"-d", TypeFlag}, {L"-h", TypeValue}, -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'