public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Krzysztof Koch" <krzysztof.koch@arm.com>
To: <devel@edk2.groups.io>
Cc: <jaben.carsey@intel.com>, <ray.ni@intel.com>,
	<zhichao.gao@intel.com>, <Sami.Mujawar@arm.com>,
	<Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting
Date: Fri, 28 Jun 2019 09:56:57 +0100	[thread overview]
Message-ID: <20190628085700.17472-3-krzysztof.koch@arm.com> (raw)
In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com>

Move printing double newline character ('\n\n') from the beginning of
ACPI table checksum validation message to the end of the raw binary
data dump.

This way acpiview table dump looks similar regardless of whether Table
Checksum is validated or not.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/db22c06817971220875e98ec891ed73359f823de

Notes:
    v1:
    - Unify acpiview output with/without checksum reporting [Krzysztof]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
index b5965507b498b9fa9bc4d3124b2285f509004c4f..f9dbbd35449e74fdf81f09e627920b10583a9816 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c
@@ -1,7 +1,7 @@
 /** @file
   ACPI parser
 
-  Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+  Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 **/
 
@@ -139,7 +139,7 @@ VerifyChecksum (
                          ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))
                        );
       }
-      Print (L"\n\nTable Checksum : OK\n\n");
+      Print (L"Table Checksum : OK\n\n");
     } else {
       IncrementErrorCount ();
       if (GetColourHighlighting ()) {
@@ -149,7 +149,7 @@ VerifyChecksum (
                          ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4))
                        );
       }
-      Print (L"\n\nTable Checksum : FAILED (0x%X)\n\n", Checksum);
+      Print (L"Table Checksum : FAILED (0x%X)\n\n", Checksum);
     }
     if (GetColourHighlighting ()) {
       gST->ConOut->SetAttribute (gST->ConOut, OriginalAttribute);
@@ -219,7 +219,7 @@ DumpRaw (
 
   // Print ASCII data for the final line.
   AsciiBuffer[AsciiBufferIndex] = '\0';
-  Print (L"  %a", AsciiBuffer);
+  Print (L"  %a\n\n", AsciiBuffer);
 }
 
 /**
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



  parent reply	other threads:[~2019-06-28  8:57 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  8:56 [PATCH v1 0/5] Clean up acpiview input parameters Krzysztof Koch
2019-06-28  8:56 ` [PATCH v1 1/5] ShellPkg: acpiview: Remove '/?' from valid command line flags Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:56 ` Krzysztof Koch [this message]
2019-06-28 11:06   ` [edk2-devel] [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting Alexei Fedorov
2019-06-28  8:56 ` [PATCH v1 3/5] ShellPkg: acpiview: Allow disabling consistency checks (-q flag) Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:56 ` [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args Krzysztof Koch
2019-06-28 11:06   ` [edk2-devel] " Alexei Fedorov
2019-06-28  8:57 ` [PATCH v1 5/5] ShellPkg: acpiview: Make '-h' option not require a parameter Krzysztof Koch
2019-06-28 11:05   ` [edk2-devel] " Alexei Fedorov
2019-06-28 11:07 ` [edk2-devel] [PATCH v1 0/5] Clean up acpiview input parameters Alexei Fedorov
2019-07-01  3:51 ` Gao, Zhichao
2019-07-02  8:44 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628085700.17472-3-krzysztof.koch@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox