From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=qJ4YwAKG; spf=pass (domain: arm.com, ip: 40.107.8.53, mailfrom: krzysztof.koch@arm.com) Received: from EUR04-VI1-obe.outbound.protection.outlook.com (EUR04-VI1-obe.outbound.protection.outlook.com [40.107.8.53]) by groups.io with SMTP; Fri, 28 Jun 2019 01:57:35 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=lOa4UQaJsNjdLTKsnug+ZsbHevmr9i4AqnVYZMoE6IzxLTSjXA/NNSRqpDdXw7BD8lMK97tt142LMVXQRUcxNUGABgUQ1swA43LaOe515ngczLF8MiFfAa6qQ0jMpCC7jhhB0VdqPCLzEJabZ9o2I/IV5yaaOgAgTAMbanca7n8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ArxMmkQqAIln5ipPTe7gklvew10YwoVJDHYR+/yOg7U=; b=BSojbU9ecHnjvKZR+5/9N8nbVtTqITGtk6CHSy/PEPFIZ8CYBU07YY+A8IZxZR1gc+3zBbLgQQIEOZQIGliLOADQ4wAqrISKrnBgTJncNMjuN0hUgWIgkS5EMhVYfXM8mxZyGuAXIFNwsGV8lpktNPPLS2ZWGAIRiHUGtrI15F0= ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=temperror (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com;dmarc=temperror action=none header.from=arm.com;dkim=none (message not signed);arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ArxMmkQqAIln5ipPTe7gklvew10YwoVJDHYR+/yOg7U=; b=qJ4YwAKGIxlSQS7zRLKkY6HHSJ+/pCKTAkd8H0mJDNBWbgZpS74Ur3NEqKk/WpsAFpqmM5FhpPjmLiv9JyVsChN8O7LGw/bOtwpj8oigW9fR3BnUO8I1nR/50Tyqc5tYJlO9akNpn1wTYZL2BiluMpOfyxVKttoRaKey8qZPWq8= Received: from VI1PR0802CA0004.eurprd08.prod.outlook.com (2603:10a6:800:aa::14) by AM0PR08MB4306.eurprd08.prod.outlook.com (2603:10a6:208:139::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 28 Jun 2019 08:57:30 +0000 Received: from AM5EUR03FT033.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::201) by VI1PR0802CA0004.outlook.office365.com (2603:10a6:800:aa::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2032.17 via Frontend Transport; Fri, 28 Jun 2019 08:57:30 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT033.mail.protection.outlook.com (10.152.16.99) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2032.15 via Frontend Transport; Fri, 28 Jun 2019 08:57:29 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Fri, 28 Jun 2019 08:57:10 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Fri, 28 Jun 2019 08:57:10 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 2/5] ShellPkg: acpiview: Fix '\n\n' printing in Table Checksum reporting Date: Fri, 28 Jun 2019 09:56:57 +0100 Message-ID: <20190628085700.17472-3-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com> References: <20190628085700.17472-1-krzysztof.koch@arm.com> Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(136003)(376002)(346002)(39860400002)(396003)(2980300002)(189003)(199004)(86362001)(2351001)(76176011)(6666004)(4326008)(2906002)(72206003)(305945005)(51416003)(7696005)(50226002)(26005)(77096007)(47776003)(6306002)(68736007)(186003)(6916009)(966005)(53936002)(478600001)(8936002)(426003)(486006)(44832011)(81156014)(316002)(63370400001)(53416004)(2616005)(11346002)(36756003)(476003)(63350400001)(5660300002)(336012)(1076003)(356004)(54906003)(70586007)(81166006)(8676002)(50466002)(48376002)(446003)(126002)(16586007)(14444005)(70206006);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB4306;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;MX:1;A:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 5531170c-2964-459b-75ff-08d6fba6a647 X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328);SRVR:AM0PR08MB4306; X-MS-TrafficTypeDiagnostic: AM0PR08MB4306: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: NoDisclaimer: True X-MS-Oob-TLC-OOBClassifiers: OLM:1388; X-Forefront-PRVS: 00826B6158 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: 7yNYvUdVawlHyNzFYUAB95Xqg6ACLpb3taquvKl7bRwGsJ6TDatO3zjo9ANpEfyWRxdZZA5ns636Ghe+6/KIXQuRPzuX+SAbiJeVxDxOXIXvanG/Y0mGdmEnf6YNAOSIzsJNQ0eOBwJETxv361IMzwA4zZRbnwy8csu6gTL6ls7kboegLi4vU/HrQlFRUnp9uovunXj7tendEGiVfdhrnH28D9MYHizTCnvMmUpU3oGTys5ldXFCN0B7nGqs/l8pV6hpg1fIsxUe9xq3YrMx6F/kb7+WKlMjQP5j8TVQXMGlFa9awh4TzSby6EH9guID3I1Mb9njO0YGqwuE2obhAI/WZPx3c6F9lEJtUd66X5B0YULPyc3EXwHRTKaJKTKD23F8YRowaEhJ6P+UZEES5fHPYw1chEKiuOdX2cm2nFg= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2019 08:57:29.1036 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 5531170c-2964-459b-75ff-08d6fba6a647 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4306 Content-Type: text/plain Move printing double newline character ('\n\n') from the beginning of ACPI table checksum validation message to the end of the raw binary data dump. This way acpiview table dump looks similar regardless of whether Table Checksum is validated or not. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/db22c06817971220875e98ec891ed73359f823de Notes: v1: - Unify acpiview output with/without checksum reporting [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c index b5965507b498b9fa9bc4d3124b2285f509004c4f..f9dbbd35449e74fdf81f09e627920b10583a9816 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiParser.c @@ -1,7 +1,7 @@ /** @file ACPI parser - Copyright (c) 2016 - 2018, ARM Limited. All rights reserved. + Copyright (c) 2016 - 2019, ARM Limited. All rights reserved. SPDX-License-Identifier: BSD-2-Clause-Patent **/ @@ -139,7 +139,7 @@ VerifyChecksum ( ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)) ); } - Print (L"\n\nTable Checksum : OK\n\n"); + Print (L"Table Checksum : OK\n\n"); } else { IncrementErrorCount (); if (GetColourHighlighting ()) { @@ -149,7 +149,7 @@ VerifyChecksum ( ((OriginalAttribute&(BIT4|BIT5|BIT6))>>4)) ); } - Print (L"\n\nTable Checksum : FAILED (0x%X)\n\n", Checksum); + Print (L"Table Checksum : FAILED (0x%X)\n\n", Checksum); } if (GetColourHighlighting ()) { gST->ConOut->SetAttribute (gST->ConOut, OriginalAttribute); @@ -219,7 +219,7 @@ DumpRaw ( // Print ASCII data for the final line. AsciiBuffer[AsciiBufferIndex] = '\0'; - Print (L" %a", AsciiBuffer); + Print (L" %a\n\n", AsciiBuffer); } /** -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'