From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=Zr52xtuk; spf=pass (domain: arm.com, ip: 40.107.2.40, mailfrom: krzysztof.koch@arm.com) Received: from EUR02-VE1-obe.outbound.protection.outlook.com (EUR02-VE1-obe.outbound.protection.outlook.com [40.107.2.40]) by groups.io with SMTP; Fri, 28 Jun 2019 01:59:10 -0700 ARC-Seal: i=1; a=rsa-sha256; s=testarcselector01; d=microsoft.com; cv=none; b=FhlYUoaZ9w6vgiYpBQ9/H5ysDkdrAHkYmuhGXCcLrMi3QkF4dGKTsdYPcJXs8hHgw1qebKqXoAXdzqcn7AWDiRfflfg7Pijp4VaPoSFOvcQ8oJyEPSuOTLKvqdQBaH0VMVezMgd5E2pnJLHcUcu0n8Goqh/jdoNfFRh2PIVvlt0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=testarcselector01; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2SwBxMmW1eV9eQ7uVvbNJyvj+mSXMs4W/0TP0TNnc5s=; b=sKcshPXYnOsSu1ti3tWzkvFTUv+EK1lncKUGJkDBZnzsbIsaJAInsuoOaklgqJar2KRI2eeZttWClXyfue17k4i4eFX3q8bfALJW7YVKvlK4RvlW/2wjUQX5gLOzoNPoYIQYFNLMClPaAEnsjZ/Iecx+pTriFthxLma14wpcVsY= ARC-Authentication-Results: i=1; mx.microsoft.com 1;spf=temperror (sender ip is 40.67.248.234) smtp.rcpttodomain=edk2.groups.io smtp.mailfrom=arm.com;dmarc=temperror action=none header.from=arm.com;dkim=none (message not signed);arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=2SwBxMmW1eV9eQ7uVvbNJyvj+mSXMs4W/0TP0TNnc5s=; b=Zr52xtukDQEOfOhBxNWUjrlv7+yR9IyKf98RaNmfCKogGWNcMBRnlqaGq+26fnczv0VhjQXZOTYnTxefK8QBT9WJUqpE64BwbuInWRAT8SoXaGUQVezK7bQ+adMLsQMU1UACioEKQ4dnenELthGi/yXhcLk0I85C+tJjOQW4Eo0= Received: from DB6PR0801CA0063.eurprd08.prod.outlook.com (2603:10a6:4:2b::31) by AM0PR08MB4307.eurprd08.prod.outlook.com (2603:10a6:208:13d::18) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2008.16; Fri, 28 Jun 2019 08:59:06 +0000 Received: from VE1EUR03FT048.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e09::208) by DB6PR0801CA0063.outlook.office365.com (2603:10a6:4:2b::31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2032.18 via Frontend Transport; Fri, 28 Jun 2019 08:59:06 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by VE1EUR03FT048.mail.protection.outlook.com (10.152.19.8) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2032.15 via Frontend Transport; Fri, 28 Jun 2019 08:59:04 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX04.Arm.com (10.251.24.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1415.2; Fri, 28 Jun 2019 08:57:12 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Fri, 28 Jun 2019 08:57:11 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 4/5] ShellPkg: acpiview: Remove '-v' flag from allowed command line args Date: Fri, 28 Jun 2019 09:56:59 +0100 Message-ID: <20190628085700.17472-5-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20190628085700.17472-1-krzysztof.koch@arm.com> References: <20190628085700.17472-1-krzysztof.koch@arm.com> Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(39860400002)(376002)(136003)(396003)(346002)(2980300002)(199004)(189003)(486006)(63350400001)(54906003)(11346002)(50226002)(70586007)(8936002)(63370400001)(126002)(70206006)(446003)(476003)(50466002)(48376002)(356004)(86362001)(1076003)(186003)(77096007)(426003)(44832011)(6916009)(6666004)(26005)(2351001)(5660300002)(8676002)(51416003)(2616005)(305945005)(81166006)(16586007)(336012)(68736007)(53936002)(478600001)(76176011)(7696005)(53416004)(47776003)(72206003)(36756003)(4326008)(316002)(966005)(81156014)(2906002)(6306002);DIR:OUT;SFP:1101;SCL:1;SRVR:AM0PR08MB4307;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 2a1c7bf0-1582-42e6-40c1-08d6fba6defd X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328);SRVR:AM0PR08MB4307; X-MS-TrafficTypeDiagnostic: AM0PR08MB4307: X-MS-Exchange-PUrlCount: 1 X-Microsoft-Antispam-PRVS: NoDisclaimer: True X-MS-Oob-TLC-OOBClassifiers: OLM:37; X-Forefront-PRVS: 00826B6158 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: kOMglkI5a9gxWEbu8Z5YWuhK8ILDrxSlfKkhQ5Ki/CEg2Cfmt0QblJtu1fKy8pp75OSihbYoaYRF1lvw+5cieX6r/vgnjSGGhpe0nB5/ODFOho4mHHG5K/pxMq0iBmYhyqqlnuPi6zeZJ2XDKj/372B8RVoNijMyl14RiPgYKtp6UGczuZxeMCP5ni2jM7vdWkjCKTzTl3HPs+agU2F4Y2fGE/bNVqGPFRljPudfXJo0LVaZbA18+WEik5Zk+qX4xoTh3LpH6ypPFK1/TnjAF9kxnIEcuRFHxIpx+4e0NCg1Bs8KaW09OLbzZlBEwr1HuqnHl+6j0XH/fKBKJtZqqviedtUbYVt89Xeq8u8LDF73h/PNSoXqmUtc6PzLsuYQxZuFxtMS3Fc8P7rnTf1yB6sUtjZ81WmEVVwu/OhN3hc= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2019 08:59:04.2234 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 2a1c7bf0-1582-42e6-40c1-08d6fba6defd X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM0PR08MB4307 Content-Type: text/plain According to the acpiview documentation, the -v flag enables verbose output and it is set on default. Moreover, the acpiview UEFI shell tool dumps the same output with and without this flag set. Therefore this patch removes the superfluous -v flag from allowed command line parameters. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/6400c6323f78ac89e790e57c07e9cca2e979ef05 Notes: v1: - Remove the unused '-v' flag [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c | 3 --- ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni | 3 +-- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c index e99537acf36616783103e1e9d154278f8dedb78e..911b2da3dd9f19010d0f4993bcf017749cafb749 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/AcpiView.c @@ -25,7 +25,6 @@ STATIC BOOLEAN mSelectedAcpiTableFound; STATIC EREPORT_OPTION mReportType; STATIC UINT32 mTableCount; STATIC UINT32 mBinTableCount; -STATIC BOOLEAN mVerbose; STATIC BOOLEAN mConsistencyCheck; STATIC BOOLEAN mColourHighlighting; @@ -38,7 +37,6 @@ STATIC CONST SHELL_PARAM_ITEM ParamList[] = { {L"-h", TypeValue}, {L"-l", TypeFlag}, {L"-s", TypeValue}, - {L"-v", TypeFlag}, {NULL, TypeMax} }; @@ -472,7 +470,6 @@ ShellCommandRunAcpiView ( mSelectedAcpiTable = 0; mSelectedAcpiTableName = NULL; mSelectedAcpiTableFound = FALSE; - mVerbose = TRUE; mConsistencyCheck = TRUE; ShellStatus = SHELL_SUCCESS; diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni index f0610870505d5c5d89e6516122fc9e782479df0c..0d10b5debe470cb096cf414d0a0144fd3bde03ee 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/UefiShellAcpiViewCommandLib.uni @@ -30,7 +30,7 @@ "Display ACPI Table information.\r\n" ".SH SYNOPSIS\r\n" " \r\n" -"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-v] [-h Highlight]]\r\n" +"ACPIVIEW [[-?] | [[-l] | [-s AcpiTable [-d]]] [-q] [-h Highlight]]\r\n" " \r\n" ".SH OPTIONS\r\n" " \r\n" @@ -40,7 +40,6 @@ " AcpiTable : The required ACPI Table type.\r\n" " -d - Generate a binary file dump of the specified AcpiTable.\r\n" " -q - Quiet. Suppress errors and warnings. Disables consistency checks.\r\n" -" -v - Display verbose data (enabled by default).\r\n" " -h - Enable/Disable Colour Highlighting.\r\n" " Highlight : TRUE/ON enables highlighting;\r\n" " FALSE/OFF (default) disables highlighting.\r\n" -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'