public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Krzysztof Koch" <krzysztof.koch@arm.com>
To: <devel@edk2.groups.io>
Cc: <jaben.carsey@intel.com>, <ray.ni@intel.com>,
	<zhichao.gao@intel.com>, <Sami.Mujawar@arm.com>,
	<Matteo.Carlini@arm.com>, <nd@arm.com>
Subject: [PATCH v1 2/4] ShellPkg: acpiview: Make DBG2 output consistent with other tables
Date: Fri, 28 Jun 2019 11:24:36 +0100	[thread overview]
Message-ID: <20190628102438.30544-3-krzysztof.koch@arm.com> (raw)
In-Reply-To: <20190628102438.30544-1-krzysztof.koch@arm.com>

Print an extra newline character at the end DBG2 table parsing in order
to make the output resemble the one for other ACPI table parsers.

With this change, there is now a blank line between the DBG2 table dump
and the 'Table Statistics' section.

Signed-off-by: Krzysztof Koch <krzysztof.koch@arm.com>
---

Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/397c37eb5a73ee0f3bbd363075f97b19c0edaf2e

Notes:
    v1:
    - Print one more newline character after DBG2 table dump [Krzysztof]

 ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c
index 310d3f18ec24532289c8f6a58cbd117fed0ca071..8de5ebf74775bab8e765849cba6ef4eb6f659a5a 100644
--- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c
+++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Dbg2/Dbg2Parser.c
@@ -1,7 +1,7 @@
 /** @file
   DBG2 table parser
 
-  Copyright (c) 2016 - 2018, ARM Limited. All rights reserved.
+  Copyright (c) 2016 - 2019, ARM Limited. All rights reserved.
   SPDX-License-Identifier: BSD-2-Clause-Patent
 
   @par Reference(s):
@@ -190,6 +190,7 @@ DumpDbgDeviceInfo (
       Print (L"\n%-*s   ", OUTPUT_FIELD_COLUMN_WIDTH, L"");
     }
   }
+  Print (L"\n");
 
   *Length = *DbgDevInfoLen;
 }
--
'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'



  parent reply	other threads:[~2019-06-28 10:24 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28 10:24 [PATCH v1 0/4] Fix a number of small issues in acpiview Krzysztof Koch
2019-06-28 10:24 ` [PATCH v1 1/4] ShellPkg: acpiview: Improve PPTT table field validation Krzysztof Koch
2019-06-28 11:00   ` [edk2-devel] " Alexei Fedorov
2019-07-01  3:49   ` Gao, Zhichao
2019-07-01  7:28     ` [edk2-devel] " Krzysztof Koch
2019-07-02  5:56       ` Gao, Zhichao
2019-06-28 10:24 ` Krzysztof Koch [this message]
2019-06-28 10:59   ` [edk2-devel] [PATCH v1 2/4] ShellPkg: acpiview: Make DBG2 output consistent with other tables Alexei Fedorov
2019-06-28 11:02   ` Alexei Fedorov
2019-06-28 10:24 ` [PATCH v1 3/4] ShellPkg: acpiview: Remove redundant IORT node types enum Krzysztof Koch
2019-06-28 10:59   ` [edk2-devel] " Alexei Fedorov
2019-06-28 11:02     ` Alexei Fedorov
2019-06-28 10:24 ` [PATCH v1 4/4] ShellPkg: acpiview: Remove duplicate indentation in IORT parser Krzysztof Koch
2019-06-28 10:58   ` [edk2-devel] " Alexei Fedorov
2019-06-28 11:01     ` Alexei Fedorov
2019-06-28 11:03 ` [edk2-devel] [PATCH v1 0/4] Fix a number of small issues in acpiview Alexei Fedorov
2019-07-02  8:44 ` Sami Mujawar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190628102438.30544-3-krzysztof.koch@arm.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox