From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=vLTvAEfc; spf=pass (domain: arm.com, ip: 40.107.4.44, mailfrom: krzysztof.koch@arm.com) Received: from EUR03-DB5-obe.outbound.protection.outlook.com (EUR03-DB5-obe.outbound.protection.outlook.com [40.107.4.44]) by groups.io with SMTP; Fri, 28 Jun 2019 03:25:46 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=oPuwq4IYAmoNEFN6slh11xCInjKtkN3+GJHnnI9jqU8=; b=vLTvAEfcyXmAw0Xn5FT4BbybUkZgaFEn8aHOfvebIcAfga1AOXZsyHdvr7FchmI5l2qLWcjvC9A8iXC/By4ow330fFcCVFXuLdwtNG9CFO+JBZsGCYRfQN5oWi9Syc9Nak786zMFp1gSBABOuII7QR0Hwi0C0MPKw6XXMg9fMJ4= Received: from VI1PR0802CA0041.eurprd08.prod.outlook.com (2603:10a6:800:a9::27) by AM6PR08MB4311.eurprd08.prod.outlook.com (2603:10a6:20b:b8::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.18; Fri, 28 Jun 2019 10:25:42 +0000 Received: from AM5EUR03FT009.eop-EUR03.prod.protection.outlook.com (2a01:111:f400:7e08::207) by VI1PR0802CA0041.outlook.office365.com (2603:10a6:800:a9::27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384) id 15.20.2032.17 via Frontend Transport; Fri, 28 Jun 2019 10:25:41 +0000 Authentication-Results: spf=temperror (sender IP is 40.67.248.234) smtp.mailfrom=arm.com; edk2.groups.io; dkim=none (message not signed) header.d=none;edk2.groups.io; dmarc=temperror action=none header.from=arm.com; Received-SPF: TempError (protection.outlook.com: error in processing during lookup of arm.com: DNS Timeout) Received: from nebula.arm.com (40.67.248.234) by AM5EUR03FT009.mail.protection.outlook.com (10.152.16.110) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.20.2032.15 via Frontend Transport; Fri, 28 Jun 2019 10:25:40 +0000 Received: from AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) by AZ-NEU-EX03.Arm.com (10.251.24.31) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256) id 15.1.1415.2; Fri, 28 Jun 2019 10:24:48 +0000 Received: from AZ-NEU-EX04.Arm.com (10.251.24.32) by AZ-NEU-EX01.Emea.Arm.com (10.251.26.4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1415.2; Fri, 28 Jun 2019 10:24:47 +0000 Received: from E119924.Arm.com (10.1.199.124) by mail.arm.com (10.251.24.32) with Microsoft SMTP Server id 15.1.1415.2 via Frontend Transport; Fri, 28 Jun 2019 10:24:47 +0000 From: "Krzysztof Koch" To: CC: , , , , , Subject: [PATCH v1 4/4] ShellPkg: acpiview: Remove duplicate indentation in IORT parser Date: Fri, 28 Jun 2019 11:24:38 +0100 Message-ID: <20190628102438.30544-5-krzysztof.koch@arm.com> X-Mailer: git-send-email 2.16.2.windows.1 In-Reply-To: <20190628102438.30544-1-krzysztof.koch@arm.com> References: <20190628102438.30544-1-krzysztof.koch@arm.com> Return-Path: Krzysztof.Koch@arm.com MIME-Version: 1.0 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:40.67.248.234;IPV:NLI;CTRY:IE;EFV:NLI;SFV:NSPM;SFS:(10009020)(4636009)(346002)(396003)(39860400002)(136003)(376002)(2980300002)(199004)(189003)(2906002)(36756003)(44832011)(356004)(6666004)(426003)(336012)(5660300002)(446003)(476003)(126002)(486006)(11346002)(2616005)(63350400001)(50226002)(1076003)(63370400001)(53416004)(48376002)(50466002)(68736007)(72206003)(966005)(70586007)(70206006)(6916009)(6306002)(26005)(2351001)(305945005)(186003)(77096007)(53936002)(81156014)(81166006)(8936002)(47776003)(51416003)(7696005)(16586007)(316002)(8676002)(478600001)(76176011)(54906003)(4326008)(86362001);DIR:OUT;SFP:1101;SCL:1;SRVR:AM6PR08MB4311;H:nebula.arm.com;FPR:;SPF:TempError;LANG:en;PTR:InfoDomainNonexistent;A:1;MX:1; X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 604de79f-80d7-4df7-feb7-08d6fbb2f83a X-Microsoft-Antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328);SRVR:AM6PR08MB4311; X-MS-TrafficTypeDiagnostic: AM6PR08MB4311: X-MS-Exchange-PUrlCount: 1 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:962; X-Forefront-PRVS: 00826B6158 X-MS-Exchange-SenderADCheck: 1 X-Microsoft-Antispam-Message-Info: mUTQwUj/IhwuLtVsAnzmValfMLASAAICkQaUDlKcATAkqz/cMvEZcgfOxixllorS36BdwkGahwcvWViGFr9s+OlN/aA8lFs/y3bcU/UMJLkwxa2+ZCS2PZ1eVdab6ECTzM9FtgqzIhMpGRMPq1xleTrf1naOnNotq+U9ulZ7Vr7GN4QoUBH/Wd6727jk4RHWEdUrpbM0QO/m8302pROmuP/ArvKxLlO01daJVKldvaqMXg/hGAGD6R7ef2Oz0hQiSNYxRb8NIwcGtOOsCX684fb/fYdpuxga2u3skIUYFRj3LdRG5VV+gLV4C0PWi8zg+E0+bB4q10LhO+gpqNi7/lArVT7T/qFQGN8e9UkCOPeSHO1SldjLYJEgyoA2Tys0P523GTiDDZT2PMEY7I7qgjeDNEFZiI7REvi9otJVWcE= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 28 Jun 2019 10:25:40.5579 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 604de79f-80d7-4df7-feb7-08d6fbb2f83a X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[40.67.248.234];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM6PR08MB4311 Content-Type: text/plain Remove redundant whitespace characters at the beginning of the strings describing IORT table field names. When dumping ACPI table contents, the indentation level for printing field names is controled using the 'Indent' argument to the 'ParseAcpi' function. In the IORT acpiview parser, both 'Indent' and extra whitespace characters are used for indentation, which results in excess indentation. Signed-off-by: Krzysztof Koch --- Changes can be seen at: https://github.com/KrzysztofKoch1/edk2/commit/b44e007195f32246f33000934a6178d36f79e4b1 Notes: v1: - fix indentation issues in the IORT table parser [Krzysztof] ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c | 18 +++++++++--------- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c index a91a4f9db13a52285bf56abe33f359a771fc04bd..93f78e1a9786ed53f6b5529f478b72a220b4f8df 100644 --- a/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c +++ b/ShellPkg/Library/UefiShellAcpiViewCommandLib/Parsers/Iort/IortParser.c @@ -131,19 +131,19 @@ STATIC CONST ACPI_PARSER IortNodeSmmuV1V2Parser[] = { An ACPI_PARSER array describing the SMMUv1/2 Node Interrupt Array. **/ STATIC CONST ACPI_PARSER InterruptArrayParser[] = { - {L" Interrupt GSIV", 4, 0, L"0x%x", NULL, NULL, NULL, NULL}, - {L" Flags", 4, 4, L"0x%x", NULL, NULL, NULL, NULL} + {L"Interrupt GSIV", 4, 0, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Flags", 4, 4, L"0x%x", NULL, NULL, NULL, NULL} }; /** An ACPI_PARSER array describing the IORT ID Mapping. **/ STATIC CONST ACPI_PARSER IortNodeIdMappingParser[] = { - {L" Input base", 4, 0, L"0x%x", NULL, NULL, NULL, NULL}, - {L" Number of IDs", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, - {L" Output base", 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, - {L" Output reference", 4, 12, L"0x%x", NULL, NULL, NULL, NULL}, - {L" Flags", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} + {L"Input base", 4, 0, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Number of IDs", 4, 4, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Output base", 4, 8, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Output reference", 4, 12, L"0x%x", NULL, NULL, NULL, NULL}, + {L"Flags", 4, 16, L"0x%x", NULL, NULL, NULL, NULL} }; /** @@ -170,14 +170,14 @@ STATIC CONST ACPI_PARSER IortNodeItsParser[] = { ValidateItsIdMappingCount, ValidateItsIdArrayReference ), - {L" Number of ITSs", 4, 16, L"%d", NULL, (VOID**)&ItsCount, NULL} + {L"Number of ITSs", 4, 16, L"%d", NULL, (VOID**)&ItsCount, NULL} }; /** An ACPI_PARSER array describing the ITS ID. **/ STATIC CONST ACPI_PARSER ItsIdParser[] = { - { L" GIC ITS Identifier", 4, 0, L"%d", NULL, NULL, NULL } + { L"GIC ITS Identifier", 4, 0, L"%d", NULL, NULL, NULL } }; /** -- 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'