From: "Anthony PERARD" <anthony.perard@citrix.com>
To: Laszlo Ersek <lersek@redhat.com>
Cc: <devel@edk2.groups.io>, Jordan Justen <jordan.l.justen@intel.com>,
"Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by childs
Date: Mon, 1 Jul 2019 11:48:01 +0100 [thread overview]
Message-ID: <20190701104801.GH13449@perard.uk.xensource.com> (raw)
In-Reply-To: <c84d82f9-f551-f6ea-0342-01dc526b23a6@redhat.com>
On Sun, Jun 30, 2019 at 12:56:57PM +0200, Laszlo Ersek wrote:
> (5) Side remark (no need to do anything about it in the scope of this
> patch): I think the DisconnectController() call in
> XenBusDxeDriverBindingStop() is superfluous. That kind of disconnection
> is not the job of EFI_DRIVER_BINDING_PROTOCOL.Stop().
That sounds good and works fine without the call, I'll send a separate
patch.
--
Anthony PERARD
prev parent reply other threads:[~2019-07-01 10:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-28 16:16 [PATCH] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by childs Anthony PERARD
2019-06-30 10:56 ` Laszlo Ersek
2019-07-01 10:48 ` Anthony PERARD [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190701104801.GH13449@perard.uk.xensource.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox