From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.145.155, mailfrom: anthony.perard@citrix.com)
Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155])
 by groups.io with SMTP; Mon, 01 Jul 2019 03:48:09 -0700
Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com
Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  anthony.perard@citrix.com) identity=pra;
  client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible
Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of
  anthony.perard@citrix.com designates 162.221.158.21 as
  permitted sender) identity=mailfrom;
  client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="anthony.perard@citrix.com";
  x-conformance=sidf_compatible; x-record-type="v=spf1";
  x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133
  ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4
  ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88
  ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all"
Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender
  authenticity information available from domain of
  postmaster@mail.citrix.com) identity=helo;
  client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com;
  envelope-from="anthony.perard@citrix.com";
  x-sender="postmaster@mail.citrix.com";
  x-conformance=sidf_compatible
IronPort-SDR: j66Py+1oyTt8uuGlqJ8Z9EnnsZqdDoCBCA7ySNlHQBXKrn6Q3MSjyLD3dQcyRv1xXObb8U0zPE
 jZd3JowSnAi0JFjt9t/R9zU2zzU47BSeboN3Meb8HONKEjcogG5LEXnWOxsgD30Ne8K66MKHrP
 tJ35xcCiZQKZmDE0g7c/loneDGAFMCHKYsw2Hp2Er+wnkNYZCp+i/6rURbcQGk13Weu8xKcJ2/
 wVBUtTIGZlnacLBD2TVeeE5G3QaOxV+BzmwPYsB7+4liaJAdguMjvIGRDgiRtgizK5OkNO7a94
 lsA=
X-SBRS: 2.7
X-MesageID: 2441574
X-Ironport-Server: esa3.hc3370-68.iphmx.com
X-Remote-IP: 162.221.158.21
X-Policy: $RELAYED
X-IronPort-AV: E=Sophos;i="5.63,439,1557201600"; 
   d="scan'208";a="2441574"
Date: Mon, 1 Jul 2019 11:48:01 +0100
From: "Anthony PERARD" <anthony.perard@citrix.com>
To: Laszlo Ersek <lersek@redhat.com>
CC: <devel@edk2.groups.io>, Jordan Justen <jordan.l.justen@intel.com>, "Ard
 Biesheuvel" <ard.biesheuvel@linaro.org>, Julien Grall <julien.grall@arm.com>
Subject: Re: [PATCH] OvmfPkg/XenBusDxe: Close XenIoProtocol openned by childs
Message-ID: <20190701104801.GH13449@perard.uk.xensource.com>
References: <20190628161606.13141-1-anthony.perard@citrix.com>
 <c84d82f9-f551-f6ea-0342-01dc526b23a6@redhat.com>
MIME-Version: 1.0
In-Reply-To: <c84d82f9-f551-f6ea-0342-01dc526b23a6@redhat.com>
User-Agent: Mutt/1.12.1 (2019-06-15)
Return-Path: anthony.perard@citrix.com
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline

On Sun, Jun 30, 2019 at 12:56:57PM +0200, Laszlo Ersek wrote:
> (5) Side remark (no need to do anything about it in the scope of this
> patch): I think the DisconnectController() call in
> XenBusDxeDriverBindingStop() is superfluous. That kind of disconnection
> is not the job of EFI_DRIVER_BINDING_PROTOCOL.Stop().

That sounds good and works fine without the call, I'll send a separate
patch.

-- 
Anthony PERARD