From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.155.175, mailfrom: anthony.perard@citrix.com) Received: from esa6.hc3370-68.iphmx.com (esa6.hc3370-68.iphmx.com [216.71.155.175]) by groups.io with SMTP; Mon, 01 Jul 2019 04:14:46 -0700 Authentication-Results: esa6.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa6.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa6.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa6.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: oseTF2XiLF7OJQ3ElmtrMjCOloLto1A9OilOveWiHy0JSiKHMScmitw3br7mBb4XWJu69IyrLN u2z3bW9yjQMpp1cS6vWHzuXoSwdxRV6CoRfM6AxssrbNcQJBS/rugGhZQrACUtpzTr5a2pbGgo NHXBbxrza6p1l9M420olYE6lf93uLJqhEiVuGVVYUxfZ+FTyKc21ESLv1f/NgKYxiBvjMXo/N8 B3pxOHGkPJ9f3KOLVEuAFuKKh6H9OIakyZOtlN3JPqYNO9FOYWCyqTy0DynzmNJlCwq6P055Rl /cA= X-SBRS: 2.7 X-MesageID: 2457178 X-Ironport-Server: esa6.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,439,1557201600"; d="scan'208";a="2457178" From: "Anthony PERARD" To: CC: Jordan Justen , Laszlo Ersek , Ard Biesheuvel , Julien Grall , Anthony PERARD Subject: [PATCH] OvmfPkg/XenBusDxe: Don't call DisconnectController in Stop() Date: Mon, 1 Jul 2019 12:14:03 +0100 Message-ID: <20190701111403.7007-1-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 MIME-Version: 1.0 Return-Path: anthony.perard@citrix.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Calling DisconnectController() on children isn't part of the job of EFI_DRIVER_BINDING_PROTOCOL.Stop() as it only needs to deallocate resources allocated in Start(). The disconnection will happen when both DevicePath and XenBus protocols gets uninstalled. Reported-by: Laszlo Ersek Signed-off-by: Anthony PERARD --- Notes: Please apply this patch after: "OvmfPkg/XenBusDxe: Close XenIoProtocol openned by children" OvmfPkg/XenBusDxe/XenBusDxe.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/OvmfPkg/XenBusDxe/XenBusDxe.c b/OvmfPkg/XenBusDxe/XenBusDxe.c index 7c07a96650..634c7b71eb 100644 --- a/OvmfPkg/XenBusDxe/XenBusDxe.c +++ b/OvmfPkg/XenBusDxe/XenBusDxe.c @@ -446,12 +446,6 @@ XenBusDxeDriverBindingStop ( continue;=0D }=0D ChildData =3D XENBUS_PRIVATE_DATA_FROM_THIS (XenBusIo);=0D - Status =3D gBS->DisconnectController (ChildData->Handle, NULL, NULL);= =0D - if (EFI_ERROR (Status)) {=0D - DEBUG ((EFI_D_ERROR, "XenBusDxe: error disconnecting child: %r\n",=0D - Status));=0D - continue;=0D - }=0D =0D Status =3D gBS->CloseProtocol (Dev->ControllerHandle, &gXenIoProtocolG= uid,=0D Dev->This->DriverBindingHandle, ChildData->Handle);=0D --=20 Anthony PERARD