From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.86, mailfrom: glin@suse.com) Received: from m4a0040g.houston.softwaregrp.com (m4a0040g.houston.softwaregrp.com [15.124.2.86]) by groups.io with SMTP; Tue, 02 Jul 2019 20:57:32 -0700 Received: FROM m4a0040g.houston.softwaregrp.com (15.120.17.147) BY m4a0040g.houston.softwaregrp.com WITH ESMTP; Wed, 3 Jul 2019 03:57:11 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Wed, 3 Jul 2019 03:57:23 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (15.124.72.11) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Wed, 3 Jul 2019 03:57:23 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2938.namprd18.prod.outlook.com (20.179.52.152) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Wed, 3 Jul 2019 03:57:21 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::c953:1927:cc0a:dcae]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::c953:1927:cc0a:dcae%7]) with mapi id 15.20.2032.019; Wed, 3 Jul 2019 03:57:21 +0000 From: "Gary Lin" To: " Kinney, Michael D " CC: "devel@edk2.groups.io" , Yi Qian , Zailiang Sun Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Topic: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Index: AQHVL7iX06GyMIyLl06arun+s2tcAqa1mg8AgADJVxCAASkWAIAAAA4QgABHQ+CAAHOHgA== Date: Wed, 3 Jul 2019 03:57:21 +0000 Message-ID: <20190703035709.GB32340@GaryWorkstation> References: <20190701025553.18596-1-michael.d.kinney@intel.com> <20190701040230.GA23179@GaryWorkstation> <20190702094812.GA32340@GaryWorkstation> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6P195CA0001.EURP195.PROD.OUTLOOK.COM (2603:10a6:4:cb::11) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 079debe4-7362-4007-a7c8-08d6ff6a8ca0 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB2938; x-ms-traffictypediagnostic: DM6PR18MB2938: x-ms-exchange-purlcount: 6 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 00872B689F x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(39860400002)(376002)(366004)(136003)(346002)(396003)(189003)(199004)(13464003)(51914003)(9686003)(6306002)(6512007)(4326008)(316002)(6116002)(80792005)(5660300002)(68736007)(33656002)(66066001)(486006)(3846002)(99286004)(71200400001)(71190400001)(6486002)(6436002)(66446008)(966005)(66476007)(66556008)(6246003)(478600001)(54906003)(33716001)(53936002)(73956011)(64756008)(66946007)(26005)(305945005)(2906002)(14454004)(6916009)(1076003)(386003)(81156014)(8676002)(76176011)(53546011)(8936002)(229853002)(6506007)(7736002)(102836004)(52116002)(86362001)(81166006)(186003)(25786009)(14444005)(11346002)(446003)(72206003)(45954011)(256004)(476003)(19627235002)(21314003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2938;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: UprETk/+iEVnvGB+0nk/b8j+WInxuA5JvNpjSVS6xiw30Ik6HM77T7ZNjfcb1cKEhN0pNnpx64dkO3Uu1cYO2saFNKlqzpKL9pce/JykvZ1sr8IyRldhgBenNI2IjlnnNPyWeiJ6m116rX4ETdX2U07UvzrnZ9kWqGCLenwghTrJV6JwwCalyt3MMhdmzF9wAILyEoC6a6iDOtDxqkMgPNtu0r+dIVyAtho2GZlAOCFrVfCjWVC6l9OUTSim3sSqQfZNQ9gEPRtArA681ilKAtZ3nx2fM96ZnOlsvuS7/2slL1dTWlctcs6tkYowG6BVFdUl9deCez9gHSJLFjeDeq2RxoTrpthxoOO12toxzZT+MKkpRUjrRpdyBBGgkBIS/P/sAqgtLZmK09CtKrQP9Alg9LSWYFB5Y3EjtY+AY3U= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 079debe4-7362-4007-a7c8-08d6ff6a8ca0 X-MS-Exchange-CrossTenant-originalarrivaltime: 03 Jul 2019 03:57:21.3657 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2938 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: Content-Transfer-Encoding: quoted-printable On Tue, Jul 02, 2019 at 09:11:06PM +0000, Kinney, Michael D wrote: > Hi Gary, >=20 Hi Mike, > I have posted an update to your patches the removes the setting of WORKS= PACE > and accesses all files relative to WORKSPACE in the Linux shell scripts. > It also fixes null pointer bugs in the SmbiosMiscDxe module. >=20 > https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_S= mbios_Fixes >=20 > With these changes I can boot to the UEFI Shell and to Linux. Please ve= rify from > your environments. >=20 The fix for SmbiosMiscDxe works for me. Thanks for that! I pushed another commit to my branch to check WORKSPACE to notify the user: https://github.com/lcp/edk2-platforms/commit/fc530689e913e3de25ca2c553d616= b9cef28901c We probably have to update Readme.md later. It's already dated. > I see you have added the SDMMC modules, but I do not see that peripheral= yet. > That feature looks like it needs some more debug. We may need to back o= ut those > changes for now. >=20 I saw the SD card settings in the South Cluster Configuration menu even without those SDMMC modules, so they are probably from the edk2-non-osi drivers. However, the SD card didn't work until I added the drivers from MdeModulePkg, so I need those drivers at least for my Minnowboard Turbot. Thanks, Gary Lin > I agree there are ASL issues. The ASL code needs to be updated to the= =20 > latest ASL compiler. >=20 > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Tuesday, July 2, 2019 9:50 AM > > To: Gary Lin ; devel@edk2.groups.io; > > Kinney, Michael D > > Cc: Qian, Yi ; Sun, Zailiang > > > > Subject: RE: [edk2-devel] [edk2-platforms Patch 00/14] > > Vlv2TbltDevicePkg: Remove Intel Framework dependencies > >=20 > > Hi Gary, > >=20 > > Thanks for the branch. I have the build working and have > > reproduced the SMBIOS issue and am debugging that now. > >=20 > > Mike > >=20 > > > -----Original Message----- > > > From: Gary Lin [mailto:GLin@suse.com] > > > Sent: Tuesday, July 2, 2019 2:48 AM > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] > > > Vlv2TbltDevicePkg: Remove Intel Framework dependencies > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000, Michael D > > Kinney wrote: > > > > Hi Gary, > > > > > > > > I recommend you rebase on top of this series. > > > > > > > > I have verified Linux boots and I have been working > > on > > > the GCC and > > > > Linux build scripts as well. > > > > > > > > Please let me know if you see any issues with this > > > series applied and > > > > I can help get them fixed. > > > > > > > Hi Mike, > > > > > > I'm rebasing my patches and they are available in my > > > branch: > > > > > > https://github.com/lcp/edk2-platforms/commits/vlv2- > > > fixes-wip > > > > > > It's based on > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e) > > > and edk2-non- > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f). > > > > > > There are 3 problems I currently encountered, and maybe > > you can give > > > me some suggestions. > > > > > > 1. Missing DSDT > > > > > > When compiling DSDT, iasl failed with this error: > > > > > > DSDT.iiii 6077: > > > Or(ShiftLeft(Derefof(Index(CDCT, > > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM) > > > Error 6163 - > > > ^ Object is created temporarily in another method and > > cannot be > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE) > > > > > > The code is from > > > > > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB > > > DA.ASL > > > > > > I have to comment out the line or iasl won't generate > > the aml file and > > > the OS would fail to get DSDT. > > > > > > My acpica version is 20190509, and I vaguely remember > > that the older > > > acpica seems to be more tolerant to this error. > > > > > > 2. Crash at SMBIOS driver > > > > > > When booting the system, I got the following error: > > > > > > Loading driver at 0x00078DBA000 > > EntryPoint=3D0x00078DBEC3C > > > MiscSubclass.efi > > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920- > > 2D3B36D750DF > > > 78FE8D18 ProtectUefiImageCommon - > > > 0x78FE8040 > > > - 0x0000000078DBA000 - 0x0000000000007B80 > > > PlatformInfoHob->BoardId [0xB0] > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01 > > 01/01/2019 > > > 00:00 > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 32- > > bit table > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to 64- > > bit table > > > SmbiosCreateTable: Initialize 32-bit entry point > > structure > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table > > > SmbiosCreateTable: Initialize 64-bit entry point > > structure > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit > > table Create Smbios > > > Manu callback. > > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode) CPU > > Apic ID - > > > 00000000 !!!! > > > RIP - 0000000078DBEC26, CS - 0000000000000038, RFLAGS > > > - 0000000000010206 RAX - 0000000000000000, RCX - > > 000000007984A5A0, > > > RDX - 000000007A46E5FF RBX - 000000007A46E920, RSP - > > > 000000007A46E8B0, RBP - > > > 0000000078DC0EC0 RSI - 0000000000000012, RDI - > > > 0000000000000003 > > > R8 - 800000000000000E, R9 - 000000007A46E920, R10 - > > > 0000000078FE8398 > > > R11 - 0000000000000001, R12 - 0000000078FE8798, R13 - > > > 0000000078FE8898 > > > R14 - 0000000078FE8818, R15 - 000000007A46EC60 > > > DS - 0000000000000030, ES - 0000000000000030, FS - > > > 0000000000000030 > > > GS - 0000000000000030, SS - 0000000000000030 > > > CR0 - 0000000080010013, CR2 - 0000000000000000, CR3 - > > > 000000007A201000 > > > CR4 - 0000000000000628, CR8 - 0000000000000000 > > > DR0 - 0000000000000000, DR1 - 0000000000000000, DR2 - > > > 0000000000000000 > > > DR3 - 0000000000000000, DR6 - 00000000FFFF0FF8, DR7 - > > > 0000000000000400 GDTR - 0000000079FFDA98 > > 0000000000000047, LDTR - > > > 0000000000000000 > > > IDTR - 0000000079862018 0000000000000FFF, TR - > > > 0000000000000000 > > > FXSAVE_STATE - 000000007A46E510 > > > !!!! Find image based on IP(0x78DBEC26) > > > /home/gary/git/edk2- > > > > > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl > > > > > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas > > > s. > > > dll (ImageBase=3D0000000078DBA000, > > > EntryPoint=3D0000000078DBEC3C) !!!! > > > > > > I disaseembled MiscSubclass.debug and found that the > > address is a > > > "ud2" > > > instruction at > > > > > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa > > > seBoardManufacturer() > > > > > > After adding a few more debug messages, the system > > crashed at another > > > function: > > > > > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios > > > ManuCallback() > > > > > > If I added debug messages to both functions, the system > > booted > > > successfully. I currently didn't have any clue on this. > > > > > > 3. The firmware always booted into EFI shell. > > > > > > I guess something went wrong with BDS. I haven't looked > > into this > > > issue yet. > > > > > > Thanks, > > > > > > Gary Lin > > > > > > > Thanks, > > > > > > > > Mike > > > > > > > > > -----Original Message----- > > > > > From: Gary Lin [mailto:GLin@suse.com] > > > > > Sent: Sunday, June 30, 2019 9:04 PM > > > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch > > > 00/14] > > > > > Vlv2TbltDevicePkg: Remove Intel Framework > > > dependencies > > > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700, Michael > > D > > > Kinney wrote: > > > > > > The following changes remove all dependencies on > > > the > > > > > IntelFrameworkPkg > > > > > > and IntelFrameworkModulePkg from the > > > Vlv2TbltDevicePkg > > > > > platform > > > > > > builds. These changes do depend on updates > > > binaries > > > > > on the edk2-non-osi repository. > > > > > > > > > > > Hi Michael, > > > > > > > > > > I am amending the bash scripts for gcc. The > > firmware > > > I built is > > > > > using the binaries from Development190216 and could > > > boot into Linux > > > > > successfully with some workarounds for Wpce791, > > Bds, > > > and > > > > > InteFspWrapper. The patches you posted eliminate > > > those parts I have > > > > > to work around. > > > > > > > > > > Just want to know if you need any assistance for > > the > > > gcc build? I > > > > > could rebase my work upon your patches and send > > them > > > later. > > > > > > > > > > Thanks, > > > > > > > > > > Gary Lin > > > > > > > > >=20 > > > > > > > > >=20