public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
* [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg
@ 2019-07-03 10:36 Leif Lindholm
  2019-07-03 14:47 ` Laszlo Ersek
  0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2019-07-03 10:36 UTC (permalink / raw)
  To: devel; +Cc: Laszlo Ersek

ArmVirtPkg was created before we introduced the Package Reviewer (R:)
role in Maintainers.txt. However, we have always had an informal
agreement that if Ard or Laszlo is absent, I can review patches by
the still present one for going into ArmVirtPkg.

Plus, as one of the ArmPkg maintainers, it makes sense for me to have
better visibility of goings-on in ArmVirtPkg.

So let's formalise that, and add myself as a Package Reviewer, to be
CC:d on patches (while not taking up full maintainer responsibilities).

Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
 Maintainers.txt | 1 +
 1 file changed, 1 insertion(+)

diff --git a/Maintainers.txt b/Maintainers.txt
index 388a21c63585..13428929e96d 100644
--- a/Maintainers.txt
+++ b/Maintainers.txt
@@ -79,6 +79,7 @@ M: Laszlo Ersek <lersek@redhat.com>
 M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
 R: Julien Grall <julien.grall@arm.com>
    (Xen modules)
+R: Leif Lindholm <leif.lindholm@linaro.org>
 
 BaseTools
 W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
-- 
2.11.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg
  2019-07-03 10:36 [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg Leif Lindholm
@ 2019-07-03 14:47 ` Laszlo Ersek
  2019-07-03 15:33   ` [edk2-devel] " Leif Lindholm
  0 siblings, 1 reply; 3+ messages in thread
From: Laszlo Ersek @ 2019-07-03 14:47 UTC (permalink / raw)
  To: Leif Lindholm, devel

On 07/03/19 12:36, Leif Lindholm wrote:
> ArmVirtPkg was created before we introduced the Package Reviewer (R:)
> role in Maintainers.txt. However, we have always had an informal
> agreement that if Ard or Laszlo is absent, I can review patches by
> the still present one for going into ArmVirtPkg.
> 
> Plus, as one of the ArmPkg maintainers, it makes sense for me to have
> better visibility of goings-on in ArmVirtPkg.
> 
> So let's formalise that, and add myself as a Package Reviewer, to be
> CC:d on patches (while not taking up full maintainer responsibilities).
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
>  Maintainers.txt | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/Maintainers.txt b/Maintainers.txt
> index 388a21c63585..13428929e96d 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -79,6 +79,7 @@ M: Laszlo Ersek <lersek@redhat.com>
>  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>  R: Julien Grall <julien.grall@arm.com>
>     (Xen modules)
> +R: Leif Lindholm <leif.lindholm@linaro.org>
>  
>  BaseTools
>  W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thank you for the help!
Laszlo

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [edk2-devel] [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg
  2019-07-03 14:47 ` Laszlo Ersek
@ 2019-07-03 15:33   ` Leif Lindholm
  0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2019-07-03 15:33 UTC (permalink / raw)
  To: devel, lersek

On Wed, Jul 03, 2019 at 04:47:35PM +0200, Laszlo Ersek wrote:
> On 07/03/19 12:36, Leif Lindholm wrote:
> > ArmVirtPkg was created before we introduced the Package Reviewer (R:)
> > role in Maintainers.txt. However, we have always had an informal
> > agreement that if Ard or Laszlo is absent, I can review patches by
> > the still present one for going into ArmVirtPkg.
> > 
> > Plus, as one of the ArmPkg maintainers, it makes sense for me to have
> > better visibility of goings-on in ArmVirtPkg.
> > 
> > So let's formalise that, and add myself as a Package Reviewer, to be
> > CC:d on patches (while not taking up full maintainer responsibilities).
> > 
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
> > ---
> >  Maintainers.txt | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/Maintainers.txt b/Maintainers.txt
> > index 388a21c63585..13428929e96d 100644
> > --- a/Maintainers.txt
> > +++ b/Maintainers.txt
> > @@ -79,6 +79,7 @@ M: Laszlo Ersek <lersek@redhat.com>
> >  M: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> >  R: Julien Grall <julien.grall@arm.com>
> >     (Xen modules)
> > +R: Leif Lindholm <leif.lindholm@linaro.org>
> >  
> >  BaseTools
> >  W: https://github.com/tianocore/tianocore.github.io/wiki/BaseTools
> > 
> 
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks!
Pushed as e54ce6d07428.

Regards,

Leif

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2019-07-03 15:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-07-03 10:36 [PATCH 1/1] Maintainers.txt: add Leif Lindholm as Package Reviewer of ArmVirtPkg Leif Lindholm
2019-07-03 14:47 ` Laszlo Ersek
2019-07-03 15:33   ` [edk2-devel] " Leif Lindholm

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox