From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=A1LfT2QW; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 03 Jul 2019 03:44:16 -0700 Received: by mail-wr1-f68.google.com with SMTP id n4so2181576wrw.13 for ; Wed, 03 Jul 2019 03:44:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=OMNWevqBAHR2aNbA19EU9pKaiGP6B40K2zGl6zAbjQM=; b=A1LfT2QWar26Tv9NdQXnUHzMdHplnn2N8c2NWXsla/I3UiPc/li5W8FslXf6Qd6YEY ImA1G5Gd/gb5eESYmpqn9Na6TL0Gao0sudEuseRc16h7ih5bz815gEdsCa4P708itDKb mohUcg3Au7+XF2bnwyoqydXR17eF/PtvcPfqDSVwgVrn6SSQgZZVLA1To4E+rRQX+7OP Jzg8r1L2Bdpu2XUpmErNQO65oBhCAb94lZoYI6upPFPf14Xn3hflPm6md90WK3VpTsCK j6N5iqWy1aPc/W/ovaXrBYh9rCXEWxzExMz1uh5zeLS4tC0Zhn3Kl6EJm1ZeeKXz07E5 9+9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=OMNWevqBAHR2aNbA19EU9pKaiGP6B40K2zGl6zAbjQM=; b=BMwXM5wPq337VcIKpP+Uyoyf/uLy2MWP0WgN+AFsKFlxfH1J1r5I7I0uMvHaBhzAHc F4TPQ52WVPrfOWK2EusN/EZBedTCmetxtJis4EX92JW6HfkbQsCHUj5BAaqVmGabnnBs vj+2wQzVorYo30EXUxHraZKFMk/w6Z7pg8ZR/YNP5mZU5kplLJiLzGj4RakpgLRxgZQ2 716spACRaDVUUrGG/49uUItSctCtvCAUNFw6vESKEK9Cb57QQfoslFGXdFjcE4Hg2WEW Wl+1Rr7AJal9kaRaJuViYryVlGW0i+zGg4frX/LK+pDKIkd9Hbl+FqIrihpiQdHMZ5xj FylA== X-Gm-Message-State: APjAAAXO/QZGruNrhHSu2pkn/nTYPAQvIWYJ6+qdqFMMEfW+wMbGCh0j ybojHou8YSwXdJXoeni49zKxYg== X-Google-Smtp-Source: APXvYqwyPFDXUYSYZPl8CwNTrFEEs1MfX5XMC+zqwMaKYJhZBS4NAOKOPJfe/EqtAIAdgQXZTANYBQ== X-Received: by 2002:adf:f7cf:: with SMTP id a15mr534532wrq.129.1562150654966; Wed, 03 Jul 2019 03:44:14 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h1sm1226840wrt.20.2019.07.03.03.44.13 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 03:44:13 -0700 (PDT) Date: Wed, 3 Jul 2019 11:44:12 +0100 From: "Leif Lindholm" To: "Wu, Hao A" Cc: "devel@edk2.groups.io" Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Message-ID: <20190703104412.yywitr2dejdwbj2m@bivouac.eciton.net> References: <20190614202121.18952-3-leif.lindholm@linaro.org> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 03, 2019 at 07:52:46AM +0000, Wu, Hao A wrote: > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Saturday, June 15, 2019 4:21 AM > > To: devel@edk2.groups.io > > Cc: Feng, Bob C; Gao, Liming; Andrew Fish; Laszlo Ersek; Kinney, Michael D; > > Wu, Hao A > > Subject: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for > > Arm/AArch64 > > > > Add Ard and Leif as responsible for any path matching > > F: */Arm/ > > F: */AArch64/ > > > > Signed-off-by: Leif Lindholm > > --- > > Maintainers.txt | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/Maintainers.txt b/Maintainers.txt > > index cd32f9b00170..e415f51468d5 100644 > > --- a/Maintainers.txt > > +++ b/Maintainers.txt > > @@ -82,6 +82,14 @@ EDK II Releases: > > W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release- > > Planning > > M: Liming Gao > > > > +EDK II Architectures: > > +--------------------- > > +ARM, AARCH64 > > +F: */AArch64/ > > +F: */Arm/ > > > Hello Leif, > > I want to confirm a couple of usage model for the wildcard character. > > Maybe they have been explained with your response to Laszlo's comments, > but I just want to double-confirm with my using cases. > > 1. Matching multiple levels of directories > > For the below 2 folders: > MdeModulePkg/Bus/Ufs/ > MdeModulePkg/Bus/Pci/UfsPciHcDxe/ > > I can use: > MdeModulePkg/*Ufs*/ > > to match them all, right? Yes, that is how it currently works (I think?). It is unclear to me if there is consensus on how we want it to work in the future. > 2. Matching header files (usually within the Include/ directory) > > In some cases, a feature may include some drivers + some include header > files. So for the below case: > MdeModulePkg/Include/Library/HiiLib.h > MdeModulePkg/Include/Guid/HiiResourceSampleHii.h > MdeModulePkg/Universal/HiiDatabaseDxe/ > MdeModulePkg/Universal/HiiResourcesSampleDxe/ > MdeModulePkg/Library/UefiHiiLib/ > > Should I use: > MdeModulePkg/*Hii*/ > > to match the drivers(libraries) and the headers all or should I use: > MdeModulePkg/*Hii*/ > MdeModulePkg/Include/*Hii*.h My view is that this second option would be required. If MdeModulePkg/*Hii*/ matches on the .h files, that is effectively a bug - is that the behaviour you are currently seeing? Best Regards, Leif