From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=PcZ9UFPc; spf=pass (domain: linaro.org, ip: 209.85.128.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by groups.io with SMTP; Wed, 03 Jul 2019 04:43:26 -0700 Received: by mail-wm1-f66.google.com with SMTP id g135so1861731wme.4 for ; Wed, 03 Jul 2019 04:43:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lAzMDa65vzDhgql9mxr2bRQE4ixEPq8uwUSfD01DQbw=; b=PcZ9UFPctDb1SRNBM6re+Xqt/zbP8cHRsrUZQ/T04sw7fJUOtWXW4tvujeNg3Mkz3f FWeQkwa6YtuR9sJflTFQvkr84wHbtkOaPOkSgOhV+xZyIjd8PVQ4JhqbMqIlVL50Y8hU hsv7ou937N/YI5jHw7VvKQUnNkdnPeKRTqo+bTtWSRuzbdG7mTgODJdrXYQdyylS51bC z5wIfKv/XilDdC5JRhVED1sPFAXoTTkx4Ri29gzT9s/ASqS6tP6U2IAwA1CBLA0vSmaU rCLBXJKUf4lK/z86YEXpm5w/z5fmBkvkpyB7Jhw/T5JUEavHFCA+UJGIzWqlIHEZzfeW DNkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lAzMDa65vzDhgql9mxr2bRQE4ixEPq8uwUSfD01DQbw=; b=NQmv3k9ltMgD4WQKIKZpTGqAjKSOgHiUDQZlCNbh1XX0itomIgNpA1qb0iKnQsdrPY SMXgsQfjTAQwibtmUnEbBjkUhdBgrA6koWV3UD2NLGmk0g6iJEWUE8QT9lMp7AFgBPbm zkkKWCDYBQwcoNONPc9nHxH1OBb1b2ZHg263jgaoSK5hgsX4qphCgJyYFFj+1vkbjmVB 9/lElTmNtMRdn2VT6NkDU9bkrz+aDhGcQkvGUT5KrEGcoo7GbnhI1+xYqsu6n1IVe4mL kZfLhqRDgCSQpPPmmMISLDxMEc0C88yMFEIkugRur3INjrpZBI6tWK087VyoAQzACoCd 0DiQ== X-Gm-Message-State: APjAAAXibLgqx2N+eDYaPBfGNw8RhprTzVbo8OZSY+69ty8MQV/OyFMp 9G7iK2yhGSBAsxN2TzVgeqn/XA== X-Google-Smtp-Source: APXvYqz+UOvEaWZkZokvsXI87Twy2NcjhN1TeppLlag7Kqz4IjZBU48PXlcxh9+PTFGPcSaKAJ04jg== X-Received: by 2002:a1c:305:: with SMTP id 5mr8094195wmd.101.1562154204421; Wed, 03 Jul 2019 04:43:24 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o12sm2037338wrx.63.2019.07.03.04.43.23 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 04:43:23 -0700 (PDT) Date: Wed, 3 Jul 2019 12:43:22 +0100 From: "Leif Lindholm" To: Pete Batard Cc: devel@edk2.groups.io, ard.biesheuvel@linaro.org Subject: Re: [edk2-platforms: PATCH 1/2] Platform/RPi3: Set the boot option of UEFI Shell as non-active Message-ID: <20190703114322.nw4zz3ip3m262mjt@bivouac.eciton.net> References: <20190702161341.2652-1-pete@akeo.ie> <20190702161341.2652-2-pete@akeo.ie> MIME-Version: 1.0 In-Reply-To: <20190702161341.2652-2-pete@akeo.ie> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 02, 2019 at 05:13:40PM +0100, Pete Batard wrote: > This makes boot from SD/USB the default, which is what most users > should expect. Pressing F1 at boot still boots to UEFI Shell. > > Signed-off-by: Pete Batard > --- > Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c | 2 +- > Platform/RaspberryPi/RPi3/Readme.md | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c > index 92f3b6146dd7..e7757115d82c 100644 > --- a/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c > +++ b/Platform/RaspberryPi/RPi3/Library/PlatformBootManagerLib/PlatformBm.c > @@ -460,7 +460,7 @@ PlatformRegisterOptionsAndKeys ( > > RemoveStaleBootOptions (); > > - ShellOption = PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_ACTIVE); > + ShellOption = PlatformRegisterFvBootOption (&gUefiShellFileGuid, L"UEFI Shell", LOAD_OPTION_CATEGORY_APP); If you make a v2, could you break the above line please? / Leif > if (ShellOption != -1) { > // > // F1 boots Shell. > diff --git a/Platform/RaspberryPi/RPi3/Readme.md b/Platform/RaspberryPi/RPi3/Readme.md > index 7434233df0fb..624f3a8d287a 100644 > --- a/Platform/RaspberryPi/RPi3/Readme.md > +++ b/Platform/RaspberryPi/RPi3/Readme.md > @@ -26,9 +26,9 @@ It also provides support for ATF ([Arm Trusted Platform](https://github.com/ARM- > HDMI and the mini-UART serial port can be used for output devices, with mirrored output. > USB keyboards and the mini-UART serial port can be used as input. > > -On a freshly built firmware, the default is to boot the UEFI shell. > -To change the default boot order (for instance to boot uSD media by default) you > -will need to edit the preferences in _Boot Maintenance Manager_. > +The default for the firmware is to first attempt boot from SD then USB. The UEFI > +Shell can also be accessed by pressing F1. To change the boot order you can edit > +the preferences in the _Boot Maintenance Manager_ menu. > > For additional information about the tested systems and how to set them up, > please see [Systems.md](./Systems.md). > -- > 2.21.0.windows.1 >