public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, coeur@gmx.fr
Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
Date: Wed, 3 Jul 2019 16:30:49 +0100	[thread overview]
Message-ID: <20190703153049.2ivog4miagwcj4xc@bivouac.eciton.net> (raw)
In-Reply-To: <4907.1561693378871373296@groups.io>

Hi Cœur,

Thank you for your contribution.

Normally, we expect patches to be submitted via git send-email, as
opposed to through the groups.io web interface (it introduces
spectacular levels of corruption to the original patch).

However, as this is a first submission, and it actually worked
surprisingly well to copy/paste the rendered HTML from the gmail web
client, I'm happy to take the patches in their current format.

I notice you experimented with different methods of submitting the
patches. For reference, out of the three patches submitted to packages
I look after (ArmPkg, ArmPlatformPkg and EmbeddedPkg), the ArmPkg one
(attached to email) was the most straightforwards one, and the
EmbeddedPkg one (lacking from/subject headers in the message body) was
the least straightforward one.

Anyway, these 3 patches look good to me:
The change to ArmPkg/Drivers/CpuDxe/Arm/Mmu.c does not look like a
typo fix, but it's non-functional so I'm OK to leave it in.

For ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c, I would probably
have changed to "input" instead of "inputted", but both are valid, and
yours is the strict typo fix of the previous wording.

However, I do need clarification on one point:
You have submitted these patches containing the Contributed-under:
tag. We have recently(ish) dropped the TianoCore Contribution
Agreement in favour of relicensing the code under the BSD+Patent
license [1].
Use of the Contributed-under tag indicates you may have missed this
change, so could you confirm whether you are happy to contribute these
patches under BSD+Patent?

Best Regards,

Leif

[1] https://spdx.org/licenses/BSD-2-Clause-Patent.html

  reply	other threads:[~2019-07-03 15:30 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-28  3:42 [PATCH] EmbeddedPkg: Fix various typos Cœur
2019-07-03 15:30 ` Leif Lindholm [this message]
2019-07-03 16:58   ` [edk2-devel] " Cœur
2019-07-04 13:01     ` Leif Lindholm
2019-07-04 14:03       ` Cœur
2019-07-04 14:20         ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190703153049.2ivog4miagwcj4xc@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox