From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=h7EcLQVi;
 spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org)
Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66])
 by groups.io with SMTP; Wed, 03 Jul 2019 08:30:53 -0700
Received: by mail-wr1-f66.google.com with SMTP id n4so3286345wrw.13
        for <devel@edk2.groups.io>; Wed, 03 Jul 2019 08:30:53 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=date:from:to:subject:message-id:references:mime-version
         :content-disposition:content-transfer-encoding:in-reply-to
         :user-agent;
        bh=2aBpYBoqLegPc6xVJORMn3Npw5M3Z1eCXYY4Uj3I5rQ=;
        b=h7EcLQVii+IFSVBLY6hdX3jblQehmmDaVRm1cjgDEsFLY98rf1Zvppj4HxlujdxtsF
         mW6zb03GaZGdlZaTq6zHR5M/+nGz+LZDT4lyIKRMlc1ajdTKdImUqEjQOKb5DHOfW7oJ
         uVnMOUWT/UtG66zaW0N+tgLnGXP32ojXjUnKkUI1SV4ce65eWPj/nJ3wp34Fpx9MNX4q
         40+dN3bex5gyoJyTBrsTAURFzmD9ntyMlIapMXeNwM8u3ZEmxBvN3/nJcnHnihTeYkuy
         89L9hGFQXaLyXbhBT5IwCQxbvcB/+amCUCHKSwcrlqd+qbhzlJrwMm8yLFNLV3zwiRvr
         UuTQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:date:from:to:subject:message-id:references
         :mime-version:content-disposition:content-transfer-encoding
         :in-reply-to:user-agent;
        bh=2aBpYBoqLegPc6xVJORMn3Npw5M3Z1eCXYY4Uj3I5rQ=;
        b=uAqmANTrPNp1BLBxIY1Ns75f4HwH1MunTsvS1OtTw32nDxsL4IhfGJOh5glcPxR3gm
         BiuzqURDLvyQgQ6WKxBMqg5u0YLC0wgO4YaDLDDBnCE8WJ9ToSdAk1X2eYlwqjeqRi0F
         HENfqGLUEmi2RDrjfHKTYDZ4w8sPI0O+6sRHZTLu7AzUWhmlWAxSEvfEZpFHAcvkE85s
         AqpTR09pCx3fWUz0aKEfr3lLFY4cW3Pe1aHzAOlQ5UuxvxT46nVRG1pWPzvw4Km4NJlu
         9lqj4BjXyThYgqwfBuiP7I0iOQoKQlSR9joz7me40pojSnEqgPw1cfTLtQnwKx4TB7cF
         W8fA==
X-Gm-Message-State: APjAAAXuDg7z6l3JWAlXl6qI8w0Rmb6n13ldQnK5F/jd/ed5FOTS0aK1
	PFae1IRv+r8OTw/hkNJpsalTM0bnriA=
X-Google-Smtp-Source: APXvYqxTr6cG5uD7kwxcN4s+hbsBKaQc59LuSXEPlZnbM31tJMzSotOzh8/GwjkWkkS+uED1D6nBDA==
X-Received: by 2002:a5d:63cb:: with SMTP id c11mr29581391wrw.65.1562167851989;
        Wed, 03 Jul 2019 08:30:51 -0700 (PDT)
Return-Path: <leif.lindholm@linaro.org>
Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2])
        by smtp.gmail.com with ESMTPSA id l8sm5159291wrg.40.2019.07.03.08.30.50
        (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256);
        Wed, 03 Jul 2019 08:30:51 -0700 (PDT)
Date: Wed, 3 Jul 2019 16:30:49 +0100
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, coeur@gmx.fr
Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos
Message-ID: <20190703153049.2ivog4miagwcj4xc@bivouac.eciton.net>
References: <4907.1561693378871373296@groups.io>
MIME-Version: 1.0
In-Reply-To: <4907.1561693378871373296@groups.io>
User-Agent: NeoMutt/20170113 (1.7.2)
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit

Hi Cœur,

Thank you for your contribution.

Normally, we expect patches to be submitted via git send-email, as
opposed to through the groups.io web interface (it introduces
spectacular levels of corruption to the original patch).

However, as this is a first submission, and it actually worked
surprisingly well to copy/paste the rendered HTML from the gmail web
client, I'm happy to take the patches in their current format.

I notice you experimented with different methods of submitting the
patches. For reference, out of the three patches submitted to packages
I look after (ArmPkg, ArmPlatformPkg and EmbeddedPkg), the ArmPkg one
(attached to email) was the most straightforwards one, and the
EmbeddedPkg one (lacking from/subject headers in the message body) was
the least straightforward one.

Anyway, these 3 patches look good to me:
The change to ArmPkg/Drivers/CpuDxe/Arm/Mmu.c does not look like a
typo fix, but it's non-functional so I'm OK to leave it in.

For ArmPkg/Library/ArmArchTimerLib/ArmArchTimerLib.c, I would probably
have changed to "input" instead of "inputted", but both are valid, and
yours is the strict typo fix of the previous wording.

However, I do need clarification on one point:
You have submitted these patches containing the Contributed-under:
tag. We have recently(ish) dropped the TianoCore Contribution
Agreement in favour of relicensing the code under the BSD+Patent
license [1].
Use of the Contributed-under tag indicates you may have missed this
change, so could you confirm whether you are happy to contribute these
patches under BSD+Patent?

Best Regards,

Leif

[1] https://spdx.org/licenses/BSD-2-Clause-Patent.html