From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=MmmvDWpq; spf=pass (domain: linaro.org, ip: 209.85.221.66, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f66.google.com (mail-wr1-f66.google.com [209.85.221.66]) by groups.io with SMTP; Wed, 03 Jul 2019 14:18:06 -0700 Received: by mail-wr1-f66.google.com with SMTP id c2so4328716wrm.8 for ; Wed, 03 Jul 2019 14:18:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=QeOvF2figWEqDAITSfzdOBpsKd++qFcDtmm19GQv23s=; b=MmmvDWpqQKwO/I/7dWoNsTCQlFo1UCnlm7L9wkUq969YkNGfzJIaH8mpf3jlrbNGH9 UGDYfuZy++Dq1unmAx+qC/vZ7WpFyLIxreh9IZf3E9oRuz9sJWw5Rm5TRaCbiK5pjDhe d24nAyOy7J/iljQEmcfOkuzijeXcjhKOgWeLs/pAPEHrgwmLCaE9IrGcW9FHDz2sEMfa o7qZKKkUzOjiJ0bGsD5+jiOCznnAvS4h2ozZq0UHwPKxz35aqsEtLFpHzdXsSG8dhxV0 WGecpteHYTEqNTlykhXpIg6Q9dGjoGfbfMtHrPmhX0fJq3KERx1HltQGqCKy23ljcj1D pxUw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=QeOvF2figWEqDAITSfzdOBpsKd++qFcDtmm19GQv23s=; b=J8DTdnpoWPLavVNzDt9aO6ahBAT0Lqh4dVjmJ+bBt1Y4RQC/XgBLJAsKwBxErIP2kl j+HpqqIiBkIbd9AlIgiaHNgH50ClzobXEwayHXK7IwsT9osHjpKMgebkoEE0j/FpAdjk g0nveDZS3P953EAMC9YEFm9UYUGhC5FqymWacuBtTinZsGUApq4XH1Jy02DcPQfhEtRg hJAE9AfX5/x7GYklGW4jjxcVwmCvWNLY2gSKrB0JwDgrO4byVlafsMHtKJuFJ9EhAFyr Pi29u3is/oK6NooCoSJbeTBu7bcOUHV4yNvgjQTSGBw1zMT+WVMVMI0OPPaH7lkAJjg4 gqyQ== X-Gm-Message-State: APjAAAWOwhMtavxFlN05DV96KkvQ/Qb0Po+TqwvfVUvO/N0H8t5pI4E3 lqURrXKlvdzXJ47RVJL1WfDSyuzXDjE= X-Google-Smtp-Source: APXvYqwt2SM39uOzxQGDrjZrJh7eTxPLj6dPAgwrm/UHjponkjaLT3nO5BP3My7FVNoUz1YjyXPm5Q== X-Received: by 2002:a5d:6b07:: with SMTP id v7mr16008068wrw.169.1562188684805; Wed, 03 Jul 2019 14:18:04 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id a6sm670666wmj.15.2019.07.03.14.18.03 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 03 Jul 2019 14:18:04 -0700 (PDT) Date: Wed, 3 Jul 2019 22:18:02 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, lersek@redhat.com Cc: imran.desai@intel.com, Jian J Wang , Jordan Justen , Ard Biesheuvel , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Stefan Berger , Stephano Cetola , Michael Kinney , Andrew Fish Subject: Re: [edk2-devel] [PATCH v2 5/5] OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe Message-ID: <20190703211802.3wieoi5imbg76v6i@bivouac.eciton.net> References: <20190528204049.86463-1-imran.desai@intel.com> <20190528204049.86463-6-imran.desai@intel.com> <9c92afaf-b368-628e-f686-64257831343b@redhat.com> MIME-Version: 1.0 In-Reply-To: <9c92afaf-b368-628e-f686-64257831343b@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Jul 03, 2019 at 10:37:40PM +0200, Laszlo Ersek wrote: > On 05/28/19 22:40, Imran Desai wrote: > > > > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1781 > > > > EDK2 Support for SM3 digest algorithm is needed to enable TPM with SM3 PCR > > banks. This digest algorithm is part of the China Crypto algorithm suite. > > This integration has dependency on the openssl_1_1_1b integration into > > edk2. > > This patch links SM3 support into Tcg2Pei and Tcg2Dxe. > > > > > > Signed-off-by: Imran Desai > > Cc: Jordan Justen > > Cc: Laszlo Ersek > > Cc: Ard Biesheuvel > > Cc: Marc-André Lureau > > Cc: Stefan Berger > > --- > > OvmfPkg/OvmfPkgIa32.dsc | 2 ++ > > OvmfPkg/OvmfPkgIa32X64.dsc | 2 ++ > > OvmfPkg/OvmfPkgX64.dsc | 2 ++ > > 3 files changed, 6 insertions(+) > > Wow, what just happened here? > > I'm noticing now that this patch has been pushed to the master branch as > commit a7c7d21ffa9a. > > However, *NONE* of the OvmfPkg co-maintainers or reviewers have reviewed > this patch! Nor has Jian, or Jiewen, on-list - there is only the tags in the commit. Other patches in the set have R-b: from Jiewen in the commit, but never on the list. Not that it would matter. Patches do not go in without package maintainer review. Unless there is a *really* good reason, at which point I expect at least one steward to Ack/R-b:. > The commit message includes "Cc:" lines, but that's a lie. Probably not > an intentional lie, but a lie nonetheless. These patches have *never* > been delivered to my inbox, and if I look at the address list on the > message instance that was reflected by the mailing list, that address > list confirms the same. I'm pretty sure Imran's git configuration has a > bug related to CC's. (I've extended the address list now, manually.) > > Jian: please revert this patch immediately, stating, as reason, that the > patch review process was not honored. I'm sorry but I cannot let this > slide -- if you look at commit a7c7d21ffa9a now, it suggests that the > OvmfPkg maintainers / reviewers were CC'd (they weren't), but they > ignored the patch (they didn't -- they couldn't see it), and that > another maintainer pushed the patch just the same (which is factual, but > *wrong*). Based on the included Reviewed-by tags from Jiewen that never appeared on the list, this entire series need to be reverted. 1/5 then needs Reviewed-by: from an MdePkg maintainer, after which 2-4/5 can be pushed again if the commit messages are updated to contain only the Reviewed-by: and Cc: that have actually happened on-list. / Leif