From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.85, mailfrom: glin@suse.com) Received: from m4a0039g.houston.softwaregrp.com (m4a0039g.houston.softwaregrp.com [15.124.2.85]) by groups.io with SMTP; Thu, 04 Jul 2019 02:05:15 -0700 Received: FROM m4a0039g.houston.softwaregrp.com (15.120.17.147) BY m4a0039g.houston.softwaregrp.com WITH ESMTP; Thu, 4 Jul 2019 09:01:34 +0000 Received: from M4W0334.microfocus.com (2002:f78:1192::f78:1192) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 4 Jul 2019 08:58:41 +0000 Received: from NAM04-BN3-obe.outbound.protection.outlook.com (15.124.8.10) by M4W0334.microfocus.com (15.120.17.146) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Thu, 4 Jul 2019 08:58:41 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2362.namprd18.prod.outlook.com (20.179.71.27) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2032.20; Thu, 4 Jul 2019 08:58:39 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::c953:1927:cc0a:dcae]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::c953:1927:cc0a:dcae%7]) with mapi id 15.20.2032.019; Thu, 4 Jul 2019 08:58:39 +0000 From: "Gary Lin" To: Laszlo Ersek CC: "devel@edk2.groups.io" , Jordan Justen , Stefan Berger , =?iso-8859-1?Q?Marc-Andr=E9_Lureau?= Subject: Re: [edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled Thread-Topic: [edk2-devel] [PATCH 1/1] OvmfPkg: Only import DxeTpmMeasurementLib when TPM is enabled Thread-Index: AQHVMYlHJPM5Pv2uK02R7xr3titCA6a5Te/SgACIYICAAE0lUoAABsEA Date: Thu, 4 Jul 2019 08:58:39 +0000 Message-ID: <20190704085826.GD32340@GaryWorkstation> References: <20190703102228.25441-1-glin@suse.com> <5f74464e-1a3a-455a-ba46-0f00e20f4ce7@redhat.com> <20190704035808.GC32340@GaryWorkstation> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: LO2P265CA0153.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:9::21) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: a81a7552-7f2d-43d1-9c81-08d7005dce86 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB2362; x-ms-traffictypediagnostic: DM6PR18MB2362: x-ms-exchange-purlcount: 1 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:9508; x-forefront-prvs: 0088C92887 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(4636009)(7916004)(366004)(396003)(376002)(346002)(39860400002)(136003)(189003)(199004)(19627235002)(99286004)(3846002)(52116002)(76176011)(14444005)(386003)(68736007)(966005)(53546011)(6506007)(14454004)(256004)(229853002)(6486002)(316002)(102836004)(446003)(33716001)(476003)(186003)(11346002)(54906003)(305945005)(6436002)(6916009)(1076003)(478600001)(486006)(6116002)(7736002)(26005)(6512007)(4326008)(25786009)(71200400001)(71190400001)(73956011)(81156014)(81166006)(8936002)(5660300002)(66446008)(64756008)(66556008)(66476007)(66946007)(86362001)(72206003)(2906002)(80792005)(8676002)(66066001)(6246003)(6306002)(53936002)(9686003)(33656002);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2362;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;MX:1;A:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: rbEvFxPMP5vycO49M1rcGQFlOFe/cyewYNIptrnD4Zewug4GzPAR581yfrQP2LBoq7X9IdmL+2VNKcjCgNfC5JelfpX9OuVvzJFlC9/mOnu1NkBdVqK58I0/MbO0/oRVY3BVtKb9FIHoir3kyQ5Y3N3K1Ozks6goB59Dl4410sbI5XJZ3PvvzK9F1U6xa5SHDy/9v3hWRWSi15CrZ4geUuJIQF3wWeP00PKSMU6VRaSZAHi3pdz63mtSQH2AP6FBnBJCSk938t+b7KxWU9e7zjZey2SgTAC4TIkiB+fauDYmT8NxLeck3Zj9fG2iNlLF6Yj2WzYuC5BMZ3criS49MCnjZuo9vvls3iDULWEwmgMEnzqSlmEhku9KLahvfFJ09sFg5rGGzGTEA1DMxtZfvF8oXHRJvkedlz4HR6qbywM= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: a81a7552-7f2d-43d1-9c81-08d7005dce86 X-MS-Exchange-CrossTenant-originalarrivaltime: 04 Jul 2019 08:58:39.7259 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2362 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="iso-8859-1" Content-ID: <1269CC345B1FD143B9D8D1B938D3CF51@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Thu, Jul 04, 2019 at 10:33:55AM +0200, Laszlo Ersek wrote: > On 07/04/19 05:58, Gary Lin wrote: > > On Wed, Jul 03, 2019 at 09:49:26PM +0200, Laszlo Ersek wrote: > >> Hi Gary, > >> > >> On 07/03/19 12:22, Gary Lin wrote: > >>> DxeTpmMeasurementLib is only useful when TPM is enabled. > >>> > >>> Cc: Jordan Justen > >>> Cc: Laszlo Ersek > >>> Cc: Marc-Andr=E9 Lureau > >>> Cc: Stefan Berger > >>> Signed-off-by: Gary Lin > >>> --- > >>> OvmfPkg/OvmfPkgIa32.dsc | 10 +++++++--- > >>> OvmfPkg/OvmfPkgIa32X64.dsc | 10 +++++++--- > >>> OvmfPkg/OvmfPkgX64.dsc | 10 +++++++--- > >>> 3 files changed, 21 insertions(+), 9 deletions(-) > >> > >> This is a good patch, thank you for it. I see two opportunities for > >> improvement. > >> > >> (1) There's something weird going on with your newline characters. The > >> view I get (in both my INBOX and in my list folder) is identical to > >> mail-archive.com's view: > >> > >> http://mid.mail-archive.com/20190703102228.25441-1-glin@suse.com > >> > >> Can you double check your settings, please? > >> > > I didn't change my git settings except the mail server due to our > > recent server migration. Not sure if it's caused by the new mail server > > or not... >=20 > Not sure... your v2 on the list doesn't seem to suffer from this issue, > thankfully :) >=20 I actually strip CRs manually with dos2unix before sending the patch. It seems that my old server strip CRs automatically but the new server tends to keep it. When I viewed my first patch with mutt, the viewer ignored CRs so I didn't notice the newline problem. Then I sent the patch to a colleague who is using thunderbird, all CRs become LFs. This is really annoying :-( Gary Lin > >=20 > >> > >> (2) The commit message should be more convincing. How about this: > >> > > Will follow your suggestion to update the patch. > >=20 > > BTW, just found that there is a TPM2_ENABLE block below the > > SECURE_BOOT_ENABLE block. I'll move TpmMeasurementLib there to reduce > > the lines of change. >=20 > Good idea! >=20 > Thanks > Laszlo >=20