public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, lersek@redhat.com
Cc: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>,
	"Chao Zhang" <chao.b.zhang@intel.com>,
	"Imran Desai" <imran.desai@intel.com>,
	"Jian Wang" <jian.j.wang@intel.com>,
	"Jiewen Yao" <jiewen.yao@intel.com>,
	"Jordan Justen" <jordan.l.justen@intel.com>,
	"Liming Gao" <liming.gao@intel.com>,
	"Marc-André Lureau" <marcandre.lureau@redhat.com>,
	"Michael D Kinney" <michael.d.kinney@intel.com>,
	"Stefan Berger" <stefanb@linux.ibm.com>
Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches
Date: Thu, 4 Jul 2019 10:59:25 +0100	[thread overview]
Message-ID: <20190704095925.5egyvrrztdojqbeb@bivouac.eciton.net> (raw)
In-Reply-To: <20190704094624.21057-1-lersek@redhat.com>

On Thu, Jul 04, 2019 at 11:46:19AM +0200, Laszlo Ersek wrote:
> Repo:   https://github.com/lersek/edk2.git
> Branch: revert_unreviewed_bz1781
> 
> The MdePkg patch and the OvmfPkg patch committed for
> <https://bugzilla.tianocore.org/show_bug.cgi?id=1781> had not been
> reviewed appropriately, so they must be reverted. Due to the MdePkg
> patch being the basis of the entire series, the SecurityPkg patches in
> the middle have to be reverted as well. (Leif pointed out that at least
> some of the SecurityPkg patches were not reviewed *on the list* either,
> so there's that too.)
> 
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Imran Desai <imran.desai@intel.com>
> Cc: Jian Wang <jian.j.wang@intel.com>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Marc-André Lureau <marcandre.lureau@redhat.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Stefan Berger <stefanb@linux.ibm.com>
> 
> Thanks
> Laszlo
> 
> Laszlo Ersek (5):
>   Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe"
>   Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default"
>   Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest
>     algorithm"
>   Revert "SecurityPkg: introduce the SM3 digest algorithm"
>   Revert "MdePkg/Protocol/Hash: introduce GUID for SM3"

For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

>  MdePkg/Include/Protocol/Hash.h                                              |   5 -
>  OvmfPkg/OvmfPkgIa32.dsc                                                     |   2 -
>  OvmfPkg/OvmfPkgIa32X64.dsc                                                  |   2 -
>  OvmfPkg/OvmfPkgX64.dsc                                                      |   2 -
>  SecurityPkg/Include/Library/HashLib.h                                       |   1 -
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c                 | 150 --------------------
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf               |  41 ------
>  SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni               |  15 --
>  SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c |   1 -
>  SecurityPkg/SecurityPkg.dec                                                 |   5 +-
>  SecurityPkg/SecurityPkg.dsc                                                 |   3 -
>  11 files changed, 2 insertions(+), 225 deletions(-)
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf
>  delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni
> 
> -- 
> 2.19.1.3.g30247aa5d201
> 
> 
> 
> 

  parent reply	other threads:[~2019-07-04  9:59 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-04  9:46 [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches Laszlo Ersek
2019-07-04  9:46 ` [PATCH 1/5] Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe" Laszlo Ersek
2019-07-04  9:46 ` [PATCH 2/5] Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default" Laszlo Ersek
2019-07-04  9:46 ` [PATCH 3/5] Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest algorithm" Laszlo Ersek
2019-07-04  9:46 ` [PATCH 4/5] Revert "SecurityPkg: introduce " Laszlo Ersek
2019-07-04  9:46 ` [PATCH 5/5] Revert "MdePkg/Protocol/Hash: introduce GUID for SM3" Laszlo Ersek
2019-07-04  9:59 ` Leif Lindholm [this message]
2019-07-04 10:58 ` [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches Philippe Mathieu-Daudé
2019-07-04 16:05 ` Laszlo Ersek
2019-07-04 18:13   ` Philippe Mathieu-Daudé
2019-07-05  3:08   ` Wang, Jian J

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704095925.5egyvrrztdojqbeb@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox