From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=XZ+7rnKM; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by groups.io with SMTP; Thu, 04 Jul 2019 02:59:30 -0700 Received: by mail-wm1-f65.google.com with SMTP id s15so5458009wmj.3 for ; Thu, 04 Jul 2019 02:59:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=sTpuRI7NJL/x46Jn8NgCRMkd8nYbrgmHqX4uL7B1Pbo=; b=XZ+7rnKMFkCopGczROHLuOzncGQCgmU0l4nvIFiXcRb8ukKZwimvw7qRLbYv3GABmP 8tOLhT6fPs3c/EYijm6k3UJiMho2+a2efEB4fAPvav0N/QllxsXpXng1qcJp2QFfCBpU oXC90JYsB3urqnmtp/JLHpzy2HSWZW9z+HRQ4kD9MTE9kwCrR114vDzVqNWuIV4hUwhj hEIX4CONtvPgJ8X9Jau0J2WnbVXkFiIlOpio/ZSvz6QJsfIq33RhMzwl5WZHaLLrfJAi m2d0OKBvdRiJJfBKEtdffhoRCNVtz78NlLWIkMBa3E2weBIMyzDTeesdqQ48kieI81Ly sjqA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=sTpuRI7NJL/x46Jn8NgCRMkd8nYbrgmHqX4uL7B1Pbo=; b=hDiKvUeH6UakBr8JzzCJV9Gc5O+rHha8NYNWGg4YVvWi5CB75awTuuqrlsMn41hArb sl1HFvGJxrGslTORUYE/66uDjRkz1NXMzo1cWwCbT7a2lTc1MV9NCJgLpGMVeRQ6y/5j Kq0Fos9Q0J3UvF/ytd8gW0hZRcwjYnkrI5XJL/0SBocL80eoLnqFZqvkl4uKVBQIRKkl JeWZTVBJAX4L0uS34iboW1BZjnNkgip7EDXCfriDV+zzg/hZkPXbxK8rcpG0F+qKsTYn GO36ddHSWbW3ZiD8OjGkzEZHSt4Agfq3GYZAT5uKImIJ+q142bwSuTfp8xbjJHyXseoR aQOQ== X-Gm-Message-State: APjAAAVXzisksbixEe3jJspeCISL/Yq3QMIaJK1YEyeO6uXXRSjBx+4k 8f3e7YgP46xO0TCtz1m/7WtQudUNS9w= X-Google-Smtp-Source: APXvYqzdIhxXRe4Rf4XQgdQu4gggAIteU8ni7SOfdwKaCss6QX6hRMQxHJHiXb/h8rO+dxYilXrGUw== X-Received: by 2002:a1c:9c8a:: with SMTP id f132mr11857998wme.29.1562234368390; Thu, 04 Jul 2019 02:59:28 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id r16sm13916462wrr.42.2019.07.04.02.59.27 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 02:59:27 -0700 (PDT) Date: Thu, 4 Jul 2019 10:59:25 +0100 From: "Leif Lindholm" To: devel@edk2.groups.io, lersek@redhat.com Cc: Ard Biesheuvel , Chao Zhang , Imran Desai , Jian Wang , Jiewen Yao , Jordan Justen , Liming Gao , =?iso-8859-1?Q?Marc-Andr=E9?= Lureau , Michael D Kinney , Stefan Berger Subject: Re: [edk2-devel] [PATCH 0/5] MdePkg, SecurityPkg, OvmfPkg: revert unreviewed SM3 patches Message-ID: <20190704095925.5egyvrrztdojqbeb@bivouac.eciton.net> References: <20190704094624.21057-1-lersek@redhat.com> MIME-Version: 1.0 In-Reply-To: <20190704094624.21057-1-lersek@redhat.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Thu, Jul 04, 2019 at 11:46:19AM +0200, Laszlo Ersek wrote: > Repo: https://github.com/lersek/edk2.git > Branch: revert_unreviewed_bz1781 > > The MdePkg patch and the OvmfPkg patch committed for > had not been > reviewed appropriately, so they must be reverted. Due to the MdePkg > patch being the basis of the entire series, the SecurityPkg patches in > the middle have to be reverted as well. (Leif pointed out that at least > some of the SecurityPkg patches were not reviewed *on the list* either, > so there's that too.) > > Cc: Ard Biesheuvel > Cc: Chao Zhang > Cc: Imran Desai > Cc: Jian Wang > Cc: Jiewen Yao > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Liming Gao > Cc: Marc-André Lureau > Cc: Michael D Kinney > Cc: Stefan Berger > > Thanks > Laszlo > > Laszlo Ersek (5): > Revert "OvmfPkg: link SM3 support into Tcg2Pei and Tcg2Dxe" > Revert "SecurityPkg: set SM3 bit in TPM 2.0 hash mask by default" > Revert "SecurityPkg/HashLibBaseCryptoRouter: recognize the SM3 digest > algorithm" > Revert "SecurityPkg: introduce the SM3 digest algorithm" > Revert "MdePkg/Protocol/Hash: introduce GUID for SM3" For the series: Reviewed-by: Leif Lindholm > MdePkg/Include/Protocol/Hash.h | 5 - > OvmfPkg/OvmfPkgIa32.dsc | 2 - > OvmfPkg/OvmfPkgIa32X64.dsc | 2 - > OvmfPkg/OvmfPkgX64.dsc | 2 - > SecurityPkg/Include/Library/HashLib.h | 1 - > SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c | 150 -------------------- > SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf | 41 ------ > SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni | 15 -- > SecurityPkg/Library/HashLibBaseCryptoRouter/HashLibBaseCryptoRouterCommon.c | 1 - > SecurityPkg/SecurityPkg.dec | 5 +- > SecurityPkg/SecurityPkg.dsc | 3 - > 11 files changed, 2 insertions(+), 225 deletions(-) > delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.c > delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.inf > delete mode 100644 SecurityPkg/Library/HashInstanceLibSm3/HashInstanceLibSm3.uni > > -- > 2.19.1.3.g30247aa5d201 > > > >