From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=KtXn4WRi; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Thu, 04 Jul 2019 06:01:36 -0700 Received: by mail-wr1-f68.google.com with SMTP id n9so6590048wru.0 for ; Thu, 04 Jul 2019 06:01:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:content-transfer-encoding:in-reply-to :user-agent; bh=XRvJaXJTDqLBYLUQ2YU+w3S9RJzwmomaz1/XYKJXWik=; b=KtXn4WRinDhuMS8m8A3nM+XmgO5o60A52lyUURA2YmObjBxEI96+NTp5O9f4Mc3/zm dVXQNLsWlywcIST4ephsuKKwA1pugUEJ3E7XEamHDofqIgbDAJqIyRytcAfB1wI6cwEl PncImjgeIGD9ElxrxAW9+pGcOIfjdtLkQ/OLVI20Q/ANpcjY8J7dOlVkBxQRaUaj19rP 0SN616K/hs2AEtfpQ2IaG5FaPHrDU9ByzMeSZdfVnB/irS0h09Zup/ZKj0qYhDBLe/wR 4iv2n36ytYA7+mGd/j46Mnuiu63SlFZrLaFtURE5jQaBhg7Up0n1UbBEck/EnChLz347 X1kw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:content-transfer-encoding :in-reply-to:user-agent; bh=XRvJaXJTDqLBYLUQ2YU+w3S9RJzwmomaz1/XYKJXWik=; b=iAS2DdBbDAavBZOkWi2xxoBv8CcC3psAj1jUMFIKzyuv6qudOH9TWOlS1SC5l+diXU 47lXEG9w4IrpNRmiLbC8o5MQJn3+vdvCqb9kfZaQt2YjzaBQE+ZqiBNkTy5IYr+fDAn/ LvxlYUcAbaMEpx22c/Cepgl/jmYkwoAV8+4Dl+06xbISqxw8mGudgx2qj+uET4g1Jj+c 5RXsuvHO3p/gdrEfrD+R+S3nNb8dIT4nVudScs29LqpFnnok55r2H222otJ1X2XA/1nS Gaa37zb+WSoK7+uifJXY02/axnBmQoZrMJgpBn+FUXkUYmJay9zO4tNpA7cRBesBA8rY n/Kg== X-Gm-Message-State: APjAAAVDZyT876vpMyaiKM40V+HXx86rvBsvmoW8KyYsGU8/zIXm7/ot HUs2R7XeJ7c9tVmXBLDdY03JhQ== X-Google-Smtp-Source: APXvYqzg/JwUUr2/kTDuhbuuaYakcBzxFDjuz8Hb0a+zvLlG34hpSxmfIRYXmFf1dpcFGdyq1PHQ6A== X-Received: by 2002:adf:ed50:: with SMTP id u16mr21429075wro.108.1562245294892; Thu, 04 Jul 2019 06:01:34 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id w67sm7650010wma.24.2019.07.04.06.01.33 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 04 Jul 2019 06:01:33 -0700 (PDT) Date: Thu, 4 Jul 2019 14:01:32 +0100 From: "Leif Lindholm" To: =?utf-8?B?Q8WTdXI=?= Cc: devel@edk2.groups.io Subject: Re: [edk2-devel] [PATCH] EmbeddedPkg: Fix various typos Message-ID: <20190704130132.f56ssoz7d4womw2y@bivouac.eciton.net> References: <20190703153049.2ivog4miagwcj4xc@bivouac.eciton.net> <14374.1562173136075559995@groups.io> MIME-Version: 1.0 In-Reply-To: <14374.1562173136075559995@groups.io> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit On Wed, Jul 03, 2019 at 09:58:56AM -0700, Cœur wrote: > > Normally, we expect patches to be submitted via git send-email, as > > opposed to through the groups.io web interface (it introduces > > spectacular levels of corruption to the original patch). > > Hello Leif, and thank you for the message and the review. > > I wasn't able to configure ` git send-email ` with my provider > (GMX), and all the doc and support is in German... so basically I > only use emails through web interfaces. The instructions at https://forum.ubuntuusers.de/topic/git-send-email-smtp-konfiguration/ ought to work, without needing to understand anything except the command line instructions :) > I didn't know there was corruption through the web interface: I > thought the patch format was ASCII-friendly. > > If attachments are fine, then that will also be the easiest for me > in the future, as I won't need to copy-paste the content anymore. It's not ideal, but if the above doesn't work, I'm happy with it for simple things like spelling fixes. For functionality patches, I am much more likely to want to comment inline. > > so could you confirm whether you are happy to contribute these > > patches under BSD+Patent? > > Sure. I'm fine with any license with all my contributions; so > BSD+Patent it is for past and future patches on edk2. Well, not really required (or relevant, you could change your mind :) for future patches - just a sanity check this one. > Do I need to resubmit anything? Or is this declaration enough for > past emails on the mailing list? I think it is sufficient. I have deleted the Contributed-under tags from the ArmPkg, ArmPlatformPkg and EmbeddedPkg patches before pushing them as 080981d72dcb..c6a72cd79465 with my Reviewed-by: Leif Lindholm I will reply and cc the individual package maintainers on your other patches to make sure they notice them. > Actually, I can even share the whole 4000+ typos corrections ( > https://github.com/Coeur/edk2/commit/c2eed45a596b42768fe7916fb5491bfc1b9efe0c > ) as CC0 ( https://creativecommons.org/publicdomain/zero/1.0/deed ): > you can cherry pick from it anytime. I don't think there is any > intellectual property possible for spelling corrections anyway. Urgh, don't make me elaborate on the implications of public domain versus copyright... If you're interested, have a look at https://wiki.spdx.org/view/Legal_Team/Decisions/Dealing_with_Public_Domain_within_SPDX_Files Having the patches available in a publicly accessible git tree is however an excellent method to eliminate the problem of patches getting corrupted in transit. Out of interest - how did you find all these typos? I hope it was something at least semi-automated? Best Regards, Leif