public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: devel@edk2.groups.io, coeur@gmx.fr
Cc: Bob Feng <bob.c.feng@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH] BaseTools: Fix encoding typos
Date: Thu, 4 Jul 2019 14:07:14 +0100	[thread overview]
Message-ID: <20190704130713.sdwv42wqlfr6ieui@bivouac.eciton.net> (raw)
In-Reply-To: <21872.1561809723580988958@groups.io>

+Bob, Liming

Personally, I'm not sure what should be done here.
Normally for an imported piece of code, I would say "fix this
upstream", but Pccts is as far as I can tell _long_ dead.

On Sat, Jun 29, 2019 at 05:02:03AM -0700, Cœur wrote:
> Fix encoding typos in BaseTools by using UTF-8.
> 
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Coeur <coeur@gmx.fr>
> ---
> BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt
> index 4d84d1c19c..c3fcadfd59 100644
> --- a/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt
> +++ b/BaseTools/Source/C/VfrCompile/Pccts/CHANGES_FROM_133.txt
> @@ -40,7 +40,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS
> #309. (Changed in MR32) Renamed baseName because of VMS name conflict
> 
> Renamed baseName to pcctsBaseName to avoid library name conflict with
> -    VMS library routine.  Reported by Jean-FranÁois PI…RONNE.
> +    VMS library routine.  Reported by Jean-Fran√ßois PI√âRONNE.
> 
> #308. (Changed in MR32) Used "template" as name of formal in C routine
> 
> @@ -975,7 +975,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS
> 
> #249. (MR21) Changes for DEC/VMS systems
> 
> -    Jean-FranÁois PiÈronne (jfp altavista.net) has updated some
> +    Jean-Fran√ßois Pi√©ronne (jfp altavista.net) has updated some
> VMS related command files and fixed some minor problems related
> to building pccts under the DEC/VMS operating system.  For DEC/VMS
> users the most important differences are:
> @@ -1750,7 +1750,7 @@ List of Implemented Fixes and Changes for Maintenance Releases of PCCTS
> Under certain circumstances a predicate test could generate
> a #line directive which was not at column 1.
> 
> -      Reported with fix by David KÂgedal  (davidk lysator.liu.se)
> +      Reported with fix by David K√•gedal  (davidk lysator.liu.se)
> (http://www.lysator.liu.se/~davidk/).
> 
> #194. (Changed in MR14) (C Mode only) Demand lookahead with #tokclass
> --
> 2.20.1 (Apple Git-117)
> 
> 
> 

  parent reply	other threads:[~2019-07-04 13:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-29 12:02 [PATCH] BaseTools: Fix encoding typos Cœur
2019-06-29 12:04 ` [edk2-devel] " Cœur
2019-07-04 13:07 ` Leif Lindholm [this message]
2019-07-05  0:52   ` Bob Feng
2019-07-05 12:23     ` Cœur

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704130713.sdwv42wqlfr6ieui@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox