public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Wu, Hao A" <hao.a.wu@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>,
	"rfc@edk2.groups.io" <rfc@edk2.groups.io>
Subject: Re: [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64
Date: Thu, 4 Jul 2019 15:27:11 +0100	[thread overview]
Message-ID: <20190704142711.pz4eusiw3cg2f2g7@bivouac.eciton.net> (raw)
In-Reply-To: <B80AF82E9BFB8E4FBD8C89DA810C6A093C9026E0@SHSMSX104.ccr.corp.intel.com>

On Thu, Jul 04, 2019 at 06:14:04AM +0000, Wu, Hao A wrote:
> I do met a little problem that for a patch that touches multiple features,
> the contacts order in the output is not ideally perfect:
> 
> Content in Maintainers.txt:
> '''
> MdeModulePkg
> F: MdeModulePkg/
> W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg
> M: Jian J Wang <jian.j.wang@intel.com>
> M: Hao A Wu <hao.a.wu@intel.com>
> 
> F: MdeModulePkg/*Ufs*/
> R: Ufs Guy <ufs@test.com>
> 
> F: MdeModulePkg/Include/*Hii*.h
> F: MdeModulePkg/*Hii*/
> R: Hii Guy <hii@test.com>
> '''
> 
> Script output:
> '''
> $ py BaseTools/Scripts/GetMaintainer.py HEAD
> MdeModulePkg/Bus/Pci/UfsPciHcDxe/UfsPciHcDxe.inf
> MdeModulePkg/Universal/HiiDatabaseDxe/HiiDatabase.uni
>   Jian J Wang <jian.j.wang@intel.com>
>   Hao A Wu <hao.a.wu@intel.com>
>   Ufs Guy <ufs@test.com>
>   devel@edk2.groups.io
>   Hii Guy <hii@test.com>
> '''
> 
> The 'Hii Guy' is at the end of the list.

Totally agree. The idea was to keep the first revision simple.
Another thing missing (that I would argue is even more important than
listed order), is an indication of *why* said person is listed.

> But this is a rather minor problem and does not impact the use at all.

Good. I will respin the set based on Laszlo's feedback on previous
version and resubmit.

Best Regards,

Leif

  reply	other threads:[~2019-07-04 14:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-06-14 20:21 [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 Leif Lindholm
2019-06-20 15:29 ` [edk2-devel] " Laszlo Ersek
2019-06-20 16:07   ` Leif Lindholm
2019-07-03  7:52 ` Wu, Hao A
2019-07-03 10:44   ` Leif Lindholm
2019-07-04  6:14     ` Wu, Hao A
2019-07-04 14:27       ` Leif Lindholm [this message]
2019-07-03  7:53 ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190704142711.pz4eusiw3cg2f2g7@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox