From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: citrix.com, ip: 216.71.145.155, mailfrom: anthony.perard@citrix.com) Received: from esa3.hc3370-68.iphmx.com (esa3.hc3370-68.iphmx.com [216.71.145.155]) by groups.io with SMTP; Thu, 04 Jul 2019 07:58:41 -0700 Authentication-Results: esa3.hc3370-68.iphmx.com; dkim=none (message not signed) header.i=none; spf=None smtp.pra=anthony.perard@citrix.com; spf=Pass smtp.mailfrom=anthony.perard@citrix.com; spf=None smtp.helo=postmaster@mail.citrix.com Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of anthony.perard@citrix.com) identity=pra; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible Received-SPF: Pass (esa3.hc3370-68.iphmx.com: domain of anthony.perard@citrix.com designates 162.221.158.21 as permitted sender) identity=mailfrom; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="anthony.perard@citrix.com"; x-conformance=sidf_compatible; x-record-type="v=spf1"; x-record-text="v=spf1 ip4:209.167.231.154 ip4:178.63.86.133 ip4:195.66.111.40/30 ip4:85.115.9.32/28 ip4:199.102.83.4 ip4:192.28.146.160 ip4:192.28.146.107 ip4:216.52.6.88 ip4:216.52.6.188 ip4:162.221.158.21 ip4:162.221.156.83 ~all" Received-SPF: None (esa3.hc3370-68.iphmx.com: no sender authenticity information available from domain of postmaster@mail.citrix.com) identity=helo; client-ip=162.221.158.21; receiver=esa3.hc3370-68.iphmx.com; envelope-from="anthony.perard@citrix.com"; x-sender="postmaster@mail.citrix.com"; x-conformance=sidf_compatible IronPort-SDR: r9FwiRVwyiNuVwGckpLDiYkRTu+u8eVktrQjLscGfacuQVqlny5F60pJrvtzSKklIf2qrBCabj dLETNo5//5FuSuHA/RhyKoEzmVhIJ3D6mLPEBh876PP/UAISbHHH4ZNtw26WXOnP5h6qC69YvI eM8Ck5I8y1qPsgSsBm9PJw61pfP+Q2VZLTaBKGkG9dBaVI9Hf78A09b54ytMgFCod5EFAuGsxb pa8q23Wf5V0i8s9jRW5cjtal3PuUJcUbYAjADrRLFQ3+igTA1vMlr42OG+ywJI1wPY9mFywNvI OSo= X-SBRS: 2.7 X-MesageID: 2602754 X-Ironport-Server: esa3.hc3370-68.iphmx.com X-Remote-IP: 162.221.158.21 X-Policy: $RELAYED X-IronPort-AV: E=Sophos;i="5.63,451,1557201600"; d="scan'208";a="2602754" From: "Anthony PERARD" To: CC: , Ard Biesheuvel , Jordan Justen , Laszlo Ersek , Julien Grall , Anthony PERARD Subject: [PATCH v3 25/35] OvmfPkg/XenPlatformPei: Reserve VGA memory region, to boot Linux Date: Thu, 4 Jul 2019 15:42:23 +0100 Message-ID: <20190704144233.27968-26-anthony.perard@citrix.com> X-Mailer: git-send-email 2.22.0 In-Reply-To: <20190704144233.27968-1-anthony.perard@citrix.com> References: <20190704144233.27968-1-anthony.perard@citrix.com> MIME-Version: 1.0 Return-Path: anthony.perard@citrix.com Content-Transfer-Encoding: quoted-printable Content-Type: text/plain Linux panic if the VGA region isn't reserved. When Linux is booted on EFI system, it expects the memory at 0xa0000 to _not_ be conventional memory. Otherwise a variable isn't initialised properly and Linux panic when a virtual console/terminal is asked to be created. See for more detail: https://lists.xenproject.org/archives/html/xen-devel/2019-03/msg02139.html Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D1689 Signed-off-by: Anthony PERARD Acked-by: Laszlo Ersek --- Notes: v3: - fix commit message OvmfPkg/XenPlatformPei/Xen.c | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/OvmfPkg/XenPlatformPei/Xen.c b/OvmfPkg/XenPlatformPei/Xen.c index 62a2c3ed93..9866b7c212 100644 --- a/OvmfPkg/XenPlatformPei/Xen.c +++ b/OvmfPkg/XenPlatformPei/Xen.c @@ -291,6 +291,12 @@ XenPublishRamRegions ( Status =3D XenGetE820Map (&E820Map, &E820EntriesCount);=0D ASSERT_EFI_ERROR (Status);=0D =0D + AddMemoryBaseSizeHob (0, 0xA0000);=0D + //=0D + // Video memory + Legacy BIOS region, to allow Linux to boot.=0D + //=0D + AddReservedMemoryBaseSizeHob (0xA0000, BASE_1MB - 0xA0000, TRUE);=0D +=0D for (Index =3D 0; Index < E820EntriesCount; Index++) {=0D UINT64 Base;=0D UINT64 End;=0D @@ -304,6 +310,16 @@ XenPublishRamRegions ( Base =3D ALIGN_VALUE (Entry->BaseAddr, (UINT64)EFI_PAGE_SIZE);=0D End =3D (Entry->BaseAddr + Entry->Length) & ~(UINT64)EFI_PAGE_MASK;=0D =0D + //=0D + // Ignore the first 1MB, this is handled before the loop.=0D + //=0D + if (Base < BASE_1MB) {=0D + Base =3D BASE_1MB;=0D + }=0D + if (Base >=3D End) {=0D + continue;=0D + }=0D +=0D switch (Entry->Type) {=0D case EfiAcpiAddressRangeMemory:=0D AddMemoryRangeHob (Base, End);=0D --=20 Anthony PERARD