public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "devel@edk2.groups.io" <devel@edk2.groups.io>
Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed
Date: Fri, 5 Jul 2019 15:01:35 +0100	[thread overview]
Message-ID: <20190705140135.pblxlo6ajorwvslf@bivouac.eciton.net> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3007@SHSMSX104.ccr.corp.intel.com>

On Fri, Jul 05, 2019 at 01:41:54PM +0000, Gao, Liming wrote:
> Thanks for your catch. Yes. This is an issue. I will send the patch to clean it.
> 
> For this patch, the change is good. Reviewed-by: Liming Gao <liming.gao@intel.com>

Thanks!
Pushed as d031fc07eb83.

/
    Leif

> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Hiber He
> Sent: Friday, July 5, 2019 7:26 PM
> To: devel <devel@edk2.groups.io>; leif.lindholm <leif.lindholm@linaro.org>
> Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed
> 
> Hi,
> 
>     I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted.
> 
>    I deleted the ARCH related lines and it did built.
> 
> Best Regards,
> Hiber
> 
> 
> 
> On 07/05/2019 18:34, Leif Lindholm<mailto:leif.lindholm@linaro.org> wrote:
> Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool
> that is always built. Pre-existing tools locate the makefile includes
> with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency
> on having sourced edksetup.sh before building BaseTools.
> 
> Change FCE GNUmakefile to match other tools.
> 
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org<mailto:leif.lindholm@linaro.org>>
> ---
> 
> This broke our CI setup, so I'd appreciate if it could be merged quickly.
> 
> BaseTools/Source/C/FCE/GNUmakefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
> index 3e1b6a85e2..7a7e1ef4b8 100644
> --- a/BaseTools/Source/C/FCE/GNUmakefile
> +++ b/BaseTools/Source/C/FCE/GNUmakefile
> @@ -42,7 +42,7 @@ endif
> export ARCH
> export HOST_ARCH=$(ARCH)
> 
> -MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C
> +MAKEROOT ?= ..
> 
> APPNAME = FCE
> 
> --
> 2.11.0
> 
> 
> 

      reply	other threads:[~2019-07-05 14:01 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-05 10:34 [PATCH] BaseTools: fix FCE build when edksetup not executed Leif Lindholm
2019-07-05 11:26 ` [edk2-devel] " Hiber He
2019-07-05 13:41   ` Liming Gao
2019-07-05 14:01     ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190705140135.pblxlo6ajorwvslf@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox