From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=U1fMGKEl; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Fri, 05 Jul 2019 07:01:39 -0700 Received: by mail-wm1-f68.google.com with SMTP id l2so2203442wmg.0 for ; Fri, 05 Jul 2019 07:01:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=KBYCXKgv9FbXu/ynKPHWjN2NOjwfZGIRq9AwS/046pw=; b=U1fMGKEl84LKuWjoqoVSCHj+97Ep3kFpXzD68UZoG8JEeKstuIWHLaFp3VztwFS6wa aILbfoPhqg2DbEZxSrpyBqxhuImM8XyEeDaZljPQ+EP1tDDErd3OXBWoO1OoyjH2Vrmh ALnd8B0vRdko6FcxhrGIJQWf1UJ/iJEeX/qGwJyD8G6mVxjvYIRUoLRCrEd0jz09P920 j0r1FNbY35uj0RsZ2px5c2AR+yHolp0I2rfo28XdX9HCFHcaLBmTI7XI5/f3FD3ZRk9G g6Ey2d0WkrLbkqh8/uc02vn+iVrvKQRwL2OhddVwstOJLerGJtm9QPJbiVb4KWA7ORzM fwOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=KBYCXKgv9FbXu/ynKPHWjN2NOjwfZGIRq9AwS/046pw=; b=HKpUo6o0SZdOOfLCC9+2qWNfXbLTmC5QFjaw0a3UZOiCTZYjD5MZkic5VwdeXLDEXf 5B4StSDr8/jlGVuae3ktszNI+6Ni1fhD5ynAitvfiBBZ2zyX9q0ijJDadMUeRZk/9RH+ kKWIsRnrxAhdPey3XsaYQhkgblkrzWpvujIcyi12ZbskY6+1m+Hw4u6aRi9YC6qanpe1 WsqmxSFlGOkI/epGpqlLo+euNrXL9NhSsB45VYVIzJMN7L4R5Lz+o1CSM11U39rvmB1N +sK2KxJ4d8TG8Wi3L4Lhv7pFVsgICH9qp6Ch/FdPNCjfBK1s6RzysspHj8LN0/J6qJii iBkA== X-Gm-Message-State: APjAAAXKPHHoTuNNlIqI+9/TJNRJhdu1Y3uOqsU1IBKJVXKu2P+nEBtl Yus+nANy7kxhCQsDFDIWyCgkuw== X-Google-Smtp-Source: APXvYqzxbdVj/A9xQ2FVyGKrZC8F4Ar2cRishvjGLw4EMaXcxNDM4wXKZ8TAAwnEFO5grE1JQfMPKA== X-Received: by 2002:a7b:c00b:: with SMTP id c11mr3533348wmb.46.1562335297717; Fri, 05 Jul 2019 07:01:37 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id h11sm7914155wro.73.2019.07.05.07.01.36 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 05 Jul 2019 07:01:36 -0700 (PDT) Date: Fri, 5 Jul 2019 15:01:35 +0100 From: "Leif Lindholm" To: "Gao, Liming" Cc: "devel@edk2.groups.io" Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed Message-ID: <20190705140135.pblxlo6ajorwvslf@bivouac.eciton.net> References: <20190705103426.1423-1-leif.lindholm@linaro.org> <78ad489c.74f6.16bc1e2a34f.Coremail.hiberhe@163.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3007@SHSMSX104.ccr.corp.intel.com> MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E4A3007@SHSMSX104.ccr.corp.intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Fri, Jul 05, 2019 at 01:41:54PM +0000, Gao, Liming wrote: > Thanks for your catch. Yes. This is an issue. I will send the patch to clean it. > > For this patch, the change is good. Reviewed-by: Liming Gao Thanks! Pushed as d031fc07eb83. / Leif > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of Hiber He > Sent: Friday, July 5, 2019 7:26 PM > To: devel ; leif.lindholm > Subject: Re: [edk2-devel] [PATCH] BaseTools: fix FCE build when edksetup not executed > > Hi, > > I think the license of FCE is not correct(Should be BSD-2-Clause-Patent). And the logic for ARCH("ifndef ARCH") can be deleted. > > I deleted the ARCH related lines and it did built. > > Best Regards, > Hiber > > > > On 07/05/2019 18:34, Leif Lindholm wrote: > Commit 3c59d94637ad ("BaseTools/FCE: Add a tool FCE") added a new tool > that is always built. Pre-existing tools locate the makefile includes > with relative paths, but FCE uses EDK_TOOLS_PATH, adding a new dependency > on having sourced edksetup.sh before building BaseTools. > > Change FCE GNUmakefile to match other tools. > > Signed-off-by: Leif Lindholm > > --- > > This broke our CI setup, so I'd appreciate if it could be merged quickly. > > BaseTools/Source/C/FCE/GNUmakefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile > index 3e1b6a85e2..7a7e1ef4b8 100644 > --- a/BaseTools/Source/C/FCE/GNUmakefile > +++ b/BaseTools/Source/C/FCE/GNUmakefile > @@ -42,7 +42,7 @@ endif > export ARCH > export HOST_ARCH=$(ARCH) > > -MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C > +MAKEROOT ?= .. > > APPNAME = FCE > > -- > 2.11.0 > > >