From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.2.86, mailfrom: glin@suse.com) Received: from m4a0040g.houston.softwaregrp.com (m4a0040g.houston.softwaregrp.com [15.124.2.86]) by groups.io with SMTP; Mon, 08 Jul 2019 23:05:46 -0700 Received: FROM m4a0040g.houston.softwaregrp.com (15.120.17.147) BY m4a0040g.houston.softwaregrp.com WITH ESMTP; Tue, 9 Jul 2019 06:05:16 +0000 Received: from M4W0335.microfocus.com (2002:f78:1193::f78:1193) by M4W0335.microfocus.com (2002:f78:1193::f78:1193) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Tue, 9 Jul 2019 06:04:30 +0000 Received: from NAM02-SN1-obe.outbound.protection.outlook.com (15.124.8.10) by M4W0335.microfocus.com (15.120.17.147) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Tue, 9 Jul 2019 06:04:30 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB3164.namprd18.prod.outlook.com (10.255.172.93) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.19; Tue, 9 Jul 2019 06:04:29 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2052.020; Tue, 9 Jul 2019 06:04:29 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" , "michael.d.kinney@intel.com" CC: Yi Qian , Zailiang Sun Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Topic: [edk2-devel] [edk2-platforms Patch 00/14] Vlv2TbltDevicePkg: Remove Intel Framework dependencies Thread-Index: AQHVL7iX06GyMIyLl06arun+s2tcAqa1mg8AgADJVxCAASkWAIAAAA4QgABHQ+CAAOjugIAI9jzQgAAl4QA= Date: Tue, 9 Jul 2019 06:04:29 +0000 Message-ID: <20190709060418.GD5004@GaryWorkstation> References: <20190701025553.18596-1-michael.d.kinney@intel.com> <20190701040230.GA23179@GaryWorkstation> <20190702094812.GA32340@GaryWorkstation> <20190703035709.GB32340@GaryWorkstation> In-Reply-To: Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR06CA0007.eurprd06.prod.outlook.com (2603:10a6:6:1::20) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 39aa22ed-96c1-4350-b935-08d704334d94 x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB3164; x-ms-traffictypediagnostic: DM6PR18MB3164: x-ms-exchange-purlcount: 7 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:10000; x-forefront-prvs: 0093C80C01 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(396003)(136003)(346002)(376002)(39860400002)(366004)(199004)(51914003)(189003)(13464003)(66476007)(14444005)(66946007)(186003)(66556008)(30864003)(66446008)(256004)(73956011)(64756008)(11346002)(8936002)(53936002)(6116002)(71190400001)(6306002)(26005)(71200400001)(3846002)(68736007)(66066001)(6506007)(386003)(80792005)(19627235002)(54906003)(6512007)(52116002)(316002)(45954011)(25786009)(86362001)(2501003)(5660300002)(110136005)(102836004)(53546011)(1076003)(446003)(229853002)(6436002)(14454004)(33716001)(33656002)(6486002)(8676002)(99286004)(4326008)(486006)(2906002)(478600001)(9686003)(72206003)(76176011)(6246003)(7736002)(81166006)(966005)(81156014)(476003)(305945005)(21314003);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB3164;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: 5krIhOJr3Rv93IGghSmlTkgge5SouUBUaf9EFCrQvtQtvcksqAdpoigcibk+Lwfokz3HAmsjPgmchOM8wqcacQotjlOdRLBVI+dTSN0R+/GUutXJmqO6W4DFlC2fDqxeJR9Z+ja/tt52AUfRMZEoX6Q5/mpW7XutDVC6iVDDjORnPOX4lAqd+hmnGzVrcL6GqIInqz5i+5GYJyMiMWkH4FmGd56QiuPLQPyaFP5isvx6JLlWYQKZekuRitpgs1y3V6hpPsRiLtGmXqCPL6U3fos+0buNjz2Kk4/QaDUHRpKm0zVa9Jc8e3sfIHaEGin/u+NftM8dosu7Tfdj6aZLs5hhMxi4/FWtDy5kbGHMyhnzG1aI8CjOAchxjKsFA5C5hr1VavrxSSg596hCw3eznT4qNH5Vsis8hoGyA7XsD2o= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 39aa22ed-96c1-4350-b935-08d704334d94 X-MS-Exchange-CrossTenant-originalarrivaltime: 09 Jul 2019 06:04:29.1588 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB3164 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <4A6A591A6080CF4EB68A1D993AF58B11@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Tue, Jul 09, 2019 at 03:52:37AM +0000, Michael D Kinney wrote: > Hi Gary, >=20 Hi Mike, > I picked up the changes on your branch. I re-enabled the BIOS ID > Feature and added support for IA32 GCC builds, so the builds > available from Windows and Linux are matched now. >=20 > I have posted my updated branch here: >=20 > https://github.com/mdkinney/edk2-platforms/tree/Bug_xxx_Vlv2_Linux_And_S= mbios_Fixes_V2 >=20 > I also verified that the SD Card support does work, so I am > keeping that change. >=20 I tested the branch + my ASL workaround and booted into Linux successfully. > I agree the Readme is out of date. I will work on that and > add to the branch referenced above tomorrow. >=20 Thanks! Gary Lin > Thanks, >=20 > Mike >=20 > > -----Original Message----- > > From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] > > On Behalf Of Gary Lin > > Sent: Tuesday, July 2, 2019 8:57 PM > > To: Kinney, Michael D > > Cc: devel@edk2.groups.io; Qian, Yi ; > > Sun, Zailiang > > Subject: Re: [edk2-devel] [edk2-platforms Patch 00/14] > > Vlv2TbltDevicePkg: Remove Intel Framework dependencies > >=20 > > On Tue, Jul 02, 2019 at 09:11:06PM +0000, Kinney, > > Michael D wrote: > > > Hi Gary, > > > > > Hi Mike, > >=20 > > > I have posted an update to your patches the removes the > > setting of > > > WORKSPACE and accesses all files relative to WORKSPACE > > in the Linux shell scripts. > > > It also fixes null pointer bugs in the SmbiosMiscDxe > > module. > > > > > > https://github.com/mdkinney/edk2- > > platforms/tree/Bug_xxx_Vlv2_Linux_And > > > _Smbios_Fixes > > > > > > With these changes I can boot to the UEFI Shell and to > > Linux. Please > > > verify from your environments. > > > > > The fix for SmbiosMiscDxe works for me. Thanks for that! > >=20 > > I pushed another commit to my branch to check WORKSPACE > > to notify the > > user: > >=20 > > https://github.com/lcp/edk2- > > platforms/commit/fc530689e913e3de25ca2c553d616b9cef28901c > >=20 > > We probably have to update Readme.md later. It's already > > dated. > >=20 > > > I see you have added the SDMMC modules, but I do not > > see that peripheral yet. > > > That feature looks like it needs some more debug. We > > may need to back > > > out those changes for now. > > > > > I saw the SD card settings in the South Cluster > > Configuration menu even without those SDMMC modules, so > > they are probably from the edk2-non-osi drivers. However, > > the SD card didn't work until I added the drivers from > > MdeModulePkg, so I need those drivers at least for my > > Minnowboard Turbot. > >=20 > > Thanks, > >=20 > > Gary Lin > >=20 > > > I agree there are ASL issues. The ASL code needs to be > > updated to the > > > latest ASL compiler. > > > > > > Thanks, > > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Kinney, Michael D > > > > Sent: Tuesday, July 2, 2019 9:50 AM > > > > To: Gary Lin ; devel@edk2.groups.io; > > Kinney, Michael > > > > D > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > > > Subject: RE: [edk2-devel] [edk2-platforms Patch > > 00/14] > > > > Vlv2TbltDevicePkg: Remove Intel Framework > > dependencies > > > > > > > > Hi Gary, > > > > > > > > Thanks for the branch. I have the build working and > > have reproduced > > > > the SMBIOS issue and am debugging that now. > > > > > > > > Mike > > > > > > > > > -----Original Message----- > > > > > From: Gary Lin [mailto:GLin@suse.com] > > > > > Sent: Tuesday, July 2, 2019 2:48 AM > > > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch > > 00/14] > > > > > Vlv2TbltDevicePkg: Remove Intel Framework > > dependencies > > > > > > > > > > On Mon, Jul 01, 2019 at 11:07:11PM +0000, Michael > > D > > > > Kinney wrote: > > > > > > Hi Gary, > > > > > > > > > > > > I recommend you rebase on top of this series. > > > > > > > > > > > > I have verified Linux boots and I have been > > working > > > > on > > > > > the GCC and > > > > > > Linux build scripts as well. > > > > > > > > > > > > Please let me know if you see any issues with > > this > > > > > series applied and > > > > > > I can help get them fixed. > > > > > > > > > > > Hi Mike, > > > > > > > > > > I'm rebasing my patches and they are available in > > my > > > > > branch: > > > > > > > > > > https://github.com/lcp/edk2-platforms/commits/vlv2- > > > > > fixes-wip > > > > > > > > > > It's based on > > > > > edk2(dcce9cbd48e07fcd11f7ef34cad48faf7bb61e6e) > > > > > and edk2-non- > > > > > osi(de0a6bc19c4ee0468f04e4d37035cdc59558137f). > > > > > > > > > > There are 3 problems I currently encountered, and > > maybe > > > > you can give > > > > > me some suggestions. > > > > > > > > > > 1. Missing DSDT > > > > > > > > > > When compiling DSDT, iasl failed with this error: > > > > > > > > > > DSDT.iiii 6077: > > > > > Or(ShiftLeft(Derefof(Index(CDCT, > > > > > \_SB.PCI0.GFX0.MCHK.DCFE)), 21),PARM, PARM) > > > > > Error 6163 - > > > > > ^ Object is created temporarily in another method > > and > > > > cannot be > > > > > accessed (\_SB.PCI0.GFX0. MCHK.DCFE) > > > > > > > > > > The code is from > > > > > > > > > > > Silicon/Intel/Vlv2DeviceRefCodePkg/AcpiTablesPCAT/IgdOGB > > > > > DA.ASL > > > > > > > > > > I have to comment out the line or iasl won't > > generate > > > > the aml file and > > > > > the OS would fail to get DSDT. > > > > > > > > > > My acpica version is 20190509, and I vaguely > > remember > > > > that the older > > > > > acpica seems to be more tolerant to this error. > > > > > > > > > > 2. Crash at SMBIOS driver > > > > > > > > > > When booting the system, I got the following error: > > > > > > > > > > Loading driver at 0x00078DBA000 > > > > EntryPoint=3D0x00078DBEC3C > > > > > MiscSubclass.efi > > > > > InstallProtocolInterface: BC62157E-3E33-4FEC-9920- > > > > 2D3B36D750DF > > > > > 78FE8D18 ProtectUefiImageCommon - > > > > > 0x78FE8040 > > > > > - 0x0000000078DBA000 - 0x0000000000007B80 > > > > > PlatformInfoHob->BoardId [0xB0] > > > > > GetBiosVersionDateTime :MNW2MAX1.X64.0084.D01 > > > > 01/01/2019 > > > > > 00:00 > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to > > 32- > > > > bit table > > > > > SmbiosAdd: Smbios type 0 with size 0x48 is added to > > 64- > > > > bit table > > > > > SmbiosCreateTable: Initialize 32-bit entry point > > > > structure > > > > > SmbiosCreateTable() re-allocate SMBIOS 32-bit table > > > > > SmbiosCreateTable: Initialize 64-bit entry point > > > > structure > > > > > SmbiosCreate64BitTable() re-allocate SMBIOS 64-bit > > > > table Create Smbios > > > > > Manu callback. > > > > > !!!! X64 Exception Type - 06(#UD - Invalid Opcode) > > CPU > > > > Apic ID - > > > > > 00000000 !!!! > > > > > RIP - 0000000078DBEC26, CS - 0000000000000038, > > RFLAGS > > > > > - 0000000000010206 RAX - 0000000000000000, RCX - > > > > 000000007984A5A0, > > > > > RDX - 000000007A46E5FF RBX - 000000007A46E920, RSP > > - > > > > > 000000007A46E8B0, RBP - > > > > > 0000000078DC0EC0 RSI - 0000000000000012, RDI - > > > > > 0000000000000003 > > > > > R8 - 800000000000000E, R9 - 000000007A46E920, > > R10 - > > > > > 0000000078FE8398 > > > > > R11 - 0000000000000001, R12 - 0000000078FE8798, > > R13 - > > > > > 0000000078FE8898 > > > > > R14 - 0000000078FE8818, R15 - 000000007A46EC60 > > > > > DS - 0000000000000030, ES - 0000000000000030, FS > > - > > > > > 0000000000000030 > > > > > GS - 0000000000000030, SS - 0000000000000030 > > > > > CR0 - 0000000080010013, CR2 - 0000000000000000, > > CR3 - > > > > > 000000007A201000 > > > > > CR4 - 0000000000000628, CR8 - 0000000000000000 > > > > > DR0 - 0000000000000000, DR1 - 0000000000000000, > > DR2 - > > > > > 0000000000000000 > > > > > DR3 - 0000000000000000, DR6 - 00000000FFFF0FF8, > > DR7 - > > > > > 0000000000000400 GDTR - 0000000079FFDA98 > > > > 0000000000000047, LDTR - > > > > > 0000000000000000 > > > > > IDTR - 0000000079862018 0000000000000FFF, TR - > > > > > 0000000000000000 > > > > > FXSAVE_STATE - 000000007A46E510 > > > > > !!!! Find image based on IP(0x78DBEC26) > > > > > /home/gary/git/edk2- > > > > > > > > > > > workspace/Build/Vlv2TbltDevicePkg/DEBUG_GCC5/X64/Vlv2Tbl > > > > > > > > > > > tDevicePkg/SmBiosMiscDxe/SmBiosMiscDxe/DEBUG/MiscSubclas > > > > > s. > > > > > dll (ImageBase=3D0000000078DBA000, > > > > > EntryPoint=3D0000000078DBEC3C) !!!! > > > > > > > > > > I disaseembled MiscSubclass.debug and found that > > the > > > > address is a > > > > > "ud2" > > > > > instruction at > > > > > > > > > > > SmBiosMiscDxe/MiscBaseBoardManufacturerFunction.c:MiscBa > > > > > seBoardManufacturer() > > > > > > > > > > After adding a few more debug messages, the system > > > > crashed at another > > > > > function: > > > > > > > > > > > SmBiosMiscDxe/MiscSystemManufacturerFunction.c:AddSmbios > > > > > ManuCallback() > > > > > > > > > > If I added debug messages to both functions, the > > system > > > > booted > > > > > successfully. I currently didn't have any clue on > > this. > > > > > > > > > > 3. The firmware always booted into EFI shell. > > > > > > > > > > I guess something went wrong with BDS. I haven't > > looked > > > > into this > > > > > issue yet. > > > > > > > > > > Thanks, > > > > > > > > > > Gary Lin > > > > > > > > > > > Thanks, > > > > > > > > > > > > Mike > > > > > > > > > > > > > -----Original Message----- > > > > > > > From: Gary Lin [mailto:GLin@suse.com] > > > > > > > Sent: Sunday, June 30, 2019 9:04 PM > > > > > > > To: devel@edk2.groups.io; Kinney, Michael D > > > > > > > > > > > > > > Cc: Qian, Yi ; Sun, Zailiang > > > > > > > > > > > > > > Subject: Re: [edk2-devel] [edk2-platforms Patch > > > > > 00/14] > > > > > > > Vlv2TbltDevicePkg: Remove Intel Framework > > > > > dependencies > > > > > > > > > > > > > > On Sun, Jun 30, 2019 at 07:55:39PM -0700, > > Michael > > > > D > > > > > Kinney wrote: > > > > > > > > The following changes remove all dependencies > > on > > > > > the > > > > > > > IntelFrameworkPkg > > > > > > > > and IntelFrameworkModulePkg from the > > > > > Vlv2TbltDevicePkg > > > > > > > platform > > > > > > > > builds. These changes do depend on updates > > > > > binaries > > > > > > > on the edk2-non-osi repository. > > > > > > > > > > > > > > > Hi Michael, > > > > > > > > > > > > > > I am amending the bash scripts for gcc. The > > > > firmware > > > > > I built is > > > > > > > using the binaries from Development190216 and > > could > > > > > boot into Linux > > > > > > > successfully with some workarounds for Wpce791, > > > > Bds, > > > > > and > > > > > > > InteFspWrapper. The patches you posted > > eliminate > > > > > those parts I have > > > > > > > to work around. > > > > > > > > > > > > > > Just want to know if you need any assistance > > for > > > > the > > > > > gcc build? I > > > > > > > could rebase my work upon your patches and send > > > > them > > > > > later. > > > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > Gary Lin > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >=20 > >=20 >=20 >=20 >=20 >=20 >=20