From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Jian J Wang <jian.j.wang@intel.com>
Cc: devel@edk2.groups.io,
Michael D Kinney <michael.d.kinney@intel.com>,
Liming Gao <liming.gao@intel.com>
Subject: Re: [PATCH 2/2] CryptoPkg/OpensslLib: remove clone commands
Date: Tue, 9 Jul 2019 10:27:11 +0100 [thread overview]
Message-ID: <20190709092711.vxqc4tdcnvcf7vve@bivouac.eciton.net> (raw)
In-Reply-To: <20190709063601.7212-3-jian.j.wang@intel.com>
On Tue, Jul 09, 2019 at 02:36:01PM +0800, Jian J Wang wrote:
> https://bugzilla.tianocore.org/show_bug.cgi?id=1910
>
> edk2/Readme.md has added a section to explain the correct clone
> commands for submodules. Detailed steps in the OpenSSL-HOWTO.txt
> are removed to avoid any inconsistency.
>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Jian J Wang <jian.j.wang@intel.com>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt | 18 ++----------------
> 1 file changed, 2 insertions(+), 16 deletions(-)
>
> diff --git a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> index db45eb88d1..e52ee27b49 100644
> --- a/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> +++ b/CryptoPkg/Library/OpensslLib/OpenSSL-HOWTO.txt
> @@ -24,22 +24,8 @@ on the cryptography.
> =============================================================================
> HOW to Install OpenSSL for UEFI Building
> =============================================================================
> - OpenSSL repository was added as one submodule of EDKII project.
> -
> - The user can use the following commands to clone both main EDKII repo and
> -openssl submodule:
> - 1) Add the "--recursive" flag to the git clone command:
> - $ git clone --recursive https://github.com/tianocore/edk2
> -or
> - 2) Manually initialize and update the submodules after the clone operation
> - on main project:
> - $ git clone https://github.com/tianocore/edk2
> - $ git submodule update --init --recursive
> -
> - And use the following combined commands to pull the remote submodule updates
> -(e.g. Updating the new supported OpenSSL release tag):
> - $ git pull --recurse-submodules && \
> - git submodule update --recursive
> + OpenSSL repository was added as one submodule of EDKII project. Please
> +refer to edk2/Readme.md for how to clone the code.
>
> =============================================================================
> About process_files.pl
> --
> 2.17.1.windows.2
>
prev parent reply other threads:[~2019-07-09 9:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-09 6:35 [PATCH 0/2] Add edk2 submodule policy Wang, Jian J
2019-07-09 6:36 ` [PATCH 1/2] Readme.md: add submodule policy and clone commands Wang, Jian J
2019-07-09 9:26 ` Leif Lindholm
2019-07-10 1:50 ` Wang, Jian J
2019-07-09 6:36 ` [PATCH 2/2] CryptoPkg/OpensslLib: remove " Wang, Jian J
2019-07-09 9:27 ` Leif Lindholm [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190709092711.vxqc4tdcnvcf7vve@bivouac.eciton.net \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox