From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=ucWu8g/z; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Tue, 09 Jul 2019 02:28:04 -0700 Received: by mail-wr1-f68.google.com with SMTP id x4so20184883wrt.6 for ; Tue, 09 Jul 2019 02:28:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=bwjfZhK6Zssx5QpE7kvjjUH5Fbi+JJPPItjXmqja/3k=; b=ucWu8g/zjxg3klJOPF9vQmdUGM112gCqSooTNPOybLf/mkgIcijZALDRcWvVjeijQA p9bajfbyUvjEpfzgnlFUeN7yIIud8bdBO8HTpQF7DMkFytllnEJZNGbCYv9CO0UWQS3t n5JXIsXkDK4ckms6gsARnKihj+EGlqoXVA/LbK6MQ/3P+mFEbWaPIM/3TdwbAS4l+cJc dp6nPghbQVKxzLVqKC0/qNvlg9IJ8tk262vbLAw59cNutftH6B+vrOjqm09k7IBb8zNs BPPG+9QfHgF5S3wC2Tv6kWcpb+lLTJBlCEIVvKLafZi6DuStZ4hfZFBEdjti6U5jHZLR NN/Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=bwjfZhK6Zssx5QpE7kvjjUH5Fbi+JJPPItjXmqja/3k=; b=AkYkyVo3B+IDRxF2TWrmAnxtheYT5oRYEstVr9FqV01BhKc4bYsK183Rzn0BsgXKAt 8UJwCk7Wo/ygdE66Zpm61x9ZpnneawYOsrVeg274hyIzEC4Lah8SnxiIE5MiXIqoA2HL daL9wdO2kbiUwHc3nbhv0GW+qUv1JKtCcLDdgwDmEuKbFnuC8s+EZanhvEW/sTNKeYGK XKYc9RcYUrUstjKsqhFJoJRXWcJSTEstZ/8obeVmIuHCbeiW9BJboJL2Gv58Ne8Icyzs A0mxwJkX36bq6fLZG+hzUC5sRSLrXf/sWwqTN0Fa5uUaH0Sa4K41RyALQUA2svqdFtgu GhEg== X-Gm-Message-State: APjAAAWUkYoCSqcWpCb0OPE0CGgnNCjYtvrKS+2Rw/EJxvrSgVbFAv4X crTlg3OIWblT6y+SCcqoQXoacw== X-Google-Smtp-Source: APXvYqwORPZp3LIO6MGwyoD4wjj6r7qBmF6UFJpAQPNVIs6h9pw3J+dM1/6e7AOgF4oZxhRFIafQ/A== X-Received: by 2002:a5d:6650:: with SMTP id f16mr24892269wrw.89.1562664482767; Tue, 09 Jul 2019 02:28:02 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id y1sm1687744wma.32.2019.07.09.02.28.01 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Tue, 09 Jul 2019 02:28:02 -0700 (PDT) Date: Tue, 9 Jul 2019 10:28:00 +0100 From: "Leif Lindholm" To: Jian J Wang Cc: devel@edk2.groups.io, Ard Biesheuvel , Michael D Kinney , Liming Gao Subject: Re: [edk2-platforms: PATCH] Readme.md: Change way of cloning edk2 repo Message-ID: <20190709092800.vz5osqhm6w436pix@bivouac.eciton.net> References: <20190709072142.6500-1-jian.j.wang@intel.com> MIME-Version: 1.0 In-Reply-To: <20190709072142.6500-1-jian.j.wang@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Tue, Jul 09, 2019 at 03:21:42PM +0800, Jian J Wang wrote: > BZ: https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > '--recursive' in cloning edk2 repo might cause failure on machine > behind proxy. It's not actually necessary for edk2. This patch removed > it from git command. A separate command > > $ git submodule update --init > > is added to retrieve repo specified via submodule. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Cc: Michael D Kinney > Cc: Liming Gao > Signed-off-by: Jian J Wang Reviewed-by: Leif Lindholm Can you push it yourself, or would you like me to do it? > --- > Readme.md | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Readme.md b/Readme.md > index e203795d47..63e59f60b4 100644 > --- a/Readme.md > +++ b/Readme.md > @@ -83,7 +83,8 @@ target-specific binutils. These are included with any prepackaged GCC toolchain > 1. [edk2-non-osi](https://github.com/tianocore/edk2-non-osi) (if building > platforms that need it) > ``` > - $ git clone https://github.com/tianocore/edk2.git --recursive > + $ git clone https://github.com/tianocore/edk2.git > + $ git submodule update --init > ... > $ git clone https://github.com/tianocore/edk2-platforms.git > ... > -- > 2.17.1.windows.2 >