From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Kd6Bysue; spf=pass (domain: linaro.org, ip: 209.85.221.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f68.google.com (mail-wr1-f68.google.com [209.85.221.68]) by groups.io with SMTP; Wed, 10 Jul 2019 10:17:38 -0700 Received: by mail-wr1-f68.google.com with SMTP id z1so3264806wru.13 for ; Wed, 10 Jul 2019 10:17:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=Gtch5LIDepB0WCDnV5DyTgyc3i9Sn06jvY3MDDlhwm4=; b=Kd6Bysuev1aeqxmBGHPCZ0MqSNi70ElwiLaoF3Z7off10bRbDUfs1B22Py72zW1/WS /KHcNWTg6UHCwyAtuAM8Jgx+CxFOs0YE+wmLutIG44MJj8XIxeKWiSr7ICBz4xD/EHby txoZJviK2qEki7CYeMHoF2DegiyToOvPRHb5I80NqIODX+/IhV7dGL04yfwo1ohQvyd6 co5Mn0UElydR/i22oMH+xWCp0V0+fEK98r/8yeGKf5sSbtsUDOK7wZqbt4P2sAx+Htg1 LP0n5fq8eeO9+DKVhYjoxEHfMTQy47sjJcYr4m9ocK209G0BJYnIdiJxT8XuREcJd9An FkYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=Gtch5LIDepB0WCDnV5DyTgyc3i9Sn06jvY3MDDlhwm4=; b=CXWOIJqoNRMwqkot/jtmGd+1T+uOlkHfMsWBVdfH+W/DqQ0eYp0tSRb9Rr7KVSW6RD T4HCCw4oeouFBU7nW0KDiv5X24R8ecPbtKZKZAGepoqX9DpA1iR72DJuAtwpNgFFFmjE Kn3gEcWsifR5RQ31V3I1RlI2pTkPe54WPOt7bLmHqEtwyQ1iSXVbbhNFsNg2Z7iTBwi3 Vy41ltvM5jHzq1GwuScHwb3W2YwdBv9x4Gh0Z82Cwv4oCti6zfcqbnSu4ILeBj7cbH0k TwYbKb0DmeB4n2GQE18W4AyGZUVmy5uBPfzGc6YOpODvsinphzug4injv5XCBzgg+p7S 5zUg== X-Gm-Message-State: APjAAAUafPodYrFEEVe6wEFGevXfPNiUynGGR7NojaGzB8vNvivE8wO6 ldDwRqbCkPFdzhYebC3jM73ubA== X-Google-Smtp-Source: APXvYqxcUFuCIZm2KFJZBWGiTNLvO4L7yegHmhgGzD7EpTkrpvOyj0Ywl5y+bMsRNGBIwe9+a7iQZA== X-Received: by 2002:adf:9bcd:: with SMTP id e13mr1101924wrc.338.1562779056746; Wed, 10 Jul 2019 10:17:36 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id o11sm3102258wmh.37.2019.07.10.10.17.35 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jul 2019 10:17:36 -0700 (PDT) Date: Wed, 10 Jul 2019 18:17:34 +0100 From: "Leif Lindholm" To: "Kinney, Michael D" Cc: "Wang, Jian J" , "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Message-ID: <20190710171734.m36astajy7v55xur@bivouac.eciton.net> References: <20190710060955.7672-1-jian.j.wang@intel.com> <20190710060955.7672-2-jian.j.wang@intel.com> <20190710142629.aomcdzwvapo34k6c@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 10, 2019 at 05:08:32PM +0000, Kinney, Michael D wrote: > Leif, > > I think the following command has to be run from the git > dir that the edk2 repo was cloned into. > > $ git submodule update --init > > So I think the correct instructions would be: > > $ git clone https://github.com/tianocore/edk2.git > $ cd edk2 > $ git submodule update --init I only said I reviewed it, not that the review was correct ;) Yeah, good catch. I just mentally filtered out the clone bit. > $ cd .. Why would you want to leave? / Leif > Mike > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Wednesday, July 10, 2019 7:27 AM > > To: Wang, Jian J > > Cc: devel@edk2.groups.io; Kinney, Michael D > > ; Gao, Liming > > > > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > > policy and clone commands > > > > On Wed, Jul 10, 2019 at 02:09:54PM +0800, Jian J Wang > > wrote: > > > > v2: update wording per Leif's and others' comments > > > > Please drop the above line - version comments can go > > below the --- line, so they don't get included in the > > commit message. > > > > With that: > > Reviewed-by: Leif Lindholm > > > > (although Liming had some further feedback) > > > > > REF: > > https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > > > > > A section 'Submodules' is added to clarify the > > submodule policy in > > > edk2 repo. Git commands are also added to show the > > correct way to > > > clone submodule repos, in which '--recursive' is > > removed because it's > > > not needed but recommended in other document. > > > > > > Related commits: > > > Openssl-1.1.1b upgrade: > > acfb90911840c38a0beb9bcfe0065668244d2b4d > > > berkeley-softfloat-3: > > 3cc57695df5a6e8c65fb46b993836c315cabf49d > > > > > > Cc: Leif Lindholm > > > Cc: Michael D Kinney > > > Cc: Liming Gao > > > Signed-off-by: Jian J Wang > > > --- > > > Readme.md | 28 ++++++++++++++++++++++++++++ > > > 1 file changed, 28 insertions(+) > > > > > > diff --git a/Readme.md b/Readme.md > > > index e564c6c09b..c475468655 100644 > > > --- a/Readme.md > > > +++ b/Readme.md > > > @@ -143,3 +143,31 @@ Signed-off-by: Contributor Name > > > > > the change. Each line should be less than ~70 > > characters. > > > * `Signed-off-by` is the contributor's signature > > identifying them > > > by their real/legal name and their email address. > > > + > > > +# Submodules > > > + > > > +As a general policy, submodule chain should be avoided > > in EDK II repo > > > +as possible as we can. Currently EDK II contains two > > submodules > > > + > > > +- CryptoPkg/Library/OpensslLib/openssl > > > +- ArmPkg/Library/ArmSoftFloatLib/berkeley-softfloat-3 > > > + > > > +The latter one is actually required by previous one. > > It's inevitable > > > +in openssl-1.1.1 (since stable201905) for floating > > point parameter > > > +conversion, but should be dropped once there's no such > > need in future > > > +release of openssl. > > > + > > > +To get a full, buildable EDK II repository, use > > following two steps > > > +of git command > > > + > > > +``` > > > +$ git clone https://github.com/tianocore/edk2.git > > > +$ git submodule update --init> > +``` > > > + > > > +Note: When cloning submodule repos, '--recursive' > > option is not > > > +recommended. EDK II itself will not use any > > code/feature from > > > +submodules in above submodules. So using '--recursive' > > adds a > > > +dependency on being able to reach servers we do not > > actually want any > > > +code from, as well as needlessly downloading code we > > will not use. > > > -- > > > 2.17.1.windows.2 > > >