From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Jd4kYgHj; spf=pass (domain: linaro.org, ip: 209.85.128.68, mailfrom: leif.lindholm@linaro.org) Received: from mail-wm1-f68.google.com (mail-wm1-f68.google.com [209.85.128.68]) by groups.io with SMTP; Wed, 10 Jul 2019 10:30:28 -0700 Received: by mail-wm1-f68.google.com with SMTP id s3so3120560wms.2 for ; Wed, 10 Jul 2019 10:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=RRrkCGUB3UCH2M+vXxN7MyGi5H3BuZG3C28iFOImm9g=; b=Jd4kYgHjpwypZ/wlPlT/LnzBi0ofjvhGTe6DwyuvcK6XihjK4kYMgVle2tM7Ccoz1U kWBf5UDo5G3Uc6qgLMKS+/Wzb6b8562N8Q6kM3MuNbjt6lkM7zGljE4NcCmnOL96R965 4N7zwmCkok8OsP1LqGyvxzXF5kL516r0NVlV4XWeWIBE7uON+61qet8smBa5EjdVeceU U5cUqLB3yATyN/3ldD+300oyWPCXjqMYddpbkYwJIcTdBKK+6TSnhlsBlgudYervIWcw SeVn0ztFKyYOSw3I4ItIYInWxdwWVG3AWsdMyWvptmpZvOCsZSIoJoD2O2o76OPW8uAk 1aSw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=RRrkCGUB3UCH2M+vXxN7MyGi5H3BuZG3C28iFOImm9g=; b=DOx5YnUkXdfuCk8M1T63MCOfe+eHsHI4Bo9MKoJOqMGIfI4qqQ8fsiP1cwYFVqSnIe iW4/Wjhi6OvSqf+57iuqcI9bvodSP95QkBqG6fpSE2T7ZMTDIkJTIOC4CvygoDp/h3Ue FG7vW9epQwWSts4UNuo2TMiwTFsEbmjgAOeYAHQ2SkN5vwT+dz5MZSWrI9wvK1M1Qhkx u95a8Kkir7Sg2IjHwq/Ja2EVyk/VMk9r4UkyuwxvubZh2cAU3Dwl74poomjfsF+8Xszi 2WFF/mAZh1xjI8SpQSNhcJTWWnEFQQT3J8XfyaEwSJ9KGd4Jp1eT1xwAmDprpGOW9FZL X6eA== X-Gm-Message-State: APjAAAXtmTqBHwKMYtPE1QK9SoTS7vWtWWup9SiDoDiTUs7WvgExns0T hU++JPKw7iSKG3gxgdRne/ExGQ== X-Google-Smtp-Source: APXvYqzkWfW5wJEPMUsk/1LEG7v1cF3yDhanMRhkL/zUb6cI+pNit6eRaSgQVq2Hl6DQPu56w4CeEQ== X-Received: by 2002:a1c:cfc3:: with SMTP id f186mr5889403wmg.134.1562779827085; Wed, 10 Jul 2019 10:30:27 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id b2sm3362577wrp.72.2019.07.10.10.30.26 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 10 Jul 2019 10:30:26 -0700 (PDT) Date: Wed, 10 Jul 2019 18:30:25 +0100 From: "Leif Lindholm" To: "Kinney, Michael D" Cc: "Wang, Jian J" , "devel@edk2.groups.io" , "Gao, Liming" Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule policy and clone commands Message-ID: <20190710173025.jjshhvcudkcmylpe@bivouac.eciton.net> References: <20190710060955.7672-1-jian.j.wang@intel.com> <20190710060955.7672-2-jian.j.wang@intel.com> <20190710142629.aomcdzwvapo34k6c@bivouac.eciton.net> <20190710171734.m36astajy7v55xur@bivouac.eciton.net> MIME-Version: 1.0 In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Wed, Jul 10, 2019 at 05:28:27PM +0000, Kinney, Michael D wrote: > > > > -----Original Message----- > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > Sent: Wednesday, July 10, 2019 10:18 AM > > To: Kinney, Michael D > > Cc: Wang, Jian J ; > > devel@edk2.groups.io; Gao, Liming > > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > > policy and clone commands > > > > On Wed, Jul 10, 2019 at 05:08:32PM +0000, Kinney, Michael > > D wrote: > > > Leif, > > > > > > I think the following command has to be run from the > > git dir that the > > > edk2 repo was cloned into. > > > > > > $ git submodule update --init > > > > > > So I think the correct instructions would be: > > > > > > $ git clone https://github.com/tianocore/edk2.git > > > $ cd edk2 > > > $ git submodule update --init > > > > I only said I reviewed it, not that the review was > > correct ;) > > > > Yeah, good catch. I just mentally filtered out the clone > > bit. > > > > > $ cd .. > > > > Why would you want to leave? > > Because the commands the follow are more clone commands for > edk2-platforms and edk2-non-osi. Could move the submodule > init action for the edk2 repo after all the clone operations. OK then :) / Leif > > > > > / > > Leif > > > > > Mike > > > > > > > -----Original Message----- > > > > From: Leif Lindholm [mailto:leif.lindholm@linaro.org] > > > > Sent: Wednesday, July 10, 2019 7:27 AM > > > > To: Wang, Jian J > > > > Cc: devel@edk2.groups.io; Kinney, Michael D > > > > ; Gao, Liming > > > > > > Subject: Re: [ PATCH v2 1/2] Readme.md: add submodule > > policy and > > > > clone commands > > > > > > > > On Wed, Jul 10, 2019 at 02:09:54PM +0800, Jian J Wang > > > > wrote: > > > > > > v2: update wording per Leif's and others' > > comments > > > > > > > > Please drop the above line - version comments can go > > below the --- > > > > line, so they don't get included in the commit > > message. > > > > > > > > With that: > > > > Reviewed-by: Leif Lindholm > > > > > > > > (although Liming had some further feedback) > > > > > > > > > REF: > > > > https://bugzilla.tianocore.org/show_bug.cgi?id=1910 > > > > > > > > > > A section 'Submodules' is added to clarify the > > > > submodule policy in > > > > > edk2 repo. Git commands are also added to show the > > > > correct way to > > > > > clone submodule repos, in which '--recursive' is > > > > removed because it's > > > > > not needed but recommended in other document. > > > > > > > > > > Related commits: > > > > > Openssl-1.1.1b upgrade: > > > > acfb90911840c38a0beb9bcfe0065668244d2b4d > > > > > berkeley-softfloat-3: > > > > 3cc57695df5a6e8c65fb46b993836c315cabf49d > > > > > > > > > > Cc: Leif Lindholm > > > > > Cc: Michael D Kinney > > > > > Cc: Liming Gao > > > > > Signed-off-by: Jian J Wang > > > > > --- > > > > > Readme.md | 28 ++++++++++++++++++++++++++++ > > > > > 1 file changed, 28 insertions(+) > > > > > > > > > > diff --git a/Readme.md b/Readme.md index > > e564c6c09b..c475468655 > > > > > 100644 > > > > > --- a/Readme.md > > > > > +++ b/Readme.md > > > > > @@ -143,3 +143,31 @@ Signed-off-by: Contributor > > Name > > > > > > > > > the change. Each line should be less than ~70 > > > > characters. > > > > > * `Signed-off-by` is the contributor's signature > > > > identifying them > > > > > by their real/legal name and their email > > address. > > > > > + > > > > > +# Submodules > > > > > + > > > > > +As a general policy, submodule chain should be > > avoided > > > > in EDK II repo > > > > > +as possible as we can. Currently EDK II contains > > two > > > > submodules > > > > > + > > > > > +- CryptoPkg/Library/OpensslLib/openssl > > > > > +- ArmPkg/Library/ArmSoftFloatLib/berkeley- > > softfloat-3 > > > > > + > > > > > +The latter one is actually required by previous > > one. > > > > It's inevitable > > > > > +in openssl-1.1.1 (since stable201905) for floating > > > > point parameter > > > > > +conversion, but should be dropped once there's no > > such > > > > need in future > > > > > +release of openssl. > > > > > + > > > > > +To get a full, buildable EDK II repository, use > > > > following two steps > > > > > +of git command > > > > > + > > > > > +``` > > > > > +$ git clone https://github.com/tianocore/edk2.git > > > > > +$ git submodule update --init> > +``` > > > > > + > > > > > +Note: When cloning submodule repos, '--recursive' > > > > option is not > > > > > +recommended. EDK II itself will not use any > > > > code/feature from > > > > > +submodules in above submodules. So using '-- > > recursive' > > > > adds a > > > > > +dependency on being able to reach servers we do > > not > > > > actually want any > > > > > +code from, as well as needlessly downloading code > > we > > > > will not use. > > > > > -- > > > > > 2.17.1.windows.2 > > > > >