public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Liming Gao" <liming.gao@intel.com>
To: devel@edk2.groups.io
Cc: Leif Lindholm <leif.lindholm@linaro.org>,
	Feng Bob C <bob.c.feng@intel.com>
Subject: [Patch 4/7] Revert "BaseTools: fix FCE build when edksetup not executed"
Date: Thu, 11 Jul 2019 09:44:37 +0800	[thread overview]
Message-ID: <20190711014440.19812-5-liming.gao@intel.com> (raw)
In-Reply-To: <20190711014440.19812-1-liming.gao@intel.com>

This reverts commit d031fc07eb83c9d13bff3ebac25da458d5a47917.
There are the concerns on code design and code quality, and
request to rewrite FCE, BfmLib and FMMT for the review.

Cc: Leif Lindholm <leif.lindholm@linaro.org>
Cc: Feng Bob C <bob.c.feng@intel.com>
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 BaseTools/Source/C/FCE/GNUmakefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/BaseTools/Source/C/FCE/GNUmakefile b/BaseTools/Source/C/FCE/GNUmakefile
index 7a7e1ef4b8..3e1b6a85e2 100644
--- a/BaseTools/Source/C/FCE/GNUmakefile
+++ b/BaseTools/Source/C/FCE/GNUmakefile
@@ -42,7 +42,7 @@ endif
 export ARCH
 export HOST_ARCH=$(ARCH)
 
-MAKEROOT ?= ..
+MAKEROOT ?= $(EDK_TOOLS_PATH)/Source/C
 
 APPNAME = FCE
 
-- 
2.13.0.windows.1


  parent reply	other threads:[~2019-07-11  1:44 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  1:44 [Patch 0/7] Revert new added BfmLib/FCE/FMMT Liming Gao
2019-07-11  1:44 ` [Patch 1/7] Revert "BaseTools/FCE: Change FCE script type in PosixLike" Liming Gao
2019-07-11  1:44 ` [Patch 2/7] Revert "BaseTools/BfmLib: Change BfmLib " Liming Gao
2019-07-11  1:44 ` [Patch 3/7] Revert "BaseTools/FMMT: Change FMMT " Liming Gao
2019-07-11  1:44 ` Liming Gao [this message]
2019-07-11  1:44 ` [Patch 5/7] Revert "BaseTools/FMMT: Add a tool FMMT" Liming Gao
2019-07-11  1:44 ` [Patch 6/7] Revert "BaseTools/FCE: Add a tool FCE" Liming Gao
2019-07-11  1:44 ` [Patch 7/7] Revert "BaseTools/BfmLib: Add a tool BfmLib" Liming Gao
2019-07-11  1:50 ` [Patch 0/7] Revert new added BfmLib/FCE/FMMT Bob Feng
2019-07-11  8:46 ` Leif Lindholm

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711014440.19812-5-liming.gao@intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox