From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: suse.com, ip: 15.124.64.67, mailfrom: glin@suse.com) Received: from m9a0002g.houston.softwaregrp.com (m9a0002g.houston.softwaregrp.com [15.124.64.67]) by groups.io with SMTP; Wed, 10 Jul 2019 23:26:07 -0700 Received: FROM m9a0002g.houston.softwaregrp.com (15.121.0.191) BY m9a0002g.houston.softwaregrp.com WITH ESMTP; Thu, 11 Jul 2019 06:26:03 +0000 Received: from M9W0068.microfocus.com (2002:f79:bf::f79:bf) by M9W0068.microfocus.com (2002:f79:bf::f79:bf) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10; Thu, 11 Jul 2019 06:08:41 +0000 Received: from NAM03-BY2-obe.outbound.protection.outlook.com (15.124.72.13) by M9W0068.microfocus.com (15.121.0.191) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.1591.10 via Frontend Transport; Thu, 11 Jul 2019 06:08:41 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com (20.179.105.16) by DM6PR18MB2587.namprd18.prod.outlook.com (20.179.106.83) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.2052.18; Thu, 11 Jul 2019 06:08:39 +0000 Received: from DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0]) by DM6PR18MB2489.namprd18.prod.outlook.com ([fe80::ac83:47c9:cebd:9f0%7]) with mapi id 15.20.2052.020; Thu, 11 Jul 2019 06:08:39 +0000 From: "Gary Lin" To: "devel@edk2.groups.io" , "zailiang.sun@intel.com" CC: Michael D Kinney , Yi Qian Subject: Re: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM Thread-Topic: [edk2-devel] [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Create Vlv.ROM Thread-Index: AQHVN1KOaGxKPSO1SE+XxP5QLA9EVKbE2SKQgAAWVIA= Date: Thu, 11 Jul 2019 06:08:39 +0000 Message-ID: <20190711060827.GJ5004@GaryWorkstation> References: <20190710190516.6012-1-michael.d.kinney@intel.com> <20190710190516.6012-11-michael.d.kinney@intel.com> <7CB7EF03E15B5D48981329A508747A9850C95DEE@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <7CB7EF03E15B5D48981329A508747A9850C95DEE@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-TW, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-clientproxiedby: DB6PR07CA0181.eurprd07.prod.outlook.com (2603:10a6:6:42::11) To DM6PR18MB2489.namprd18.prod.outlook.com (2603:10b6:5:184::16) authentication-results: spf=none (sender IP is ) smtp.mailfrom=GLin@suse.com; x-ms-exchange-messagesentrepresentingtype: 1 x-originating-ip: [202.47.205.198] x-ms-publictraffictype: Email x-ms-office365-filtering-correlation-id: 56462894-7b1f-4042-e993-08d705c637cc x-microsoft-antispam: BCL:0;PCL:0;RULEID:(2390118)(7020095)(4652040)(8989299)(4534185)(4627221)(201703031133081)(201702281549075)(8990200)(5600148)(711020)(4605104)(1401327)(2017052603328)(7193020);SRVR:DM6PR18MB2587; x-ms-traffictypediagnostic: DM6PR18MB2587: x-ms-exchange-purlcount: 3 x-microsoft-antispam-prvs: x-ms-oob-tlc-oobclassifiers: OLM:4303; x-forefront-prvs: 0095BCF226 x-forefront-antispam-report: SFV:NSPM;SFS:(10019020)(7916004)(4636009)(376002)(396003)(366004)(39860400002)(136003)(346002)(13464003)(199004)(189003)(6436002)(66066001)(476003)(64756008)(6486002)(446003)(6116002)(3846002)(486006)(11346002)(19627235002)(229853002)(316002)(54906003)(110136005)(99286004)(6506007)(53546011)(102836004)(386003)(52116002)(76176011)(66476007)(66946007)(66556008)(66446008)(26005)(256004)(186003)(966005)(71190400001)(5660300002)(71200400001)(478600001)(81166006)(80792005)(33716001)(1076003)(81156014)(7736002)(6512007)(9686003)(6306002)(6246003)(2501003)(53936002)(33656002)(2906002)(25786009)(4326008)(8676002)(305945005)(86362001)(68736007)(8936002)(14454004);DIR:OUT;SFP:1102;SCL:1;SRVR:DM6PR18MB2587;H:DM6PR18MB2489.namprd18.prod.outlook.com;FPR:;SPF:None;LANG:en;PTR:InfoNoRecords;A:1;MX:1; received-spf: None (protection.outlook.com: suse.com does not designate permitted sender hosts) x-ms-exchange-senderadcheck: 1 x-microsoft-antispam-message-info: BpejR6FMjpX8jVf/zPoGwgAaQvuLQGqbFb2WivxaeGvi5ovdvHz3U3cYs7vYrQx0o2tkl2Wk4Sr/8OOYk08IV92MvitWKA+aBUTUFwXer8CpkONPWoaLb75A5xXsj+NvOKzoNvR8/MbrnrVsp+KU52PfU2IipU92mhD4xBVnl0toQqxqHm3Zd2MMPX8nN06l5hpvgCDyNCfLYd7lScxi03+2yMUtEufHLeC3nT9Wb9GYGv2lb5Bezar+DpDu+dkdjabHx3WB1TK1w/KTqQnP6VNDMPFfbIXhOpz+qrJdgkqtDmt1u2Q32HLQKPODaiud/26oKCcVnPCOCznDaJkDeelHTSz1s2kqGOP+87QBYoR8w7LRu/J8WDuUWNbU+NDCw8uym5JhLnSPrJXlRwD3rcCApETxMEa36jMPxSn0otw= MIME-Version: 1.0 X-MS-Exchange-CrossTenant-Network-Message-Id: 56462894-7b1f-4042-e993-08d705c637cc X-MS-Exchange-CrossTenant-originalarrivaltime: 11 Jul 2019 06:08:39.6952 (UTC) X-MS-Exchange-CrossTenant-fromentityheader: Hosted X-MS-Exchange-CrossTenant-id: 856b813c-16e5-49a5-85ec-6f081e13b527 X-MS-Exchange-CrossTenant-mailboxtype: HOSTED X-MS-Exchange-CrossTenant-userprincipalname: GLin@suse.com X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR18MB2587 Return-Path: GLin@suse.com X-OriginatorOrg: suse.com Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-ID: <8BDF606E5B44B44882496BA5655B4D7C@namprd18.prod.outlook.com> Content-Transfer-Encoding: quoted-printable On Thu, Jul 11, 2019 at 04:52:10AM +0000, Sun, Zailiang wrote: > Gary, >=20 > I suggest remove the first line "From: Gary Lin " from th= e description section since you have appended the "signed-off-by" declarati= on. >=20 Hi Zailiang, That is added by Mike. I'm totally fine if you remove it when pushing the commits. Thanks, Gary Lin > > -----Original Message----- > > From: Kinney, Michael D > > Sent: Thursday, July 11, 2019 3:05 AM > > To: devel@edk2.groups.io > > Cc: Gary Lin ; Sun, Zailiang ; = Qian, > > Yi > > Subject: [edk2-platforms Patch 10/28] Vlv2TbltDevicePkg/bld_vlv.sh: Cr= eate > > Vlv.ROM > >=20 > > From: Gary Lin > >=20 > > The scripts for PlatformCapsuleGcc.dsc need Vlv.ROM. > >=20 > > Cc: Zailiang Sun > > Cc: Yi Qian > > Cc: Michael D Kinney > > Signed-off-by: Gary Lin > > --- > > Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh | 2 ++ > > 1 file changed, 2 insertions(+) > >=20 > > diff --git a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > index 7fd5f44264..c68e59398a 100755 > > --- a/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > +++ b/Platform/Intel/Vlv2TbltDevicePkg/bld_vlv.sh > > @@ -199,6 +199,8 @@ echo Skip "Running fce..." > >=20 > > ##******************************************************** > > ************** > > ## Build Capsules > >=20 > > ##******************************************************** > > ************** > > +cp -f > > $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN_TAG}/F > > V/VLV.fd \ > > + > > $WORKSPACE/Build/Vlv2TbltDevicePkg/${TARGET}_${TOOL_CHAIN_TAG}/F > > V/Vlv.ROM > > build -p $PLATFORM_PKG_PATH/PlatformCapsuleGcc.dsc > >=20 > > echo > > -- > > 2.21.0.windows.1 >=20 >=20 >=20 >=20 >=20