public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Leif Lindholm" <leif.lindholm@linaro.org>
To: Liming Gao <liming.gao@intel.com>
Cc: devel@edk2.groups.io, Feng Bob C <bob.c.feng@intel.com>
Subject: Re: [Patch 0/7] Revert new added BfmLib/FCE/FMMT
Date: Thu, 11 Jul 2019 09:46:08 +0100	[thread overview]
Message-ID: <20190711084608.6o6ss6tnjofvlg36@bivouac.eciton.net> (raw)
In-Reply-To: <20190711014440.19812-1-liming.gao@intel.com>

On Thu, Jul 11, 2019 at 09:44:33AM +0800, Liming Gao wrote:
> Rewrite those tools for review again.
> Now, move them into edk2-staging/FceFmmt branch.
> 
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Feng Bob C <bob.c.feng@intel.com>

Thanks for this. For the series:
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>

> Liming Gao (7):
>   Revert "BaseTools/FCE: Change FCE script type in PosixLike"
>   Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike"
>   Revert "BaseTools/FMMT: Change FMMT script type in PosixLike"
>   Revert "BaseTools: fix FCE build when edksetup not executed"
>   Revert "BaseTools/FMMT: Add a tool FMMT"
>   Revert "BaseTools/FCE: Add a tool FCE"
>   Revert "BaseTools/BfmLib: Add a tool BfmLib"
> 
>  BaseTools/Source/C/BfmLib/BfmLib.c                 | 4355 -------------
>  BaseTools/Source/C/BfmLib/BinFileManager.c         | 1024 ----
>  BaseTools/Source/C/FCE/BinaryCreate.c              |  216 -
>  BaseTools/Source/C/FCE/BinaryParse.c               | 1326 ----
>  BaseTools/Source/C/FCE/Common.c                    | 2183 -------
>  BaseTools/Source/C/FCE/Expression.c                | 2367 -------
>  BaseTools/Source/C/FCE/Fce.c                       | 6449 --------------------
>  BaseTools/Source/C/FCE/IfrParse.c                  | 4836 ---------------
>  BaseTools/Source/C/FCE/MonotonicBasedVariable.c    |  874 ---
>  BaseTools/Source/C/FCE/TimeBasedVariable.c         |  878 ---
>  BaseTools/Source/C/FCE/Variable.c                  | 1091 ----
>  BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2559 --------
>  BaseTools/Source/C/FMMT/FmmtLib.c                  | 5051 ---------------
>  BaseTools/Source/C/FMMT/Rebase.c                   |  846 ---
>  BaseTools/BinWrappers/PosixLike/BfmLib             |   29 -
>  BaseTools/BinWrappers/PosixLike/FCE                |   29 -
>  BaseTools/BinWrappers/PosixLike/FMMT               |   29 -
>  BaseTools/Source/C/BfmLib/BinFileManager.h         |  439 --
>  BaseTools/Source/C/BfmLib/GNUmakefile              |   15 -
>  BaseTools/Source/C/BfmLib/Makefile                 |   17 -
>  BaseTools/Source/C/FCE/BinaryCreate.h              |  157 -
>  BaseTools/Source/C/FCE/BinaryParse.h               |  187 -
>  BaseTools/Source/C/FCE/Common.h                    |  999 ---
>  BaseTools/Source/C/FCE/Fce.h                       |  447 --
>  BaseTools/Source/C/FCE/GNUmakefile                 |   55 -
>  BaseTools/Source/C/FCE/IfrParse.h                  |  789 ---
>  BaseTools/Source/C/FCE/Makefile                    |   19 -
>  BaseTools/Source/C/FCE/MonotonicBasedVariable.h    |  162 -
>  BaseTools/Source/C/FCE/TimeBasedVariable.h         |  166 -
>  BaseTools/Source/C/FCE/Variable.h                  |  154 -
>  BaseTools/Source/C/FCE/VariableCommon.h            |   55 -
>  BaseTools/Source/C/FMMT/FirmwareModuleManagement.h |  479 --
>  BaseTools/Source/C/FMMT/FmmtConf.ini               |    6 -
>  BaseTools/Source/C/FMMT/GNUmakefile                |   16 -
>  BaseTools/Source/C/FMMT/Makefile                   |   17 -
>  BaseTools/Source/C/FMMT/Rebase.h                   |   31 -
>  BaseTools/Source/C/GNUmakefile                     |    5 +-
>  BaseTools/Source/C/Makefile                        |    5 +-
>  38 files changed, 2 insertions(+), 38360 deletions(-)
>  delete mode 100644 BaseTools/Source/C/BfmLib/BfmLib.c
>  delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.c
>  delete mode 100644 BaseTools/Source/C/FCE/Common.c
>  delete mode 100644 BaseTools/Source/C/FCE/Expression.c
>  delete mode 100644 BaseTools/Source/C/FCE/Fce.c
>  delete mode 100644 BaseTools/Source/C/FCE/IfrParse.c
>  delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.c
>  delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c
>  delete mode 100644 BaseTools/Source/C/FCE/Variable.c
>  delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c
>  delete mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c
>  delete mode 100644 BaseTools/Source/C/FMMT/Rebase.c
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/BfmLib
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/FCE
>  delete mode 100755 BaseTools/BinWrappers/PosixLike/FMMT
>  delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h
>  delete mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/BfmLib/Makefile
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h
>  delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.h
>  delete mode 100644 BaseTools/Source/C/FCE/Common.h
>  delete mode 100644 BaseTools/Source/C/FCE/Fce.h
>  delete mode 100644 BaseTools/Source/C/FCE/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/FCE/IfrParse.h
>  delete mode 100644 BaseTools/Source/C/FCE/Makefile
>  delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.h
>  delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h
>  delete mode 100644 BaseTools/Source/C/FCE/Variable.h
>  delete mode 100644 BaseTools/Source/C/FCE/VariableCommon.h
>  delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h
>  delete mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini
>  delete mode 100644 BaseTools/Source/C/FMMT/GNUmakefile
>  delete mode 100644 BaseTools/Source/C/FMMT/Makefile
>  delete mode 100644 BaseTools/Source/C/FMMT/Rebase.h
> 
> -- 
> 2.13.0.windows.1
> 

      parent reply	other threads:[~2019-07-11  8:46 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-07-11  1:44 [Patch 0/7] Revert new added BfmLib/FCE/FMMT Liming Gao
2019-07-11  1:44 ` [Patch 1/7] Revert "BaseTools/FCE: Change FCE script type in PosixLike" Liming Gao
2019-07-11  1:44 ` [Patch 2/7] Revert "BaseTools/BfmLib: Change BfmLib " Liming Gao
2019-07-11  1:44 ` [Patch 3/7] Revert "BaseTools/FMMT: Change FMMT " Liming Gao
2019-07-11  1:44 ` [Patch 4/7] Revert "BaseTools: fix FCE build when edksetup not executed" Liming Gao
2019-07-11  1:44 ` [Patch 5/7] Revert "BaseTools/FMMT: Add a tool FMMT" Liming Gao
2019-07-11  1:44 ` [Patch 6/7] Revert "BaseTools/FCE: Add a tool FCE" Liming Gao
2019-07-11  1:44 ` [Patch 7/7] Revert "BaseTools/BfmLib: Add a tool BfmLib" Liming Gao
2019-07-11  1:50 ` [Patch 0/7] Revert new added BfmLib/FCE/FMMT Bob Feng
2019-07-11  8:46 ` Leif Lindholm [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190711084608.6o6ss6tnjofvlg36@bivouac.eciton.net \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox