From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=NtlL0a/P; spf=pass (domain: linaro.org, ip: 209.85.221.53, mailfrom: leif.lindholm@linaro.org) Received: from mail-wr1-f53.google.com (mail-wr1-f53.google.com [209.85.221.53]) by groups.io with SMTP; Thu, 11 Jul 2019 01:46:12 -0700 Received: by mail-wr1-f53.google.com with SMTP id r1so5314691wrl.7 for ; Thu, 11 Jul 2019 01:46:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=+MiXMmNY+TszehG9M6IygvZf0Sao0NoKVCx8izBBacU=; b=NtlL0a/PmmEd2AAXdhAeasby+SSyS6U27ZZmg/+4L7Rdl2Bj4jAPfPZwjviVkLOrzd kWxk/5sXI0vzmMvXPVYCN1M2ghIID7FBg8nl/c6n3abP2dvWJmfMjcar7WDt4pdpoEoP wzNpBQ0Z37PQMy73WqnR8PrVXAwi0cZ9uK5Er4uhpsJMswm63BhXVJLF4//dG3/SYs6X N2iCuPp3ctyYTVYHI3aGZzJ1gku0mHrGt4fgr6fCAJWueV2g9Q08QCxxzPTDhL1QByt/ B4nR2kJFAdOKF3YJWG/oB7qrqktCZZJeGQjwJI2RMN4Z5qKDvkX+IHIGm8WME9szc2/v 2Slw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=+MiXMmNY+TszehG9M6IygvZf0Sao0NoKVCx8izBBacU=; b=bLwzYs3VnUbPQF4Ln2gcitGSGChfrHeumGxBD+SuS0y73aUZZGdzgn2884atoDm50Z 6STnqDxl4CPwKrgNWmemYy8uOTwe8/43kZ/Yj6ikU8QISAm2TErwGfrv5LNNq66GXsIw YOa3ksTghb+mIS65E8cJDxFlPP8/GjZlo1dqDsWw6WmI62X6OHvrnceuLf/WJwejUOVC vKAuytzeYzPIS4w+pcVMWf/w/QNBFTUWF/VhEOKw5B4S/SaUMeOdQFj7JIeubZr8BEoi GtFSgKx+OoTh+0mt80tIZoLH17G76nK0Fdv0UpDs8QrCCRW3Z3vzIUOkKx4y3u6a30Ha e18A== X-Gm-Message-State: APjAAAUrsMvaGC6YO/zHGA/vC4Zh+fLoBOANN8EX+Wo5LyJks2jLx9kp Bw2AvPS1FUYg+LYQp5oEsOlwYg== X-Google-Smtp-Source: APXvYqyUNvWzSCQbGsqvgllw8rnDUC0bWt2srfPc3aeYSmyCRO6jhMOrZCjhWr6bHfitKT8p4fzzaw== X-Received: by 2002:a5d:6783:: with SMTP id v3mr3599505wru.318.1562834770321; Thu, 11 Jul 2019 01:46:10 -0700 (PDT) Return-Path: Received: from bivouac.eciton.net (bivouac.eciton.net. [2a00:1098:0:86:1000:23:0:2]) by smtp.gmail.com with ESMTPSA id f70sm4874734wme.22.2019.07.11.01.46.09 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 11 Jul 2019 01:46:09 -0700 (PDT) Date: Thu, 11 Jul 2019 09:46:08 +0100 From: "Leif Lindholm" To: Liming Gao Cc: devel@edk2.groups.io, Feng Bob C Subject: Re: [Patch 0/7] Revert new added BfmLib/FCE/FMMT Message-ID: <20190711084608.6o6ss6tnjofvlg36@bivouac.eciton.net> References: <20190711014440.19812-1-liming.gao@intel.com> MIME-Version: 1.0 In-Reply-To: <20190711014440.19812-1-liming.gao@intel.com> User-Agent: NeoMutt/20170113 (1.7.2) Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Jul 11, 2019 at 09:44:33AM +0800, Liming Gao wrote: > Rewrite those tools for review again. > Now, move them into edk2-staging/FceFmmt branch. > > Cc: Leif Lindholm > Cc: Feng Bob C Thanks for this. For the series: Reviewed-by: Leif Lindholm > Liming Gao (7): > Revert "BaseTools/FCE: Change FCE script type in PosixLike" > Revert "BaseTools/BfmLib: Change BfmLib script type in PosixLike" > Revert "BaseTools/FMMT: Change FMMT script type in PosixLike" > Revert "BaseTools: fix FCE build when edksetup not executed" > Revert "BaseTools/FMMT: Add a tool FMMT" > Revert "BaseTools/FCE: Add a tool FCE" > Revert "BaseTools/BfmLib: Add a tool BfmLib" > > BaseTools/Source/C/BfmLib/BfmLib.c | 4355 ------------- > BaseTools/Source/C/BfmLib/BinFileManager.c | 1024 ---- > BaseTools/Source/C/FCE/BinaryCreate.c | 216 - > BaseTools/Source/C/FCE/BinaryParse.c | 1326 ---- > BaseTools/Source/C/FCE/Common.c | 2183 ------- > BaseTools/Source/C/FCE/Expression.c | 2367 ------- > BaseTools/Source/C/FCE/Fce.c | 6449 -------------------- > BaseTools/Source/C/FCE/IfrParse.c | 4836 --------------- > BaseTools/Source/C/FCE/MonotonicBasedVariable.c | 874 --- > BaseTools/Source/C/FCE/TimeBasedVariable.c | 878 --- > BaseTools/Source/C/FCE/Variable.c | 1091 ---- > BaseTools/Source/C/FMMT/FirmwareModuleManagement.c | 2559 -------- > BaseTools/Source/C/FMMT/FmmtLib.c | 5051 --------------- > BaseTools/Source/C/FMMT/Rebase.c | 846 --- > BaseTools/BinWrappers/PosixLike/BfmLib | 29 - > BaseTools/BinWrappers/PosixLike/FCE | 29 - > BaseTools/BinWrappers/PosixLike/FMMT | 29 - > BaseTools/Source/C/BfmLib/BinFileManager.h | 439 -- > BaseTools/Source/C/BfmLib/GNUmakefile | 15 - > BaseTools/Source/C/BfmLib/Makefile | 17 - > BaseTools/Source/C/FCE/BinaryCreate.h | 157 - > BaseTools/Source/C/FCE/BinaryParse.h | 187 - > BaseTools/Source/C/FCE/Common.h | 999 --- > BaseTools/Source/C/FCE/Fce.h | 447 -- > BaseTools/Source/C/FCE/GNUmakefile | 55 - > BaseTools/Source/C/FCE/IfrParse.h | 789 --- > BaseTools/Source/C/FCE/Makefile | 19 - > BaseTools/Source/C/FCE/MonotonicBasedVariable.h | 162 - > BaseTools/Source/C/FCE/TimeBasedVariable.h | 166 - > BaseTools/Source/C/FCE/Variable.h | 154 - > BaseTools/Source/C/FCE/VariableCommon.h | 55 - > BaseTools/Source/C/FMMT/FirmwareModuleManagement.h | 479 -- > BaseTools/Source/C/FMMT/FmmtConf.ini | 6 - > BaseTools/Source/C/FMMT/GNUmakefile | 16 - > BaseTools/Source/C/FMMT/Makefile | 17 - > BaseTools/Source/C/FMMT/Rebase.h | 31 - > BaseTools/Source/C/GNUmakefile | 5 +- > BaseTools/Source/C/Makefile | 5 +- > 38 files changed, 2 insertions(+), 38360 deletions(-) > delete mode 100644 BaseTools/Source/C/BfmLib/BfmLib.c > delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.c > delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.c > delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.c > delete mode 100644 BaseTools/Source/C/FCE/Common.c > delete mode 100644 BaseTools/Source/C/FCE/Expression.c > delete mode 100644 BaseTools/Source/C/FCE/Fce.c > delete mode 100644 BaseTools/Source/C/FCE/IfrParse.c > delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.c > delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.c > delete mode 100644 BaseTools/Source/C/FCE/Variable.c > delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.c > delete mode 100644 BaseTools/Source/C/FMMT/FmmtLib.c > delete mode 100644 BaseTools/Source/C/FMMT/Rebase.c > delete mode 100755 BaseTools/BinWrappers/PosixLike/BfmLib > delete mode 100755 BaseTools/BinWrappers/PosixLike/FCE > delete mode 100755 BaseTools/BinWrappers/PosixLike/FMMT > delete mode 100644 BaseTools/Source/C/BfmLib/BinFileManager.h > delete mode 100644 BaseTools/Source/C/BfmLib/GNUmakefile > delete mode 100644 BaseTools/Source/C/BfmLib/Makefile > delete mode 100644 BaseTools/Source/C/FCE/BinaryCreate.h > delete mode 100644 BaseTools/Source/C/FCE/BinaryParse.h > delete mode 100644 BaseTools/Source/C/FCE/Common.h > delete mode 100644 BaseTools/Source/C/FCE/Fce.h > delete mode 100644 BaseTools/Source/C/FCE/GNUmakefile > delete mode 100644 BaseTools/Source/C/FCE/IfrParse.h > delete mode 100644 BaseTools/Source/C/FCE/Makefile > delete mode 100644 BaseTools/Source/C/FCE/MonotonicBasedVariable.h > delete mode 100644 BaseTools/Source/C/FCE/TimeBasedVariable.h > delete mode 100644 BaseTools/Source/C/FCE/Variable.h > delete mode 100644 BaseTools/Source/C/FCE/VariableCommon.h > delete mode 100644 BaseTools/Source/C/FMMT/FirmwareModuleManagement.h > delete mode 100644 BaseTools/Source/C/FMMT/FmmtConf.ini > delete mode 100644 BaseTools/Source/C/FMMT/GNUmakefile > delete mode 100644 BaseTools/Source/C/FMMT/Makefile > delete mode 100644 BaseTools/Source/C/FMMT/Rebase.h > > -- > 2.13.0.windows.1 >